Please help - Printing the Employee id

[olu idowu]

Write Payroll class that uses the following private arrays as fields
employeeId – An array of five integers to hold employee identification numbers
hours – An array of five integers to hold the number of hours worked by each employee
payRate – An array of five doubles to hold each employees hourly par rate  
The class should relate the data in each array through the index/subscripts. Use appropriate set methods to initialize the array and get methods to return array.
The class should have method searchEmployee() that accepts an employee’s identification number as an argument and return the gross pay (Gross pay=hours*payRate) for that employee. Uses the sort and binarySearch method from the Arrays class to search the employee and return the gross pay for that employee.
The class should have method getHighest() method that find the highest pay rate of employee and return it.
Write Test class to create object of Payroll class and ask user to enter employee identification, hours worked and payRate of each employee. It should then display each employee’s identification number, hours, payRate and gross pay as per follows. Calculate gross pay=hours*payRate and store it in grossPay array.
Input validation: do not accept negative values for hours , numbers less than 6.00 for pay rate. Handle proper error If employee id does not match in searchEmployee() method

Following is sample run:
User loop to store following value in each array;
Enter emp id = 1 -> five different vale
Enter number of hours worked = 7      -> five different value
Enter employee hourly rate = 10.5      -> five different value

After storing value in each array print information as per follows:

empid	hours		   payRate	   grosspay
1		7		         10.5		73.5
2		8		         20.5		164.0
3		9		         30.5		274.5
4		5		         40.5		202.5
5		6		         50.5		303.0

Enter empid of employee which you want to calculate gross pay? 3
Gross pay of employee=274.5

Highest pay rate of employee=50.5


Or

Enter empid of employee which you want to calculate gross pay? 15
EmployeeId not present in array Index -6 out of bounds for length 5


In testpayroll, the line

for (int index = 0; index < 7 ; index++) {
      System.out.println("empid\thours\tpayRate\tgrosspay\n");
      System.out.println(Arrays.toString(pr.getEmployeeID()) + "\t"+ pr.getHours()+"\t"+pr.setpayRate()+"\t"+ pr.TotalGrossPay());
}

pr.setpayRate() is giving me an error. when i type "payrate" in pr.setpaybrackets it also gives me an error. what can i do?

public class PayRoll {
    private int[] employeeID = new int[7];
    private int hours = 7;
    private int index;
    private double payRate = 7;
    private double[] wages = new double[7];

    public int[] getEmployeeID() {
        return employeeID;
    }

    public void setEmployeeID(int[] employeeID) {
        this.employeeID = employeeID;
    }

    public int getHours() {
        return hours;
    }

    public void setHours(int hours) {
        this.hours = hours;
    }

    public double getpayRate() {
        return payRate;
    }

    public void setpayRate(double payRate) {
        this.payRate = payRate;
    }

    public void setWages(double[] wages) {
        this.wages = wages;
    }

    public double[] getWages() {
        return wages;
    }

    public void TotalGrossPay() {
        for (int index = 0; index < employeeID.length; index++) {
            wages[index] = hours* payRate;   //You need to fill the wages array by the gross pay of each employee
        }
    }
}

import java.util.*;
public class TestPayRoll {
    public static void main(String[] args) {
        double payRate=7; // Hourly pay rate.
        int hours=0; // To hold the hours.
        
        PayRoll pr = new PayRoll();

        // Create a Scanner object for keyboard input.

        Scanner keyboard = new Scanner(System.in);

        for (int index = 0; index < 7 ; index++ ) {
            // Get the EmployeeID.
            System.out.println("EmployeeID:" + Arrays.toString(pr.getEmployeeID()));
            // Get the hours worked.
            System.out.println();
            System.out.println("Enter the hours worked:");
            hours = keyboard.nextInt();
            pr.setHours(hours);
            while (hours < 0){
                // Validate the input.
                System.out.println("The number is invalid, please enter a positive number.");
                System.out.println("Enter the hours worked:");

                hours = keyboard.nextInt();
                pr.setHours(hours);
            } // End of the while loop.
            System.out.println();
            // Get the hourly pay rate.
            System.out.println();
            System.out.println("Enter the hourly rate:");
            payRate = keyboard.nextDouble();
            pr.setpayRate( payRate);
            while (payRate < 6.00) {
                // Validate the input.
                System.out.println("The number is invalid, please enter a number that is not less then 6.00 for pay rate.");
                System.out.println("Enter the hours worked:");
                payRate = keyboard.nextDouble();
            } // End of the while loop
            System.out.println();
        } // End of the for loop
        // Display the the employee's identification  number and gross wages.

        for (int index = 0; index < 7 ; index++) {
            System.out.println("empid\thours\tpayRate\tgrosspay\n");
            System.out.println(Arrays.toString(pr.getEmployeeID()) + "\t"+ pr.getHours()+"\t"+pr.setpayRate()+"\t"+ pr.TotalGrossPay());
        }
    }
}

[Campbell Ritchie]

olu idowu wrote:. . . class that uses the following private arrays as fields . . . relate the data in each array through the index/subscripts. . . .

Where do they set assignments like that requiring poor class design? Or no hint of object‑oriented design?

Your setXXX() methods cannot work as written; you would have to take the employee's id or an array index as a parameter too.

[Campbell Ritchie]

I merged your stuff with the following thread. I hope that is okay by you.

[olu idowu]

I made a java code:

public static void main(String[] args) {
        int value = 5;
        int MAX = 5;
        int employeeid;
        double hours;
        double hourlyrate;
        
       for (int i = 1; i <= value; i++) { 
           Scanner input = new Scanner(System.in);
           System.out.print("Enter Employee id: ");
           employeeid = input.nextInt();
           System.out.print("Enter the number of hours worked: ");
           hours = input.nextDouble();
           System.out.print("Enter Employee hourly rate: ");
           hourlyrate = input.nextDouble();
           System.out.println();
           if (i == value) { 
               System.out.println("empid\thours\tpayRate\tgrosspay");
               for(int number = 0; number <= value; number++) {
                   System.out.println( employeeid + "\t\t" + hours + "\t\t" + hourlyrate);
               }
           }
       }
       
    }

I want to print my code as:
Enter emp id = 1 -> five different vale
Enter number of hours worked = 7      -> five different value
Enter employee hourly rate = 10.5      -> five different value

After storing value in each array print information as per follows:

empid	hours   payRate	grosspay
1		7		10.5		73.5
2		8		20.5		164.0
3		9		30.5		274.5
4		5		40.5		202.5
5		6		50.5		303.0

but the only problem is that when it SHOULD be printing all the employees numbers but it prints out the last employee 5 times:

Enter Employee id: 1
Enter the number of hours worked: 2
Enter Employee hourly rate: 3

Enter Employee id: 2
Enter the number of hours worked: 2
Enter Employee hourly rate: 3

Enter Employee id: 3
Enter the number of hours worked: 2
Enter Employee hourly rate: 3

Enter Employee id: 4
Enter the number of hours worked: 2
Enter Employee hourly rate: 4

Enter Employee id: 5
Enter the number of hours worked: 2
Enter Employee hourly rate: 3

empid	hours	payRate	grosspay
5		2.0		3.0
5		2.0		3.0
5		2.0		3.0
5		2.0		3.0
5		2.0		3.0
5		2.0		3.0

[Paul Clapham]

olu idowu wrote:After storing value in each array...

You didn't put any arrays in your program. So you didn't store the employee ID, or any other employee information in those missing arrays. So when you get to the end of the input process, there aren't any arrays containing the employee information that you need.

[olu idowu]

Paul Clapham wrote:

olu idowu wrote:After storing value in each array...

You didn't put any arrays in your program. So you didn't store the employee ID, or any other employee information in those missing arrays. So when you get to the end of the input process, there aren't any arrays containing the employee information that you need.

Can you show me how to do it?

[Carey Brown]

Like:

int[] employeeid = new int[ value ];
...
for(...) {
    employeeid[i] = input.nextInt();
}

Your loop counter needs to start at zero though.

[Dave Tolls]

Since this is posted in "Java General", do you know how classes work?

I'm asking because that employee data is best put into an Employee class.
Then you can have an array of Employee (Employee[] employees = new Employee[value]).

The other thing that leaps out, your display loop is inside your data input loop.
It ought to be more:

// Populate array
for (int i = 0; i < value; i++) {
    // Create an Employee and put it in slot 'i' of the employees array
}
// Display array
System.out.println("empid\thours\tpayRate\tgrosspay");
for(int number = 0; number <= value; number++) {
    System.out.println( employeeid + "\t\t" + hours + "\t\t" + hourlyrate);
}

If nothing else it removes the need for the if (i == value) check.
And at that point it should become clear that they ought to be different methods.

[olu idowu]

it's still giving me error

[Carey Brown]

olu idowu wrote:it's still giving me error

This doesn't quite help us help you. We'd need to see your code in its current state and we'd need to see the complete (cut and paste) error message.

[Carey Brown]

You might find it useful to Google: java array tutorial

[salvin francis]

I suggest having a look at the java tutorials here : https://docs.oracle.com/javase/tutorial/java/nutsandbolts/arrays.html

[Campbell Ritchie]

olu idowu wrote:I made a java code: . . . .

But that is different from what you said you had been instructed to do, in your other thread. However bad the instructions might be, you will have to follow them if you want good marks.

[Campbell Ritchie]

I merged your stuff with the following thread. I hope that is okay by you.

[olu idowu]

How do I print something only once in a for loop?


 

System.out.println("Employee name\tEmployee id\t\tHours Worked\t\tpayRate\t\tgrosspay");
                for (int number = 0; number <= Max; number++) {
                    System.out.println(EmployeeName+ "                      " + IDnumber + "              " + HoursWorked + "             " + HourlyPayRate + "          " + pay.getGrossPay(HoursWorked, HourlyPayRate));
                }

I want to put the code above in the this code below and i want the above code to print once at the end of bottom of the code (inside the for loop).

for (int x = 1; x <= Max; x++) {
            //Get the employee's name.
            System.out.println("Enter an employee's name: ");
            EmployeeName = keyboard.nextLine();

            //Get the employee's ID.
            System.out.println("Enter the employee's ID ");
            IDnumber = keyboard.nextInt();

            //Get the number of hours worked by the employee.
            System.out.println("Enter the amount of hours worked by this employee: ");
            HoursWorked = keyboard.nextDouble();

            //Get the hourly pay rate of the employee.
            System.out.println("Enter the hourly pay rate for this employee: ");
            HourlyPayRate = keyboard.nextDouble();

            //Create a payroll object, passing EmployeeName and IDnumber
            // as arguments to the constructor.
            PayRoll pay = new PayRoll(EmployeeName, IDnumber); 
            
        }

[Carey Brown]

The obvious answer is to put it outside of the  for() loop, either before or after. If that is not possible then you'd need an if() that would be true at one point in the loop iterations.

[Carey Brown]

If this question was in regards to your other post(s) then I suggest in the future you continue your questions in your already existing threads.

[Carey Brown]

Carey Brown wrote:The obvious answer is to put it outside of the  for() loop, either before or after.

Caution: Sometimes conditions exist where the body of a loop is never even entered, having the print inside the loop may not be what you want in this case.

[olu idowu]

Carey Brown wrote:The obvious answer is to put it outside of the  for() loop, either before or after. If that is not possible then you'd need an if() that would be true at one point in the loop iterations.

It gives me error if i put it outside the loop

[fred rosenberger]

well, then fix that error.

In all seriousness, we cannot help you if you don't show us the code that is giving the error.  Also, tell us what EXACTLY the error says.  You should try and make is as easy as possible for people to help you if you want help.  

[Campbell Ritchie]

olu idowu wrote:. . .  this code below  . . .

That code won't work. You were told to create multiple arrays, which is bad design, but you have to do what you are told if you want good marks. You are not showing any sign of using the arrays in that loop. You did have arrays in your earlier code. You are going to have to put those data into the arrays.
By the way: the standard form for a for loop is this:-

for (int i = 0; i < myArray.length; i++)
{
   doSomethingWith(myArray[i]);
}

The reason for using that form of loop as a default is that it works. In the instance I showed you, it always works; it matches the structure of an array exactly. You may need to use a different loop header in some circumstances, but I don't believe there are special circumstances here. Don't start from 1 and don't use <=.

[Campbell Ritchie]

Carey Brown wrote:. . . continue your questions in your already existing threads.

Agree. I shall merge the three threads.

[Campbell Ritchie]

the forum software, on my behalf wrote:. . . I have merged your topic into this topic. . . .

We can now remind ourselves of the requirements. You appear not to have read them. Your first attempt at code might be better than what you posted more recently, but you neither created the number of arrays specified, nor the size of arrays specified. I know that one of Murphy's Laws reads,

When all else fails, read the instructions,

but in the case of assignments you need to read the instructions first.

[olu idowu]

fred rosenberger wrote:well, then fix that error.

In all seriousness, we cannot help you if you don't show us the code that is giving the error.  Also, tell us what EXACTLY the error says.  You should try and make is as easy as possible for people to help you if you want help.  

why I post my question if i don't know how to fix my code?

[Carey Brown]

Guidelines:

Do not start new threads for each question on the same project.

When you are discussing code that you have changed since the last time you posted the code, then it is time to post the current version of the code so we can keep in sync.

When you have an error message, cut and paste the entire error message into your post.

Try to follow suggestions offered to you and post the new code with your attempts for comments and suggestions.

Based on numerous previous suggestions I would expect to see new code from you showing how you turned each of the Employee fields into arrays.

[olu idowu]

PLEASE HELP!
How do i do this part at the end of the main method:
This is an example:

Enter empid of employee which you want to calculate gross pay? 3
Gross pay of employee=274.5

Highest pay rate of employee=50.5

I have changed the code and this code works:
Main Method

import java.util.*;
public class TestPayRoll {
    static public char restart;
    public static void main(String[] args) {
        int[] idArr = new int[5], hoursArr = new int[5];
        double[] payArr = new double[5];
        try {
            Scanner scan = new Scanner(System.in);
            for (int i = 0; i < 5; i++) {
                System.out.print("Enter employee id: ");
                idArr[i] = scan.nextInt();

                System.out.print("Enter # of hours worked: ");
                int hours = scan.nextInt();
                while (hours < 0) {
                    System.out.println("Invalid # of hours entered.");
                    System.out.print("Enter # of hours worked: ");
                    hours = scan.nextInt();
                }
                hoursArr[i] = hours;

                System.out.print("Enter pay rate: ");
                double rate = scan.nextDouble();
                while (rate < 6) {
                    System.out.println("Invalid pay rate entered.");
                    System.out.print("Enter pay rate: ");
                    rate = scan.nextDouble();
                }
                payArr[i] = rate;
            }
        }catch (Exception e){
            System.out.println("INVALID ENTRY. You did not enter an integer. Try again.");
            restart = 'y';
        }
        PayRoll payroll = new PayRoll(idArr,hoursArr,payArr);
        System.out.println("\n" + payroll.toString());
    }
}

PayRoll Method

import java.util.Arrays;

public class PayRoll {
    private final int[] employeeId;
    private final int[] hours;
    private final double[] rate;


    public PayRoll(int[] employeeId, int[] hours, double[] rate) {
        this.employeeId = employeeId;
        this.hours = hours;
        this.rate = rate;
    }

    public int[] getEmployeeId() {
        return employeeId;
    }

    public int[] getHours() {
        return hours;
    }

    public double[] getRate() {
        return rate;
    }

    public double searchEmployee(int id) {
        Arrays.sort(employeeId);
        double grossPay = 0;
        int idx = Arrays.binarySearch(employeeId, id);
        if (idx > -1) {
            grossPay = hours[idx] * rate[idx];
        }

        return grossPay;
    }

    public double getHighest() {
        double max = rate[0];
        for (double v : rate) {
            if (v > max) {
                max = v;
            }
        }
        return max;
    }

    @Override
    public String toString() {
        String s = "";


        for (int i = 0; i < employeeId.length; i++) {
            double wages = hours[i]*rate[i];
            s += employeeId[i] + "\t\t\t" + hours[i] + "\t\t" + rate[i] + "\t"+wages+"\n";
        }
        return "Employee ID\tHours\tRate\tGross Pay\n" + s;
    }

}

[olu idowu]

olu idowu wrote:PLEASE HELP!
How do i do this part at the end of the main method:
This is an example:

Enter empid of employee which you want to calculate gross pay? 3
Gross pay of employee=274.5

Highest pay rate of employee=50.5

I have changed the code and this code works:
Main Method

import java.util.*;
public class TestPayRoll {
    static public char restart;
    public static void main(String[] args) {
        int[] idArr = new int[5], hoursArr = new int[5];
        double[] payArr = new double[5];
        try {
            Scanner scan = new Scanner(System.in);
            for (int i = 0; i < 5; i++) {
                System.out.print("Enter employee id: ");
                idArr[i] = scan.nextInt();

                System.out.print("Enter # of hours worked: ");
                int hours = scan.nextInt();
                while (hours < 0) {
                    System.out.println("Invalid # of hours entered.");
                    System.out.print("Enter # of hours worked: ");
                    hours = scan.nextInt();
                }
                hoursArr[i] = hours;

                System.out.print("Enter pay rate: ");
                double rate = scan.nextDouble();
                while (rate < 6) {
                    System.out.println("Invalid pay rate entered.");
                    System.out.print("Enter pay rate: ");
                    rate = scan.nextDouble();
                }
                payArr[i] = rate;
            }
        }catch (Exception e){
            System.out.println("INVALID ENTRY. You did not enter an integer. Try again.");
            restart = 'y';
        }
        PayRoll payroll = new PayRoll(idArr,hoursArr,payArr);
        System.out.println("\n" + payroll.toString());
    }
}

PayRoll Method

import java.util.Arrays;

public class PayRoll {
    private final int[] employeeId;
    private final int[] hours;
    private final double[] rate;


    public PayRoll(int[] employeeId, int[] hours, double[] rate) {
        this.employeeId = employeeId;
        this.hours = hours;
        this.rate = rate;
    }

    public int[] getEmployeeId() {
        return employeeId;
    }

    public int[] getHours() {
        return hours;
    }

    public double[] getRate() {
        return rate;
    }

    public double searchEmployee(int id) {
        Arrays.sort(employeeId);
        double grossPay = 0;
        int idx = Arrays.binarySearch(employeeId, id);
        if (idx > -1) {
            grossPay = hours[idx] * rate[idx];
        }

        return grossPay;
    }

    public double getHighest() {
        double max = rate[0];
        for (double v : rate) {
            if (v > max) {
                max = v;
            }
        }
        return max;
    }

    @Override
    public String toString() {
        String s = "";


        for (int i = 0; i < employeeId.length; i++) {
            double wages = hours[i]*rate[i];
            s += employeeId[i] + "\t\t\t" + hours[i] + "\t\t" + rate[i] + "\t"+wages+"\n";
        }
        return "Employee ID\tHours\tRate\tGross Pay\n" + s;
    }

}

Nevermind I got it

[Carey Brown]

    public double searchEmployee(int id) {
        Arrays.sort(employeeId);
        double grossPay = 0;
        int idx = Arrays.binarySearch(employeeId, id);
        if (idx > -1) {
            grossPay = hours[idx] * rate[idx];
        }
 
        return grossPay;
    }

This is problematic from several points. You are correct that you can't do a binary search unless the IDs are sorted. However, your structure has several arrays that need to be kept in sync and by sorting IDs that array is no longer in sync with the other arrays. I'm afraid that you'll need to do a basic linear search, in which case it would be best that it return the array index and then that index can be used by other methods for calculations, printing, etc.. Your "search" method is doing more than searching, it is also "calculating" grossPay. You should split off the grossPay calculation into its own method.

Seeing as how your search method will now be returning an index, several of your methods may benefit from having an index added as one of the parameters. Example:

public double calculateGrossPay( int index ) {
    double grossPay = 0.0;
    if( index >= 0 ) {
        grossPay = hours[ index ] * rate[ index ];
    }
    return grossPay;
}

[Campbell Ritchie]

Carey Brown wrote:. . . basic linear search . . .

Since the arrays are supposed to have length = 5, a linear search is hardly going to cause slow execution. It will be quick enough to implement, too.
There is a problem with arrays and many implementations of ID numbers: how will we know that the numbers are unique? Most search algorithms report the location of the first found element and don't test whether there are are any other matching elements.

[Carey Brown]

import java.util.Arrays;
import java.util.Scanner;

/*
 * This is not an "object oriented" design but is modified from
 * provided code to show how a keyboard utility can clean things
 * up. See:
 * https://coderanch.com/t/731480/java/Printing-Employee-id
 */
public class PayRollTest
{
	public static void main( String[] args )
	{
		int[]		idArr = new int[5];
		int[]		hoursArr = new int[5];
		double[]	payArr = new double[5];
		
		for( int i = 0 ; i < 5 ; i++ )
		{
			idArr[i]	= Keyboardv.promptInt( "Enter employee id: " );
			hoursArr[i]	= Keyboardv.promptIntRange( "Enter # of hours worked (0-80): ", 0, 80 );
			payArr[i]	= Keyboardv.promptDoubleRange( "Enter pay rate (6-100): ", 6, 100 );
		}
		
		PayRoll payroll = new PayRoll( idArr, hoursArr, payArr );
		System.out.println( "\n" + payroll.toString() );
	}
}

//======================================================================
class PayRoll
{
	private final int[] employeeId;
	private final int[] hours;
	private final double[] rate;

	public PayRoll( int[] employeeId, int[] hours, double[] rate )
	{
		this.employeeId = employeeId;
		this.hours = hours;
		this.rate = rate;
	}

	public int[] getEmployeeId()
	{
		return employeeId;
	}

	public int[] getHours()
	{
		return hours;
	}

	public double[] getRate()
	{
		return rate;
	}

	public double searchEmployee( int id )
	{
		Arrays.sort( employeeId );
		double grossPay = 0;
		int idx = Arrays.binarySearch( employeeId, id );
		if( idx > -1 )
		{
			grossPay = hours[idx] * rate[idx];
		}

		return grossPay;
	}

	public double getHighest()
	{
		double max = rate[0];
		for( double v : rate )
		{
			if( v > max )
			{
				max = v;
			}
		}
		return max;
	}

	@Override
	public String toString()
	{
		String s = "";

		for( int i = 0 ; i < employeeId.length ; i++ )
		{
			double wages = hours[i] * rate[i];
			s += employeeId[i] + "\t\t\t" + hours[i] + "\t\t" + rate[i] + "\t"
					+ wages + "\n";
		}
		return "Employee ID\tHours\tRate\tGross Pay\n" + s;
	}

}


//======================================================================
// Keyboard Utility class stripped down to the minimum to meet this
// project's requirements only. Note that all keyboard entry should be
// done by calling nextLine(). This guarantees that no input
// residue has been left in the input stream. For a more complete
// version see:
// https://coderanch.com/t/685118/java/FYI-wrapper-class-Scanner-System#3305839

class Keyboardv
{
	private static final Scanner KBD = new Scanner( System.in );

	public static String nextLine()
	{
		return KBD.nextLine();
	}

	public static double promptDouble( String prompt )
	{
		while( true )
		{
			try
			{
				System.out.print( prompt );
				return Double.parseDouble( nextLine().trim() );
			}
			catch( java.lang.NumberFormatException p )
			{
				System.out.println( "Error: invalid number." );
			}
		}
	}

	// min & max are inclusive
	public static double promptDoubleRange( String prompt, double min, double max )
	{
		while( true )
		{
			double dbl = promptDouble( prompt );
			if( dbl >= min && dbl <= max )
				return dbl;
			System.out.println( "Error: number is out of range." );
		}
	}

	public static int promptInt( String prompt )
	{
		while( true )
		{
			try
			{
				System.out.print( prompt );
				return Integer.parseInt( nextLine().trim() );
			}
			catch( java.lang.NumberFormatException p )
			{
				System.out.println( "Error: invalid integer." );
			}
		}
	}

	// min & max are inclusive
	public static int promptIntRange( String prompt, int min, int max )
	{
		while( true )
		{
			int i = promptInt( prompt );
			if( i >= min && i <= max )
				return i;
			System.out.println( "Error: number is out of range." );
		}
	}
}

[Liutauras Vilda]

OP

You have such method in PayRoll class as:
public double getHighest()

Now, put yourself into the shoes of user of the class, and try to guess what that may mean. Get highest what?

After looking to three fields of PayRoll class: [1]employeeId, [2]hours, [3]rate; I also would have hard times to guess what getHighest() mean.


Try to come up with something much more descriptive, so it would be absolutely obvious and unambiguous reading method name what it would return.


Also similar story with getHours(). Is it total hours in a day/week/month/year? Is it actually worked hours by an employee? Something else?