404 not found - Spring boot - Rest api

[ssiva raman]

I've created a simple rest api. when i tried to hit the resource , i get 404 not found error. i googled but couldn't find any help. can somebody guide me?

P.S: if you need anymore information , let me know.

@RestController
@RequestMapping("/catalog")
public class MovieCatalogCtrl {
	
	@RequestMapping("/{userId}")
	public List<CatalogItem> getCatalogs(@PathVariable("userId")String userId)
	{
		System.out.println("userid: "+userId);
		return Collections.singletonList(
				new CatalogItem("Transformers", "action- Sci-Fic", 4)
				);
	}

}

public class CatalogItem {
	
	private String name;
	private String desc;
	private int rating;
	public CatalogItem(String name, String desc, int rating) {
		super();
		this.name = name;
		this.desc = desc;
		this.rating = rating;
	}
	public String getName() {
		return name;
	}
	public void setName(String name) {
		this.name = name;
	}
	public String getDesc() {
		return desc;
	}
	public void setDesc(String desc) {
		this.desc = desc;
	}
	public int getRating() {
		return rating;
	}
	public void setRating(int rating) {
		this.rating = rating;
	}

}

Error:

2020-10-04 13:50:53.129 DEBUG 18704 --- [nio-8080-exec-2] o.a.coyote.http11.Http11InputBuffer      : Received [GET /catalog/1 HTTP/1.1
User-Agent: PostmanRuntime/7.26.5
Accept: */*
Cache-Control: no-cache
Postman-Token: 2d855b91-4ee7-408f-99f0-5d89780e7902
Host: localhost:8080
Accept-Encoding: gzip, deflate, br
Connection: keep-alive

]
2020-10-04 13:50:53.129 DEBUG 18704 --- [nio-8080-exec-1] o.apache.coyote.http11.Http11Processor   : Error parsing HTTP request header

java.io.EOFException: null
at org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper.fillReadBuffer(NioEndpoint.java:1231) ~[tomcat-embed-core-9.0.38.jar:9.0.38]
at org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper.read(NioEndpoint.java:1141) ~[tomcat-embed-core-9.0.38.jar:9.0.38]
at org.apache.coyote.http11.Http11InputBuffer.fill(Http11InputBuffer.java:791) ~[tomcat-embed-core-9.0.38.jar:9.0.38]
at org.apache.coyote.http11.Http11InputBuffer.parseRequestLine(Http11InputBuffer.java:355) ~[tomcat-embed-core-9.0.38.jar:9.0.38]
at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:261) ~[tomcat-embed-core-9.0.38.jar:9.0.38]
at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65) ~[tomcat-embed-core-9.0.38.jar:9.0.38]
at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868) ~[tomcat-embed-core-9.0.38.jar:9.0.38]
at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1590) ~[tomcat-embed-core-9.0.38.jar:9.0.38]
at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) ~[tomcat-embed-core-9.0.38.jar:9.0.38]
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[na:na]
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[na:na]
at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) ~[tomcat-embed-core-9.0.38.jar:9.0.38]
at java.base/java.lang.Thread.run(Thread.java:835) ~[na:na]

[Stephan van Hulst]

Show us where you have your application configured to use Spring as the front controller. Are you using Spring boot? Do you have a web.xml?

[ssiva raman]

hi Stephan,

thank you for the reply.

yes , I'm using spring boot.

Please find the pom.xml.

<?xml version="1.0" encoding="UTF-8"?> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"> <modelVersion>4.0.0</modelVersion> <parent> <groupId>org.springframework.boot</groupId> <artifactId>spring-boot-starter-parent</artifactId> <version>2.3.4.RELEASE</version> <relativePath/> <!-- lookup parent from repository --> </parent> <groupId>com.exampl.moviecatlog</groupId> <artifactId>Moive-Catalog-Service</artifactId> <version>0.0.1-SNAPSHOT</version> <name>Movie_Catalog_Svcs</name> <description>Demo project for Spring Boot</description> <properties> <java.version>11</java.version> </properties> <dependencies> <dependency> <groupId>org.springframework.boot</groupId> <artifactId>spring-boot-starter-web</artifactId> </dependency> <dependency> <groupId>org.springframework.boot</groupId> <artifactId>spring-boot-starter-test</artifactId> <scope>test</scope> <exclusions> <exclusion> <groupId>org.junit.vintage</groupId> <artifactId>junit-vintage-engine</artifactId> </exclusion> </exclusions> </dependency> </dependencies> <build> <plugins> <plugin> <groupId>org.springframework.boot</groupId> <artifactId>spring-boot-maven-plugin</artifactId> </plugin> </plugins> </build> </project>

[Stephan van Hulst]

Does your application contain a context.xml file?

[ssiva raman]

Stephan van Hulst wrote:Does your application contain a context.xml file?

No, Stephan.

[Stephan van Hulst]

Do you have a main class annotated with @SpringBootApplication? What package is it in? What package is your controller in?

[ssiva raman]

Stephan van Hulst wrote:Do you have a main class annotated with @SpringBootApplication? What package is it in? What package is your controller in?

They are in different package. is it a problem?

package com.example.demo;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;

@SpringBootApplication
public class MovieCatalogSvcsApplication {

	public static void main(String[] args) {
		SpringApplication.run(MovieCatalogSvcsApplication.class, args);
	}

}

package com.example.Controller;

import java.util.Collections;
import java.util.List;

import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RestController;

import com.example.entities.CatalogItem;

@RestController
@RequestMapping("/catalog")
public class MovieCatalogCtrl {
	
	@RequestMapping("/{userId}")
	public List<CatalogItem> getCatalogs(@PathVariable("userId")String userId)
	{
		System.out.println("userid: "+userId);
		return Collections.singletonList(
				new CatalogItem("Transformers", "action- Sci-Fic", 4)
				);
	}

}

[Stephan van Hulst]

Yes, I think this is causing your issue.

By default, component scanning occurs in the package of your main application class, or sub-packages. com.example.Controller is not a sub-package of com.example.demo.

You could specify the name of the package to scan for components like this:

@SpringBootApplication(scanBasePackages = {"com.example.demo", "com.example.Controller"})

It's better however, to instead use a more sensible package hierarchy. For instance, if com.example.demo is the base package of your project, put the main application class in com.example.demo.spring and put your controllers in com.example.demo.spring.controller. This will enable component scanning for the com.example.demo.spring package (and also its sub-packages like com.example.demo.spring.controller) while skipping it for packages that don't need it. That way you could put your business model in com.example.demo, and it won't take up any resources being scanned needlessly.

• src/main/java/
  • com/example/demo/
    • Movie.java
    • spring/
      • MovieCatalogSvcsApplication.java
      • controller/
        • MovieCatalogController.java

Please use proper Java naming conventions. Package name elements should not be capitalized, and write out names (e.g. Controller instead of Ctrl).

[ssiva raman]

Stephan van Hulst wrote:Yes, I think this is causing your issue.

you're right, Stephan. thank you for spotting.

By default, component scanning occurs in the package of your main application class, or sub-packages. com.example.Controller is not a sub-package of com.example.demo.

The below change solved the problem. However , i'll rearrange the project hierarchy as you suggested.

@SpringBootApplication(scanBasePackages = "com.example.Controller")
public class MovieCatalogSvcsApplication {

	public static void main(String[] args) {
		SpringApplication.run(MovieCatalogSvcsApplication.class, args);
	}

}

You could specify the name of the package to scan for components like this:

@SpringBootApplication(scanBasePackages = {"com.example.demo", "com.example.Controller"})

It's better however, to instead use a more sensible package hierarchy. For instance, if com.example.demo is the base package of your project, put the main application class in com.example.demo.spring and put your controllers in com.example.demo.spring.controller. This will enable component scanning for the com.example.demo.spring package (and also its sub-packages like com.example.demo.spring.controller) while skipping it for packages that don't need it. That way you could put your business model in com.example.demo, and it won't take up any resources being scanned needlessly.

• src/main/java/
  • com/example/demo/
    • Movie.java
    • spring/
      • MovieCatalogSvcsApplication.java
      • controller/
        • MovieCatalogController.java

Please use proper Java naming conventions. Package name elements should not be capitalized, and write out names (e.g. Controller instead of Ctrl).

sure, thank you for the suggestions.