Open connection issues

[Jack Tauson]

Brief Overview of my code:

I have the following Java process which is listening to MyMessageQueue queue of ActiveMQ.
As soon as it gets the message in the format userName#employeeID#companyID#projectID#clientTitle , I am extracting and using in my code below.

The code keeps on sending message in the format userName#employeeID#companyID#projectID#clientTitle back to ActiveMQ until it sees
if (receivedStatus.equals("COMPLETE")) { and sends out an email.

The problem I am facing is that after the whole process(which sometime could take few mins or 30 mins) is finished I am seeing open inactive connections. Basically my DBA is complaining about connections which are not closed. The connection count is
increasing after each use of this process. Any idea what's wrong with the connections in my code below?





 

  @Component
    public class MessageConsumer {
    
       @Autowired
       private JavaMailSender javaMailSender;
    
       // one instance, reuse
       private final CloseableHttpClient httpClient = HttpClients.createDefault();
    
       private static Connection connection;
    
       // URL of the JMS server. DEFAULT_BROKER_URL will just mean that JMS server is on localhost
       private static String url = ActiveMQConnection.DEFAULT_BROKER_URL;
       private static String subject = "MyMessageQueue"; //Queue Name
       // default broker URL is : tcp://localhost:61616"
       private static ClassPathXmlApplicationContext context = new ClassPathXmlApplicationContext("ApplicationContext.xml");
       private static final Logger logger = LoggerFactory.getLogger(MessageConsumer.class);
       private static final DateFormat sdf = new SimpleDateFormat("yyyy/MM/dd HH:mm:ss");
    
       // Working Code with JMS 2.0
       @JmsListener(destination = "MyMessageQueue")
       public void processBrokerQueues(String message) throws DaoException, JMSException {
    	   
    	   
    	   System.out.println("Message Retrieved is:" +message);
          try {
    
             RequestDao requestDao = (RequestDao) context.getBean("requestDao");
             String receivedStatus = requestDao.getRequestStatus(message);
            
             //Retrieve Username from the message to include in an email
             String[] parts = message.split("#");
             String userName = parts[1].trim();
             String employeeID = parts[3].trim();
             String companyID = parts[4].trim();
    	     String projectID = parts[5].trim();
    	     String clientTitle = parts[6].trim();
    	     
    	     
    
             //Before sending this message, do the check for COMPLETE or ERROR etc
             if (receivedStatus.equals("COMPLETE")) {
                //Go and Get the latest UUID from the database table 
                String latestUUID = requestDao.getUUID();
                requestDao.sendMessage(message, latestUUID);
                
                String recipientEmail = userName+"@mycompany.com";
                String emailMessage = "Dear "+userName+",<p>Your files are ready. ";
    			logger.info("Email sent to the user "+userName+" at the following email address: "+userName+"@mycompany.com");
    
                /*****************************************************\
                 // START: EMAIL Related Code
                 *******************************************************/
    
    				
    				  MimeMessage msg = javaMailSender.createMimeMessage(); 
    				  MimeMessageHelper helper = new MimeMessageHelper(msg, true);
    				  helper.setFrom("[e-mail]"); 
    				  helper.setTo(recipientEmail);
    				  helper.setSubject("Requested Files !"); 
    				  helper.setText(emailMessage,true);
    				 javaMailSender.send(msg);
    	 
                 //Object for calling an endpoint
    			 MessageConsumer saveDetailObj = new MessageConsumer();
    				
    				  try {
    				 
    				  logger.info("Calling saveDetails() for associations "); 
    				  saveDetailObj.saveDetails(userName,latestUUID,employeeID,companyID,projectID,clientTitle); 
    				  			  
    				  }
    				  finally { saveDetailObj.close(); }
    				  } else {
                try {
                   if (connection == null) {
                      createConnection();
                   }
                   Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
    
                   // Destination represents here our queue 'MyMessageQueue' on the  JMS server
                   Destination destination = session.createQueue(subject);
    
                   MessageProducer producer = session.createProducer(destination);
    
                   //Sending message to the queue
                   TextMessage toSendMessage = session.createTextMessage(message);
    
                   long delay = 60 * 1000;
                   long period = 60 * 1000;
    
                   toSendMessage.setLongProperty(ScheduledMessage.AMQ_SCHEDULED_DELAY, delay);
                   toSendMessage.setLongProperty(ScheduledMessage.AMQ_SCHEDULED_PERIOD, period);
    
                   producer.send(toSendMessage);
                } catch (Throwable th) {
                   th.printStackTrace();
                   
                   // if there are any problems close the connection and it will be re-created next time
                  if (connection != null) {
                      connection.close();
                   }
                   connection = null;
                }
             }
          } catch (Throwable th) {
             th.printStackTrace();
          }
        
       }
       
       private void createConnection() throws JMSException {
          // Getting JMS connection from the server
          ConnectionFactory connectionFactory = new ActiveMQConnectionFactory(url);
          connection = connectionFactory.createConnection();
       }
       
       private void close() throws IOException {
           httpClient.close();
       }
       
       //Start : Plugging in newly created webservice saveDetails
       //********************************************************************************\\
       
       private void saveDetails(String userName,String latestUUID,String employeeID,String companyID,String projectID,String clientTitle) throws Exception {
    	      	   
    	   	   
    	   String fileNameWithUUID = "cdd_p_"+userName+"_"+latestUUID+".zip";
    	   logger.info("Full Path Name: "+fileNameWithUUID);
    	   Date date = new Date();
           String titleDescription = "CustomDataSet_"+sdf.format(date)+"_"+clientTitle;
    	   logger.info("clientTitle(Retrieved one below)");
           logger.info(titleDescription);
           
    	   
    	   
    	   HttpPost post = new HttpPost("https://myserver.hs.mycompany.com/MessageServices/abc/saveDetails");
    	   StringEntity params =new StringEntity("{\"assetTypeId\":\"12\","
                   + "\"fileName\":\""+fileNameWithUUID+"\","
                      + "\"companyTypeId\":\"1\","
                      + "\"path\":\"\","
                      + "\"companyUri\":\"\","
                      + "\"fileVersion\":\"1.0\","
                      + "\"fileEncodingId\":\"\","
                      + "\"ownerId\":\""+employeeID+"\","
                      + "\"createdDate\":\"\","
                      + "\"companyCategoryId\":\"1\","
                      + "\"titleDetails\":\""+titleDescription+"\","
                      + "\"createdBy\":\""+employeeID+"\","
                      + "\"updatedDate\":\"\","
                      + "\"fullPathName\":\"/mnt/nfs/Data/prod/messages/"+userName+"/"+fileNameWithUUID+"\","
                      + "\"userName\":\""+userName+"\","
                      + "\"companyID\":\""+companyID+"\","
                      + "\"projectid\":\""+projectID+"\","
                      + "\"nextLevelId\":\"2\" } ");
    	   
    	   post.addHeader("Content-type", "application/json");
           post.addHeader("Accept", "application/json");
           post.setEntity(params);
           CloseableHttpResponse response = httpClient.execute(post);
           	   
       }
       
       
       
      //END : Plugging in newly created webservice saveDetails
      //********************************************************************************\\
       
         
       
       
    }

[Paul Clapham]

For a start I would advise closing the connection in a finally-clause.

[Jack Tauson]

Paul Clapham wrote:For a start I would advise closing the connection in a finally-clause.

You mean something like the following at the following location:

 

// if there are any problems close the connection and it will be re-created next time
             if (connection != null) {
                 connection.close();
              }
              connection = null;
           }
        }
     } catch (Throwable th) {
        th.printStackTrace();
     }
    finally {
    if(connection != null) {
     connection.close();
    }
     }
  }

[Paul Clapham]

I couldn't really say. I don't know what the method is supposed to do, although I think it's supposed to handle a single String. And it's quite hard to tell what it is doing because the indentation is all over the place and I can't tell what code is in what code blocks. And you're catching the exception twice, which I can't really follow.

The other thing is, it looks to me like maybe the code is designed so that it may return from that method without closing the connection. Seems to me that's a possible cause of orphaned connections -- is that really necessary? Why not have the method start by getting a connection, then use it, then close it when you're finished? That would be where the finally block is used.