Basically this code can run to send email & sms notification to customer. I need to do some changes.

[ginny lim]

I'm stuck to make some changes on this coding, to ensure no emails sent via bpaNotificationService if email in

OrderContact

object (in the CustomerOrder class) is null, so it doesn't throw error logs? And also to include an info logger to say that "not sending email because no email is given".

This is only if it's email notification only, which is checking whether email notification key is not null.

Generally in the

OrderContact

list, we have

contactType

Order

. Thus, my idea is to:

Use the

ContactUtil

to get the specific

OrderContact

object from

customerOrder.getOrderContact()

.
Once I got the specific

OrderContact

object, check whether got email to send the notifications.

@EEAction(value = "customer.sendNotification")
public class SendNotificationAction extends EEWorkflowAction {
    private final NotificationService novusNotificationService;
    private final sg.com.bpa.executionengine.notification.service.NotificationService bpaNotificationService;
    public SendNotificationAction(NotificationService novusNotificationService, sg.com.bpa.executionengine.notification.service.NotificationService bpaNotificationService) {
        this.novusNotificationService = novusNotificationService;
        this.bpaNotificationService = bpaNotificationService;
    }
    @Override
    public EEActionResponse executeEEAction(EEActionRequest actionRequest, CustomerOrder customerOrder) {
        log.info("Sending Notification for {} with notification type: {}",
                OrderAttributeKey.BILLING_ACCOUNT_ID.getValue(customerOrder), actionRequest.getProcessVariable(ProcessVariable.NOTIFICATION_TYPE));
        if (MailTemplate.doesNotificationExist(actionRequest.getProcessVariable(ProcessVariable.NOTIFICATION_TYPE)) ||
                SmsTemplate.doesNotificationExist(actionRequest.getProcessVariable(ProcessVariable.NOTIFICATION_TYPE))) {
            bpaNotificationService.sendNotification(actionRequest, customerOrder);
        } else {
            novusNotificationService.sendNotification(actionRequest, customerOrder);
        }
        return createResponse();
    }
}

[s ravi chandran]

You can always use class diagram that reflects the sample view of your existing project. Its easier to understand the problem.

you can start with breaking down your requirement and code for each step.

taking your code snippet for reference with this crude mock up:

 @Override
   public class SendNotificationAction extends EEWorkflowAction {

             1. conditional check for contact value existing in CustomerOrder
             2. if ustomerOrder orderContact exists, go to step 3
             3. check for new mails for this contact 
             4. if a new mail exists, call step 5 else call step 6
             5. dispatch new mail notification 
             6. log message saying no new mail present
    }

Also try to segregate the workflow into multiple methods, with each one doing a single action. so each step here would ideally go into a function.

do get back if you have more queries on this.