Forums:

Thymeleaf validations not working

Petra Petrova

Greenhorn

Posts: 14

I like...

posted 1 year ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hello,

I am new to Spring web and I am having difficulties with an assignment. The Thymeleaf validations are not working at all (my goal is an error message to appear where there is a mistake and the page to keep the correctly filled fields) and the page does not redirect as it should. I will be very happy if you could direct me as I am stuck on this one for quite some time .

The controller:

package com.example.app.web;

import com.example.app.model.binding.AddCompanyBindingModel;
import com.example.app.model.service.CompanyServiceModel;
import com.example.app.service.CompanyService;
import org.modelmapper.ModelMapper;
import org.springframework.stereotype.Controller;
import org.springframework.validation.BindingResult;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.ModelAttribute;
import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.servlet.mvc.support.RedirectAttributes;

import javax.validation.Valid;

@Controller
@RequestMapping("/companies")
public class CompanyController {

private final CompanyService companyService;
    private final ModelMapper mapper;

public CompanyController(CompanyService companyService, ModelMapper mapper) {
        this.companyService = companyService;
        this.mapper = mapper;
    }

@ModelAttribute
    public AddCompanyBindingModel addCompanyBindingModel() {
        return new AddCompanyBindingModel();
    }

@GetMapping("/add")
    public String showAddCompanyForm() {

return "company-add";
    }

@PostMapping("/add")
    public String addCompany(@Valid AddCompanyBindingModel addCompanyBindingModel,
                                    BindingResult br, RedirectAttributes rAtt) {
        if (br.hasErrors()) {
        
            rAtt
                    .addFlashAttribute("companyBindingModel", addCompanyBindingModel)
                    .addFlashAttribute("org.springframework.validation.BindingResult.addCompanyBindingModel", br);
            return "redirect:add";
        }

CompanyServiceModel serviceModel = this.mapper.map(addCompanyBindingModel, CompanyServiceModel.class);
        this.companyService.addCompany(serviceModel);

return "redirect:/";

}
}

Binding Model

package com.example.app.model.binding;

import javax.validation.constraints.*;
import java.math.BigDecimal;

public class AddCompanyBindingModel {

@Positive
    @NotNull
    private BigDecimal budget;
    @NotNull
    @Min(10)
    private String description;
    @NotBlank
    @Size(min=2, max=10)
    private String name;
    @NotBlank
    @Size(min=2, max=10)
    private String town;

public AddCompanyBindingModel() {
    }

public BigDecimal getBudget() {
        return budget;
    }

public AddCompanyBindingModel setBudget(BigDecimal budget) {
        this.budget = budget;
        return this;
    }

public String getDescription() {
        return description;
    }

public AddCompanyBindingModel setDescription(String description) {
        this.description = description;
        return this;
    }

public String getName() {
        return name;
    }

public AddCompanyBindingModel setName(String name) {
        this.name = name;
        return this;
    }

public String getTown() {
        return town;
    }

public AddCompanyBindingModel setTown(String town) {
        this.town = town;
        return this;
    }
}

Company-add Template

<!DOCTYPE html>
<html lang="en"
      xmlns:th="http://www.thymeleaf.org">
<head th:replace="fragments/head::head"></head>
<body>

<div class="row">
    <div class="col-md-2"></div>
    <main class="jumbotron text-center rounded col-md-8 align-self-center">
        <div class="justify-content-center">
            <h1>Add Company</h1>
        </div>
        <form
              th:object="${addCompanyBindingModel}"
              th:action="@{/companies/add}"
              th:method="post"
              class="m-md-auto w-50 text-center">

<div class="form-group">
                <label for="name">Name</label>
                <input
                        th:field="*{name}"
                        type="text" class="form-control text-center"
                        id="name" aria-describedby="nameHelp"
                        name="name"/>
                <small id="nameError"
                       class="invalid-feedback bg-danger rounded">Name length must be between 2 and 10 characters</small>
            </div>

<div class="form-group">
                <label for="town">Town</label>
                <input th:field="*{town}"
                       type="text" class="form-control text-center" id="town" aria-describedby="town"
                       name="town"/>
                <small id="townError"
                       class="invalid-feedback bg-danger rounded">Town length must be between 2 and 10 characters</small>
            </div>

<div class="form-group">
                <label for="description">Description</label>
                <input th:field="*{description}"
                       th:errorclass="is-invalid"
                       type="text" class="form-control text-center"
                       id="description" aria-describedby="description" name="description"/>
                <small id="descriptionError"
                       class="invalid-feedback bg-danger rounded">Description should be minimum 10 characters</small>
            </div>

<div class="form-group">
                <label for="budget">Budget</label>
                <input th:field="*{budget}"
                       type="number" min="0" class="form-control text-center"
                       id="budget" aria-describedby="town" name="town"/>
                <small id="budgetError"
                       class="invalid-feedback bg-danger rounded">Budget should be positive number</small>
            </div>

<button type="submit" class="btn btn-secondary">Add Company</button>
        </form>
    </main>
</div>

Navbar

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <title>Title</title>
</head>
<body>

<header th:fragment="navbar">
    <nav class="navbar navbar-expand-lg navbar-toggler bg-dark">
        <button class="navbar-toggler" type="button" data-toggle="collapse" data-target="#navbarNavAltMarkup"
                aria-controls="navbarNavAltMarkup" aria-expanded="false" aria-label="Toggle navigation">
            <span class="navbar-toggler-icon"></span>
        </button>
        <div class="collapse navbar-collapse float-right" id="navbarNavAltMarkup">
            <div class="navbar-nav">
                <a class="nav-item nav-link text-white" href="/companies/add">Add Company</a>
                <a class="nav-item nav-link text-white" href="/employees/add">Add Employee</a>
                <a class="nav-item nav-link text-white" href="/companies/all">All Companies</a>
                <a class="nav-item nav-link text-white" href="/employees/all">All Employees</a>
            </div>
        </div>
    </nav>
</header>

</body>
</html>

Petra Petrova

Greenhorn

Posts: 14

I like...

posted 1 year ago

Number of slices to send:

Optional 'thank-you' note:

Send

I made some progress and found some mistakes.
However now, when I put all correct details and click on Add, I still get error message for descriptio

Untitled2.png

Tim Holloway

Saloon Keeper

Posts: 26526

187

I like...

posted 1 year ago

Number of slices to send:

Optional 'thank-you' note:

Send

Note to Tim Moores: There's no JSF I can see here. It's all ThymeLeaf, which is, I understand, a Spring alternative to JSF.

It's not that JSF cannot play nicely with most other web frameworks, but the two systems do approach things differently. For one thing, you don't code your own servlets in JSF; the FacesServlet is the Master Controller for that MVC platform.

I'm going to be a "small government" candidate. I'll be the government. Just me. No one else.

Paul Clapham

Sheriff

Posts: 27525

I like...

posted 1 year ago

2
Number of slices to send:

Optional 'thank-you' note:

Send

I'm no Spring expert, but should you be using the @Min annotation to control the length of a String? Elsewhere you use the @Size annotation, apparently successfully.

Java 8 (verified skill)
Skill verified by Paul Clapham

Rob Spoor

Sheriff

Posts: 22715

129

I like...

posted 1 year ago

Number of slices to send:

Optional 'thank-you' note:

Send

Paul is right, @Min is only for numbers. Perhaps the invalid numeric string is seen as 0 which is clearly less than 10.

SCJP 1.4 - SCJP 6 - SCWCD 5 - OCEEJBD 6 - OCEJPAD 6
How To Ask Questions How To Answer Questions

Don't get me started about those stupid light bulbs.