Animation doesn't work on a button click in Android app

[Pete Alas]

Hello,

I am new to Android and trying to improve my learning. I am programming an Android app that shows animation of the images stored in image array list. The animation works fine when the activity is fired (on Create). In my app, there is a button with on click listener. I also want to run the animation when this button is clicked. However, when I click the button, the animation disappears. I am unable to understand why and logcat doesn't give any useful hints for me to try to debug.

Is it possible to run the same animation on button click? If yes, is there someone who could help me to fix this issue?

Here is my app code.

Main Activity.java

public class MainActivity extends AppCompatActivity {

    ArrayList<String> myImages = new ArrayList<>();
    ViewPager viewPager;
    private Button MyButtonSwitch;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        viewPager = findViewById(R.id.my_img_gallery);

        animateImages();

        MyButtonSwitch = findViewById(R.id.ButtonSwitch);

        MyButtonSwitch.setOnClickListener(new View.OnClickListener() {
            public void onClick(View v) {

                animateImages();
                
            }
        });

    }

    private void animateImages() {

        AccelerateInterpolator adi = new AccelerateInterpolator();
        try {
            Field mScroller = ViewPager.class.getDeclaredField("mScroller");
            mScroller.setAccessible(true);
            mScroller.set(viewPager, new MyScroller(getApplicationContext(), adi, 1));
        }
        catch (NoSuchFieldException e) {
            e.printStackTrace();
        }
        catch (IllegalAccessException e) {
            e.printStackTrace();
        }

        if (viewPager != null) {
            viewPager.setAdapter(new MyPageAdapter(getApplicationContext(), myImages));
        }

        final Handler handler = new Handler();
        final Runnable Update = new Runnable() {
            public void run() {
                if (currentPage == myImages.size() - 1) {
                    currentPage = 0;
                }
                viewPager.setCurrentItem(currentPage++, true);
            }
        };

        timer = new Timer();
        timer.schedule(new TimerTask() {
            @Override
            public void run() {
                handler.post(Update);
            }
            // delay and period can be initialized as desired
        }, delay, period);
    }

}

Activity_main.XML

 <?xml version="1.0" encoding="utf-8"?>
    <androidx.drawerlayout.widget.DrawerLayout xmlns:android="http://schemas.android.com/apk/res/android"
        xmlns:app="http://schemas.android.com/apk/res-auto"
        xmlns:tools="http://schemas.android.com/tools"
        android:layout_width="match_parent"
        android:layout_height="match_parent">
    
        <RelativeLayout
            android:orientation="vertical"
            android:layout_width="match_parent"
            android:layout_height="match_parent">
    
            <Button
                android:id="@+id/ButtonSwitch"
                android:padding="2dp"
                android:layout_width="50dp"
                android:layout_height="wrap_content"
                android:layout_alignParentStart="true"
                android:layout_marginStart="10dp"
                android:layout_marginTop="50dp"
                android:text="Test button"
                android:textAlignment="center"
                android:textColor="@color/colorWhite"
                android:textSize="12sp" />
    
            <androidx.viewpager.widget.ViewPager
                android:layout_marginTop="100dp"
                android:id="@+id/my_img_gallery"
                android:layout_width="match_parent"
                android:layout_height="500dp"/>
    
        </RelativeLayout>
    
    </androidx.drawerlayout.widget.DrawerLayout>

MyScroller.java class

 public class MyScroller extends Scroller {
    
        private int mDuration;
    
        public CustomScroller(Context context, Interpolator interpolator, int duration) {
            super(context, interpolator);
            mDuration = duration;
        }
    
        @Override
        public void startScroll(int startX, int startY, int dx, int dy, int duration) {
            // Ignore received duration, use fixed one instead
            super.startScroll(startX, startY, dx, dy, mDuration);
        }
    }

MyPageAdapter.java class:

    public class MyPageAdapter extends PagerAdapter {
    
        Context mContext;
        LayoutInflater mLayoutInflater;
        ArrayList<String> mResources;
    
        public MyPageAdapter(Context context, ArrayList<String> resources) {
            mContext = context;
            mResources = resources;
            mLayoutInflater = (LayoutInflater) mContext.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        }
    
        @Override
        public int getCount() {
            return mResources.size();
        }
    
        @Override
        public boolean isViewFromObject(View view, Object object) {
            return view == object;
        }
    
        @Override
        public Object instantiateItem(ViewGroup container, int position) {
    
            View itemView = mLayoutInflater.inflate(R.layout.my_page_item, container, false);
            final ImageView ivImage = (ImageView) itemView.findViewById(R.id.iv_image);
    
            if (!mResources.get(position).equals("")) {
                Glide.with(mContext)
                        .load(mResources.get(position).trim())
                        .into(ivImage);
            }
    
            container.addView(itemView);
    
            return itemView;
        }
    
        @Override
        public void destroyItem(ViewGroup container, int position, Object object) {
            container.removeView((LinearLayout) object);
        }
    }

and My_page_item.XML

<?xml version="1.0" encoding="utf-8"?>
    
    <LinearLayout
    
        xmlns:android="http://schemas.android.com/apk/res/android"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:orientation="vertical">
    
    <ImageView
        android:id="@+id/iv_image"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        />
    
    </LinearLayout>

and here is some log via "logcat" when I click the button and the animation disappears.

com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [14], object = [android.widget.LinearLayout{f09e704 V.E...... ........ 14742,14-15794,1361}]
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [15], object = [android.widget.LinearLayout{cb2c4ed V.E...... ........ 15794,14-16846,1361}]
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [16], object = [android.widget.LinearLayout{c6c3f22 V.E...... ........ 16846,14-17898,1361}]
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [17], object = [android.widget.LinearLayout{b9f6db3 V.E...... ........ 17898,14-18950,1361}]
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [18], object = [android.widget.LinearLayout{1c06f70 V.E...... ......ID 18950,14-20002,1361}] 

[Norm Radder]

Some debugging ideas:
Comment out the call to animateImages in the onCreate and only call it in the listener.  To test if there is some state that only allows the animation to run once.
Add some print statements to show where the code is executing and what the values of variables are as they change and are used.

[Pete Alas]

Thanks for the suggestion!

I did as you suggested. That is, commented out "animate images" method in OnCreate. The animation now runs on button click but only once, meaning when I click on the button again (and again...), the animation disappears. Thus, you were right! Indeed, there maybe some state that allows animation to run only once. I failed to understand why this is happening?

This is what happened in the logcat when I click on the button the first time (animation runs in this case):

com.example.animationtest I/TetheringManager: registerTetheringEventCallback:com.example.animationtest
com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{8037e43 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [0]
com.example.animationtest D/ImageViewPage: load in gallery:image1.png#end
com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{8037e43 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [1]
com.example.animationtest D/ImageViewPage: load in gallery:image2.png#end
com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{8037e43 VFED..... ......I. 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [2]
com.example.animationtest D/ImageViewPage: load in gallery:image3.png#end
com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{8037e43 VFED..... ......I. 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [3]
com.example.animationtest D/ImageViewPage: load in gallery:image4.png#end
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{8037e43 VFED..... ......I. 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [0], object = [android.widget.LinearLayout{1b429dc V.E...... ........ 14,14-1066,1361}]

and when I click again on the button, the animation disappears, these lines appear:

com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{8037e43 VFED..... ......I. 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [26], object = [android.widget.LinearLayout{8bf4194 V.E...... ........ 27366,14-28418,1361}]
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{8037e43 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [27], object = [android.widget.LinearLayout{be2343d V.E...... ........ 28418,14-29470,1361}]
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{8037e43 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [28], object = [android.widget.LinearLayout{f690432 V.E...... ........ 29470,14-30522,1361}]
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{8037e43 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [29], object = [android.widget.LinearLayout{faa3583 V.E...... ........ 30522,14-31574,1361}]
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{8037e43 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [30], object = [android.widget.LinearLayout{e18e300 V.E...... ......ID 31574,14-32626,1361}]

[Norm Radder]

One field that keeps its value is viewPager on line 42.  Try removing the test for null so it always gets a new instance.

[Pete Alas]

I tried. I changed

if (viewPager != null) {
   viewPager.setAdapter(new MyPageAdapter(getApplicationContext(), myImages));
}

to

 viewPager.setAdapter(new MyPageAdapter(getApplicationContext(), myImages));

Unfortunately, it didn't help and I got the same behavior that, the animation runs only once, either in OnCreate or via ButtonClick.

[Norm Radder]

Does the ViewPager class have any memory of what has been viewed?

Sorry, I misread line 42.  It was only a safety test.  line 11 is where viewPager gets its value.  What about resetting the currentItem to 0?

[Pete Alas]

No worries

Sorry, but I don't understand which line 11 you meant? In MainActivity.java, line 11, there is no currentItem Perhaps, you meant line 51? If I reset currentPage = 0 here, the animation freezes on the first image and doesn't move forward.

Apologies if I misunderstood you.

[Norm Radder]

Line 11 is where viewPager is assigned a value:

      viewPager = findViewById(R.id.my_img_gallery);

What about setting current Item to 0?  Something like this:

   viewPager.setCurrentItem(0, true);

If I reset currentPage = 0 here, the animation freezes on the first image

That sounds like progress.  Before  the animation disappeared

[Pete Alas]

Thanks for the clarification. I tried:

viewPager.setCurrentItem(0, true);

The animation that was running in onCreate is now stopped/freezed at image 1. Additionally, the animation still disappears on button click so no progress here.

[Norm Radder]

Where are you setting the value to 0?  If it gets reset for each image, only the first image will ever be shown.

Where is currentPage declared?
Lines 49-50 wrap its value around to 0 when it gets to the end.    Does that work?  Does the animation wrap around at the end?  Ie does it go forever?

[Pete Alas]

I am changing these lines of code from

public void run() {
                if (currentPage == myImages.size() - 1) {
                    currentPage = 0;
                }
                viewPager.setCurrentItem(currentPage++, true);
            }

to

public void run() {
                if (currentPage == myImages.size() - 1) {
                    currentPage = 0;
                }
                viewPager.setCurrentItem(0, true);
            }

Lines 48 - 53 in MainActivity.java. Am I doing something wrong?

[Norm Radder]

Am I doing something wrong?

Yes, the code is always only showing the first image.  

Did the original code run continuously, wrapping around at the end of the list of images back to the first image?

[Pete Alas]

Yes, the original code runs the animation continuously. It starts from the first image, goes to the last, and starts from the first image again. Thus, it animates in a continuous loop.

The problem, as we discovered is, it runs only once. If I call the method twice, only the first method call would run the continuous animation, let it be in OnCreate or via button click.

[Norm Radder]

Add print statements to all the methods that are called so you can see that they are all called as expected.  
Compare what is printed for when it works and what is printed when it fails.

The posted print outs show that destroyItem is called at end of good test and then is called continually in failed test.
When and why is destroyItem called?

[Pete Alas]

Compare what is printed for when it works and what is printed when it fails.

The funny (and annoying) thing is I only see,

intantiateItem()

,

 Image View: load in gallery("image.png")

and

destroyItem()

in the stack trace log when animation works and only destroyItem() when things don't work. I already put this in the thread as one of your answers.

When and why is destroyItem called?

Please look at MyScroller.java and MyPageAdapter.java. Especially, in MyPageAdapter.java, there are

instantiateItem()

,

Image View's itemView 

("load in gallery" is just a log message here) and

 destroyItem()

are the main components running the animation. I tried commenting destroyItem(), the app crashes and won't start.

Scroller and PageAdapter set up the animation and above three components run it.

Hope it makes sense?

[Norm Radder]

Why is destroyItem called?  Can you control when it is called?  Maybe if it is not called it will work differently.

[Pete Alas]

destroyItem() is called to remove/unload the object (here, the image object). It's like loading and unloading to the next scroll until the animation reaches to the last image.

If look at the method:

public void destroyItem(ViewGroup container, int position, Object object){
container.removeView((LinearLayout) object);
}

It removes the object from the LinearLayout (container) at a certain position (image 1, 2, 3 and so on..).

Can you control when it is called?

How do I do that?

As I said, I have tried commenting destroyItem() method in MyPageAdapter.java class, and ran the app again, the app crashes and won't start.

[Norm Radder]

Feed this to Google:  destroyitem viewpager android
and read through all the discussions for some ideas.


Was the first call to destroyItem in response to a user's action after the animation had run for a while?

[Pete Alas]

Was the first call to destroyItem in response to a user's action after the animation had run for a while?

No. It is mainly to unload image so that the next image can be loaded and ViewPager scrolls to the next page (image).

Please consider looking at MyScroller and PagerAdapter classes.

[Norm Radder]

One of your posts of the logcat shows several calls to instantiateItem() followed by one call to destroyItem().
Then the next posting of the logcat shows only calls to destroyItem()

It is hard to guess what was happening on the device with only those small sections of the logcat posted here

Can you run the code again and allow the animation to wrap around at least once and then somehow show a  call  to destroyItem().
Copy that contents of the logcat and paste it here.  


What causes destroyItem() to be called?

[Pete Alas]

It is hard to guess what was happening on the device with only those small sections of the logcat posted here

The code loads and unloads images, during this, instantiateItem() and destroyItem() are called.

What causes destroyItem() to be called?

The button click. When I put the animation method under onClick Listener then only destroyItem() is called and showed n logcat.

Running the code again would show the same behaviour as explained in the above.

[Norm Radder]

I am unable to do any testing to see what happens.  I am relying on you to do all the testing.  Just talking about the problem is no help.

Can you run the code again and allow the animation to wrap around at least once and then somehow show a  call  to destroyItem().
Copy that contents of the logcat and paste it here.  

[Pete Alas]

I agree, just talking will not solve the problem. Here is the log (full iteration) when I load first five images.

com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [0]
com.example.animationtest D/ImageViewPage: load in gallery:img_1.png#end
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [3], object = [android.widget.LinearLayout{b7ba120 V.E...... ........ 3170,14-4222,1361}]
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [4], object = [android.widget.LinearLayout{d7b8ad9 V.E...... ........ 4222,14-5274,1361}]
com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [3]
com.example.animationtest D/ImageViewPage: load in gallery:img_4.png#end
com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [4]
com.example.animationtest D/ImageViewPage: load in gallery:img_5.png#end
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [0], object = [android.widget.LinearLayout{8a0b4aa V.E...... ........ 14,14-1066,1361}]
com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [0]
com.example.animationtest D/ImageViewPage: load in gallery:img_1.png#end
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [3], object = [android.widget.LinearLayout{c52bc11 V.E...... ........ 3170,14-4222,1361}]
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [4], object = [android.widget.LinearLayout{aad7176 V.E...... ........ 4222,14-5274,1361}]
com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [3]
com.example.animationtest D/ImageViewPage: load in gallery:img_4.png#end
com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [4]

com.example.animationtest D/ImageViewPage: load in gallery:img_5.png#end

I noticed that, when the animation starts, images 2 and 3 are skipped and not shown at all!! When I animated for 15 images, the animation in the first loop, starts from image 4, and when it restarts again (full loop), then it starts from image 1.

I am unable to understand why ?

[Norm Radder]

I am unable to understand why ?

Have you added print statements to the code so you can see when the various methods are called and what the values of the variables are?
For example add this in the run method:

   System.out.println("run cP=" + currentPage);  

The output will be shown in the logcat.

Why doesn't the contents of the logcat have the date/time.  Here is a copy of one of my logcat dumps:

09-20 19:53:05.083: I/System.out(8046): >>>>>>>>>> Started at Fri Sep 20 19:53:05 GMT 2013
09-20 19:53:05.147: I/System.out(8046): screen size=Point(1024, 552), inches=7.281629740932256
09-20 19:53:05.155: I/System.out(8046):  xdpi=159.5681, ydpi=160.42105  wPix=1024, hPix=552,  test48dp=48, dp=48, density=1.0
09-20 19:53:05.219: I/System.out(8046): cf to sk dist=20.003796, bearing=-152.31781, miles2=6466.4526  [1.0406721E7, 37.526474, 142.32643]
09-20 19:53:06.959: I/System.out(8046): onCreateOptionsMenu
09-20 19:53:06.975: I/System.out(8046): onPrepareOptionsMenu
09-20 19:53:07.135: D/gralloc_vbox86(8046): Emulator without GPU emulation detected.
09-20 19:53:07.519: I/Choreographer(8046): Skipped 45 frames!  The application may be doing too much work on its main thread.
09-20 19:53:17.851: I/System.out(8046): onPrepareOptionsMenu
09-20 19:53:22.463: I/System.out(8046): onOptionsItemSelected item=Show Fragment menu
09-20 19:53:22.723: I/System.out(8046): MDF onCreate() passed=passed string
09-20 19:53:24.347: I/System.out(8046): onItemSelected arg1=android.widget.TextView{a6645b10 V.ED.... ......ID 4,10-60,32 #1020014 android:id/text1}, pos=0, is=0
09-20 19:53:35.575: I/System.out(8046): onItemSelected arg1=android.widget.TextView{a6652f18 V.ED.... ......I. 4,10-60,32 #1020014 android:id/text1}, pos=4, is=4
09-20 19:53:40.875: I/System.out(8046): setChoice s=item4
09-20 19:53:50.163: I/Choreographer(8046): Skipped 48 frames!  The application may be doing too much work on its main thread.
09-20 19:53:53.819: I/System.out(8046): <<<<<<<<<<<<< Stopped at Fri Sep 20 19:53:53 GMT 2013

[Pete Alas]

Here is the logcat output after putting print statement in the run() method.

com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [0]
com.example.animationtest D/ImageViewPage: load in gallery:img__1.png#end
com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [1]
com.example.animationtest D/ImageViewPage: load in gallery:img__2.png#end
com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [2]
com.example.animationtest D/ImageViewPage: load in gallery:img__3.png#end
com.example.animationtest I/System.out: run cP=1
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [7], object = [android.widget.LinearLayout{2332426 V.E...... ........ 7378,14-8430,1361}]
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [8], object = [android.widget.LinearLayout{2e2867 V.E...... ........ 8430,14-9482,1361}]
com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [9], object = [android.widget.LinearLayout{aa0c614 V.E...... ........ 9482,14-10534,1361}]
com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [3]
com.example.animationtest D/ImageViewPage: load in gallery:img__4.png#end
com.example.animationtest I/System.out: run cP=2
com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [4]
/com.example.animationtest D/ImageViewPage: load in gallery:img__5.png#end
/com.example.animationtest I/System.out: run cP=3
6728-6728/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [0], object = [android.widget.LinearLayout{c4369b9 V.E...... ........ 14,14-1066,1361}]
6728-6728/com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [5]
6728-6728/com.example.animationtest D/ImageViewPage: load in gallery:img__6.png#end
6728-6728/com.example.animationtest I/System.out: run cP=4
6728-6728/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [1], object = [android.widget.LinearLayout{3a6c3ac V.E...... ........ 1066,14-2118,1361}]
6728-6728/com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [6]
6728-6728/com.example.animationtest D/ImageViewPage: load in gallery:img__7.png#end
6728-6728/com.example.animationtest I/System.out: run cP=5
6728-6728/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [2], object = [android.widget.LinearLayout{e9ad07b V.E...... ........ 2118,14-3170,1361}]
 6728-6728/com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [7]
6728-6728/com.example.animationtest D/ImageViewPage: load in gallery:img__8.png#end
 6728-6728/com.example.animationtest I/System.out: run cP=6
 6728-6728/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [3], object = [android.widget.LinearLayout{7a2e2d6 V.E...... ........ 3170,14-4222,1361}]
6728-6728/com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [8]
6728-6728/com.example.animationtest D/ImageViewPage: load in gallery:img__9.png#end
6728-6728/com.example.animationtest I/System.out: run cP=7
6728-6728/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [4], object = [android.widget.LinearLayout{e41b12d V.E...... ........ 4222,14-5274,1361}]
 6728-6728/com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [9]
6728-6728/com.example.animationtest D/ImageViewPage: load in gallery:img__10.png#end
6728-6728/com.example.animationtest I/System.out: run cP=8
 6728-6728/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [5], object = [android.widget.LinearLayout{c8c78b0 V.E...... ........ 5274,14-6326,1361}]
 6728-6728/com.example.animationtest I/System.out: run cP=9
 6728-6728/com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [0]
 6728-6728/com.example.animationtest D/ImageViewPage: load in gallery:img__1.png#end
6728-6728/com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [1]
 6728-6728/com.example.animationtest D/ImageViewPage: load in gallery:img__2.png#end
5 6728-6728/com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [2]
6728-6728/com.example.animationtest D/ImageViewPage: load in gallery:img__3.png#end
 6728-6728/com.example.animationtest I/System.out: run cP=1
5 6728-6728/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [6], object = [android.widget.LinearLayout{4fcce6b V.E...... ........ 6326,14-7378,1361}]
 6728-6728/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [7], object = [android.widget.LinearLayout{84aadc8 V.E...... ........ 7378,14-8430,1361}]
 6728-6728/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [8], object = [android.widget.LinearLayout{96f1e61 V.E...... ........ 8430,14-9482,1361}]
 6728-6728/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [9], object = [android.widget.LinearLayout{f97ad86 V.E...... ........ 9482,14-10534,1361}]
6728-6728/com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [3]
5 6728-6728/com.example.animationtest D/ImageViewPage: load in gallery:img__4.png#end
 6728-6728/com.example.animationtest I/System.out: run cP=2
 6728-6728/com.example.animationtest D/ImageViewPage: instantiateItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [4]

I remove the datatime to make log more readable (no long lines), I guess it's not that relevant for the code debugging. Is it?

[Norm Radder]

Interesting that the printed cp=  value does not correlate with the position = [0] value???
Also the cP= value is never 0?

Where in that test run was the button pressed?  I do not see any print outs showing when the onClick method was called?
Where is the solid list of calls to destroyItem that was shown in an earlier post?

[Pete Alas]

I made some progress!

In the beginning of this method:

private void animateImages() {
 
        AccelerateInterpolator adi = new AccelerateInterpolator();
        try {
            Field mScroller = ViewPager.class.getDeclaredField("mScroller");
            mScroller.setAccessible(true);
            mScroller.set(viewPager, new MyScroller(getApplicationContext(), adi, 1));
        }
        catch (NoSuchFieldException e) {
            e.printStackTrace();
        }
        catch (IllegalAccessException e) {
            e.printStackTrace();
        }
 
        if (viewPager != null) {
            viewPager.setAdapter(new MyPageAdapter(getApplicationContext(), myImages));
        }
 
        final Handler handler = new Handler();
        final Runnable Update = new Runnable() {
            public void run() {
                if (currentPage == myImages.size() - 1) {
                    currentPage = 0;
                }
                viewPager.setCurrentItem(currentPage++, true);
            }
        };
 
        timer = new Timer();
        timer.schedule(new TimerTask() {
            @Override
            public void run() {
                handler.post(Update);
            }
            // delay and period can be initialized as desired
        }, delay, period);
    }

I load the images like this:

images.clear();
while (i < 5) {
images.add("my_image_url" + i + ".png");
i ++;
}

When this method is called in OnCreate(), all seems to be working ok. But, when called, inside button click listener. Then this happens:

:22.954 14974-14974/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......I. 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [5], object = [android.widget.LinearLayout{fc92a5b V.E...... ........ 5274,14-6326,1361}]
:23.121 14974-14974/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ........ 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [6], object = [android.widget.LinearLayout{46f33d1 V.E...... ........ 6326,14-7378,1361}]
:23.123 14974-14974/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [7], object = [android.widget.LinearLayout{9c8ee36 V.E...... ........ 7378,14-8430,1361}]
:23.124 14974-14974/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [8], object = [android.widget.LinearLayout{6e61137 V.E...... ........ 8430,14-9482,1361}]
:23.124 14974-14974/com.example.animationtest D/ImageViewPage: destroyItem() called with: container = [androidx.viewpager.widget.ViewPager{3a59ea7 VFED..... ......ID 0,275-1080,1650 #7f080138 app:id/my_img_gallery}], position = [9], object = [android.widget.LinearLayout{be46a4 V.E...... ........ 9482,14-10534,1361}]
:23.954 14974-14974/com.example.animationtest I/System.out: The page number is=9
:23.954 14974-14974/com.example.animationtest I/System.out: The myImages size is=0
:24.128 14974-14974/com.example.animationtest I/System.out: The page number is=10
:24.128 14974-14974/com.example.animationtest I/System.out: The myImages size is=0
:24.956 14974-14974/com.example.animationtest I/System.out: The page number is=11
:24.956 14974-14974/com.example.animationtest I/System.out: The myImages size is=0
:25.129 14974-14974/com.example.animationtest I/System.out: The page number is=12
:25.129 14974-14974/com.example.animationtest I/System.out: The myImages size is=0
:25.958 14974-14974/com.example.animationtest I/System.out: The page number is=13
:25.958 14974-14974/com.example.animationtest I/System.out: The myImages size is=0
:26.130 14974-14974/com.example.animationtest I/System.out: The page number is=14
:26.130 14974-14974/com.example.animationtest I/System.out: The myImages size is=0

It means, "myImages size" becomes zero and an infinite while loop is initiated because of this:

                if (currentPage == myImages.size() - 1) {
                    currentPage = 0;
                }

I moved URL loading in OnCreate() and now animation works also on Button click !! (Yuhu !) But there is a bump in animation, which means, image 1 and 2 move too quickly and then bump, and then 3,4 and so on...

I can't figure out why this is happening!

[Norm Radder]

Where are the print statements that print out to the logcat.  I do not see any in the code.

[Pete Alas]

Can you the bottom of the logcat where myImages size and page number is mentioned? That is, print statement.

Do you some suggestions regarding code tweaking apart from questions?

[Norm Radder]

Sorry, I can not understand what the code is doing when looking at the logcat output, since the output is not from the posted code.

Where is the code that adds anything to myImages?  I do not see any add statements for myImages.

[Pete Alas]

Where is the code that adds anything to myImages?  I do not see any add statements for myImages

It's  here.

myimages.clear();
while (i < 5) {
myimages.add("my_image_url" + i + ".png");
i ++;
}

The reason behind posting the code was, that folks can also reproduce the issue at their side. Did you try?

[Norm Radder]

Did you try?

No, it is a big job to set up Android testing.  Often OPs don't post all the code and a lot of time is wasted getting the code in synch.

For example the posted code does not have the snippet of code that you just posted that shows the call to the add method.

And there isn't any code posted with the print statements that you have shown the output from in the logcat.

[Pete Alas]

Seems like we are heading towards the dead-end Questioning and answering certainly doesn't solve the problem.

I did as you suggested, have been answering your questions. But, if things are still unclear then my bad.

[Norm Radder]

I did as you suggested

There is some misunderstanding about what I suggested.  For example I suggested that you add print statements to all the methods to show where the code executed and what the contents of the variable were as the code executed.  Look at the logcat extract I posted.  There are lots of print statements that show what methods were being executed and what was in some of the variables.  
Your logcats don't show as much.
Then there was a mismatch between the logcat contents that were posted and the code that was supposed to go with that logcat did not have any print statements.