C++ Palindrome Number

[Shivam Bhatele]

Hello All, I am new to C++ programming and I'm trying to write a C++ program to find if a number is a palindrome. The problem is that the program returns false even when the number is a palindrome. Can anyone know where I can practice for palindrome problems?

[John Matthews]

Hi

If you're new to C++ it might just be a problem with the C++ rather than the palindrome side of the code. Have you tried adding output statements at various places to show you what the code is (or isn't) doing?

[Shivam Bhatele]

Here is my code

#include <cstdlib> #include <iostream> #include <string> bool is_palindrome(int n){  std::string num = std::to_string(n);  int len = num.length();  bool check = false;  for(int i=0; i < len/2; i++){    if(num[i] == num[len-i])    check = true;  }  return check; } int main(){   int num = 23232;   std::cout<< is_palindrome(num) << std::endl;   return 0; }

[John Matthews]

So I would add some output inside the loop, to output the values of i, i-1, the digits being compared, and the current value of check.

[John Matthews]

Sorry I meant len-i, not i-1. And len (before the loop).

[Shivam Bhatele]

Still getting error

[John Matthews]

Printing some output isn't going to fix the problem, but it will show you what/where it is going wrong.

Can you show the output you are getting after adding the output statement(s) inside the loop?

[Campbell Ritchie]

Welcome to the Ranch

The code in lines 10‑11 looks incorrect to me.

[John Matthews]

I think the approach is not the best/easiest - it's easier to assume the number is a palindrome, then look for a reason why it isn't.

But I'm hoping a bit of debugging will demonstrate that.