Question about handling struts afterwhile upgrading

[Jack Tauson]

Since I've upgraded from Spring 5.x to 6.X, the jakarta ee is causing the following strits 1.x related things to break in struts Action class.

no suitable method found for saveErrors(jakarta.servlet.http.HttpServletRequest,org.apache.struts.action.ActionMessages)
    method org.apache.struts.action.Action.saveErrors(javax.servlet.http.HttpServletRequest,org.apache.struts.action.ActionMessages) is not applicable
      (argument mismatch; jakarta.servlet.http.HttpServletRequest cannot be converted to javax.servlet.http.HttpServletRequest)

For example if I'm using it like this in my code, it keeps on throwing above error:

public ActionForward pdf(ActionMapping mapping, ActionForm form, HttpServletRequest request,
			HttpServletResponse response) throws Exception {

		String id = request.getParameter("id");
		String type = request.getParameter("type");
		ActionMessages errors = new ActionMessages();

		if (Utils.nullOrBlank(id)) {
			// nothing to view
			errors.add(ActionMessages.GLOBAL_MESSAGE, new ActionMessage("record.noId"));
			saveErrors(request, errors);
			return mapping.findForward("home");
		}

Is there a way I could upgrade Struts 1.x to get the above issue fixed?

[Stephan van Hulst]

I can't endorse it as i haven't tried it, but you could take a look at the the following project: https://github.com/weblegacy/struts1

But maybe consider migrating your project to Struts2 or Spring MVC or Jakarta MVC.

[Tim Holloway]

Stephan van Hulst wrote:But maybe consider migrating your project to Struts2 or Spring MVC or Jakarta MVC.

Or JavaServer Faces.

Yes, I know everyone loves to put it down, but it's a web MVC framework that's actually part of the JEE standard, and thus is built in to the full-stack JEE webapp servers, and easy to work with even with the minimal servers like Tomcat. And Spring Boot, for that matter.

JSF was designed by people who wanted a POJO-based MVC system, having had a bellyful of all the kinks that Struts required (special Struts-only base classes and interfaces). Some of those designers had originally designed Struts. Being POJO-based means almost by definition that application components are insulated from changes in the framework itself, in addition to the potential for code re-use and the relative ease that you can unit-test them (no mock infrastructure needed).

Additionally, it gets good support on the CodeRanch.

[Jack Tauson]

Stephan van Hulst wrote:I can't endorse it as i haven't tried it, but you could take a look at the the following project: https://github.com/weblegacy/struts1

Thanks. I encountered that link as well and couldn't find any maven URL and hence wondering how would I go about using 1.5.0 Release Candidate 2 ( as that's the latest one) as  all I'm seeing is what changes are done etc in the ReadMe.

[Ron McLeod]

Jack Tauson wrote:Thanks. I encountered that link as well and couldn't find any maven URL and hence wondering how would I go about using 1.5.0 Release Candidate 2 ( as that's the latest one) as  all I'm seeing is what changes are done etc in the ReadMe.

Is this what you are looking for?: io.github.weblegacy::struts-parent::1.5.0-RC2

[Jack Tauson]

Ron McLeod wrote:Is this what you are looking for?: io.github.weblegacy::struts-parent::1.5.0-RC2

I think so but it doesn't talk about jakarta in the description on the maven repository. That looks similar to what that github link related release(https://github.com/weblegacy/struts1/releases/tag/v1.5.0_rc2) look like. I can try to test it.  Did you end up on the maven repository from the same github link (https://github.com/weblegacy/struts1)somehow ? Thanks!

[Ron McLeod]

Jack Tauson wrote:Did you end up on the maven repository from the same github link (https://github.com/weblegacy/struts1)somehow ? Thanks!

I just used Google to search for: maven repository weblegacy struts1

[Jack Tauson]

Ron McLeod wrote:

Jack Tauson wrote:Did you end up on the maven repository from the same github link (https://github.com/weblegacy/struts1)somehow ? Thanks!

I just used Google to search for: maven repository weblegacy struts1

Thanks. Unfortunately, after adding the following dependency from above URL,

<!-- https://mvnrepository.com/artifact/io.github.weblegacy/struts-parent -->
<dependency>
    <groupId>io.github.weblegacy</groupId>
    <artifactId>struts-parent</artifactId>
    <version>1.5.0-RC2</version>
    <type>pom</type>
</dependency>

I haven't seen any change in the error I mentioned in my original post on this thread. Any idea if I need to get rid of my existing struts dependencies and just use the above one? right now I just added above dependency in addition to what already exists. It's kind of not clear what the above dependency is doing.

[Stephan van Hulst]

Well, no. It doesn't make sense to add a dependency on the parent POM of the Struts project. You want a dependency on one or more of the modules inside the parent project.

Show us the original Apache Struts dependency that you're trying to replace.

[Jack Tauson]

Stephan van Hulst wrote:Well, no. It doesn't make sense to add a dependency on the parent POM of the Struts project. You want a dependency on one or more of the modules inside the parent project.

Show us the original Apache Struts dependency that you're trying to replace.

Sure, here is how it looks like. I've left some of the stuff in the dependencies below and removed some other things that were not very relevant.

Struts dependency starts at line #67 and line #104 is where I tried adding the one we are discussing.

<dependencies>
	<dependency>
		<groupId>org.springframework</groupId>
		<artifactId>spring-context</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework</groupId>
		<artifactId>spring-expression</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework</groupId>
		<artifactId>spring-beans</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework</groupId>
		<artifactId>spring-aop</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework</groupId>
		<artifactId>spring-context-support</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework</groupId>
		<artifactId>spring-tx</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework</groupId>
		<artifactId>spring-jdbc</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework</groupId>
		<artifactId>spring-orm</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework</groupId>
		<artifactId>spring-oxm</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework</groupId>
		<artifactId>spring-web</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework</groupId>
		<artifactId>spring-webmvc</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework</groupId>
		<artifactId>spring-test</artifactId>
		<scope>test</scope>
	</dependency>
	<dependency>
		<groupId>org.springframework.security</groupId>
		<artifactId>spring-security-web</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework.security</groupId>
		<artifactId>spring-security-config</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework.security</groupId>
		<artifactId>spring-security-core</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework.security</groupId>
		<artifactId>spring-security-taglibs</artifactId>
	</dependency>
	<dependency>
		<groupId>org.springframework</groupId>
		<artifactId>spring-struts</artifactId>
		<version>3.2.18.RELEASE</version>
		<exclusions>
			<exclusion>
				<groupId>struts</groupId>
				<artifactId>struts</artifactId>
			</exclusion>
		</exclusions>
	</dependency>
	<dependency>
		<groupId>jakarta.platform</groupId>
		<artifactId>jakarta.jakartaee-api</artifactId>
		<version>8.0.0</version>
		<scope>provided</scope>
	</dependency>
	<dependency>
		<groupId>org.apache.struts</groupId>
		<artifactId>struts-core</artifactId>
		<version>1.3.10</version>
	</dependency>
	<dependency>
		<groupId>org.apache.struts</groupId>
		<artifactId>struts-el</artifactId>
		<version>1.3.10</version>
	</dependency>
	<dependency>
		<groupId>org.apache.struts</groupId>
		<artifactId>struts-extras</artifactId>
		<version>1.3.10</version>
	</dependency>
	<dependency>
		<groupId>org.apache.struts</groupId>
		<artifactId>struts-taglib</artifactId>
		<version>1.3.10</version>
	</dependency>
	<!-- https://mvnrepository.com/artifact/io.github.weblegacy/struts-parent -->
	<dependency>
		<groupId>io.github.weblegacy</groupId>
		<artifactId>struts-parent</artifactId>
		<version>1.5.0-RC2</version>
		<type>pom</type>
	</dependency>
	<!-- <dependency><groupId>org.directwebremoting</groupId><artifactId>dwr</artifactId><version>3.0.2-RELEASE</version></dependency>-->
	<!-- https://mvnrepository.com/artifact/org.beangle.jakarta/beangle-jakarta-dwr -->
	<dependency>
		<groupId>org.beangle.jakarta</groupId>
		<artifactId>beangle-jakarta-dwr</artifactId>
		<version>3.0.3-RELEASE</version>
	</dependency>
	<dependency>
		<groupId>org.springmodules</groupId>
		<artifactId>spring-modules-validation</artifactId>
		<version>0.8</version>
		<exclusions>
			<exclusion>
				<groupId>org.springframework</groupId>
				<artifactId>spring</artifactId>
			</exclusion>
		</exclusions>
	</dependency>
	<dependency>
		<groupId>io.jsonwebtoken</groupId>
		<artifactId>jjwt</artifactId>
		<version>0.9.1</version>
	</dependency>
	<dependency>
		<groupId>javax.servlet</groupId>
		<artifactId>jstl</artifactId>
		<version>1.2</version>
	</dependency>
	<dependency>
		<groupId>jakarta.servlet</groupId>
		<artifactId>jakarta.servlet-api</artifactId>
		<version>6.0.0</version>
		<scope>provided</scope>
	</dependency>
</dependencies>

[Stephan van Hulst]

First, remove the dependency on struts-parent.

See all those dependencies with the group ID org.apache.struts?

Simply replace the group ID in all of them with io.github.weblegacy, and replace the version in all of them with 1.5.0-RC2.

[Jack Tauson]

Stephan van Hulst wrote:First, remove the dependency on struts-parent.

See all those dependencies with the group ID org.apache.struts?

Simply replace the group ID in all of them with io.github.weblegacy, and replace the version in all of them with 1.5.0-RC2.

Thanks. So I did that and it looks like the following now.

1. Please note that I didn't touch org.springframework on line 67 below. Hope that's fine.

2. Upon updating the maven dependencies, I'm getting error  package org.apache.struts.actions does not exist wherever import org.apache.struts.actions.DispatchAction; is used. Other imports like import org.apache.struts.action.ActionMessages; etc are not complaining.  And if I try to use import io.github.weblegacy.DispatchAction; as a fix for it, I get package io.github.weblegacy does not exist on this line. Any idea what might be wrong here?

3. Question on my original error -  May be I didn't mention but I deliberately changed javax imports to jakarta in the Struts action class which resulted in the error I mentioned in my original post. I am wondering if I should not mess javax imports which works fine with org.apache.struts and continue with my Spring upgrade process?

<dependencies>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-context</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-expression</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-beans</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-aop</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-context-support</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-tx</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-jdbc</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-orm</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-oxm</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-web</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-webmvc</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-test</artifactId>
        <scope>test</scope>
    </dependency>
    <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-web</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-config</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-core</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-taglibs</artifactId>
    </dependency>
    <dependency>
        <groupId>org.springframework</groupId>
        <artifactId>spring-struts</artifactId>
        <version>3.2.18.RELEASE</version>
        <exclusions>
            <exclusion>
                <groupId>struts</groupId>
                <artifactId>struts</artifactId>
            </exclusion>
        </exclusions>
    </dependency>
    <dependency>
        <groupId>jakarta.platform</groupId>
        <artifactId>jakarta.jakartaee-api</artifactId>
        <version>8.0.0</version>
        <scope>provided</scope>
    </dependency>
    <dependency>
        <groupId>io.github.weblegacy</groupId>
        <artifactId>struts-core</artifactId>
        <version>1.5.0-RC2</version>
    </dependency>
    <dependency>
        <groupId>io.github.weblegacy</groupId>
        <artifactId>struts-el</artifactId>
        <version>1.5.0-RC2</version>
    </dependency>
    <dependency>
        <groupId>io.github.weblegacy</groupId>
        <artifactId>struts-extras</artifactId>
        <version>1.5.0-RC2</version>
    </dependency>
    <dependency>
        <groupId>io.github.weblegacy</groupId>
        <artifactId>struts-taglib</artifactId>
        <version>1.5.0-RC2</version>
    </dependency>
   <!-- <dependency><groupId>org.directwebremoting</groupId><artifactId>dwr</artifactId><version>3.0.2-RELEASE</version></dependency>-->
    <!-- https://mvnrepository.com/artifact/org.beangle.jakarta/beangle-jakarta-dwr -->
    <dependency>
        <groupId>org.beangle.jakarta</groupId>
        <artifactId>beangle-jakarta-dwr</artifactId>
        <version>3.0.3-RELEASE</version>
    </dependency>
    <dependency>
        <groupId>org.springmodules</groupId>
        <artifactId>spring-modules-validation</artifactId>
        <version>0.8</version>
        <exclusions>
            <exclusion>
                <groupId>org.springframework</groupId>
                <artifactId>spring</artifactId>
            </exclusion>
        </exclusions>
    </dependency>
    <dependency>
        <groupId>io.jsonwebtoken</groupId>
        <artifactId>jjwt</artifactId>
        <version>0.9.1</version>
    </dependency>
    <dependency>
        <groupId>javax.servlet</groupId>
        <artifactId>jstl</artifactId>
        <version>1.2</version>
    </dependency>
    <dependency>
        <groupId>jakarta.servlet</groupId>
        <artifactId>jakarta.servlet-api</artifactId>
        <version>6.0.0</version>
        <scope>provided</scope>
    </dependency>
</dependencies>

[Stephan van Hulst]

Please show us an example of a (short) class that is not compiling.

[Jack Tauson]

Stephan van Hulst wrote:Please show us an example of a (short) class that is not compiling.

Please find one of the classes below ( irrelevant code has been removed for brevity):

package com.checking.web;


import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;

import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;
import org.apache.struts.action.ActionMessage;
import org.apache.struts.action.ActionMessages;
import org.apache.struts.actions.DispatchAction;



public class UploadAction extends DispatchAction {

    private final Log log = LogFactory.getLog(UploadAction.class);

    public ActionForward init(ActionMapping mapping, ActionForm form, HttpServletRequest request,
        HttpServletResponse response) throws Exception {

        //some code
        return mapping.findForward("init");
    }


    public ActionForward parseForm(ActionMapping mapping, ActionForm form, HttpServletRequest request,
        HttpServletResponse response) throws Exception {

        ActionMessages errors = new ActionMessages();

        saveErrors(request, errors);
        return mapping.findForward("edit");
    }


    public ActionForward upload(ActionMapping mapping, ActionForm form, HttpServletRequest request,
        HttpServletResponse response) throws Exception {

        ActionMessages errors = new ActionMessages();


        if (!errors.isEmpty()) {
            saveErrors(request, errors);
            return mapping.findForward("edit");
        }

        long globalStartTime = System.currentTimeMillis();
        errors.add(ActionMessages.GLOBAL_MESSAGE, new ActionMessage("upload.complete"));
        saveMessages(request, errors);
        return mapping.findForward("home");
    }

    public ActionForward unspecified(ActionMapping mapping, ActionForm form, HttpServletRequest request,
        HttpServletResponse response) throws Exception {
       return init(mapping, form, request, response);
    }

The errors I can see in eclipse are on the folowing lines:



Line #14 for import org.apache.struts.actions.DispatchAction;
Error Description from Eclipse:
The import org.apache.struts.actions cannot be resolved
Console says: package org.apache.struts.actions does not exist on the same line

Line #18 with red underline on DispatchAction for public class UploadAction extends DispatchAction {
Error Description from Eclipse:
DispatchAction cannot be resolved to a type
Console says: cannot find symbol

Line #35 and #47 saveErrors(request, errors);
Error Description from Eclipse:
The method saveErrors(HttpServletRequest, ActionMessages) is undefined for the type UploadAction

The error here is different than my original post error here for saveErrors.

Line #53 for saveMessages(request,errors);
Error Description from Eclipse:
The method saveMessages(HttpServletRequest, ActionMessages) is undefined for the type UploadAction


I wonder why other imports with org.apache.struts.action are working even though I got rid of org.apache.struts.action from the dependency and it's only complaining
for DispatchAction. Similarly, there's another class where it's complaining about import org.apache.struts.validator.ValidatorActionForm;