fetch and update issues loop not updating edge cases

[sai rama krishna]

Hi,

try {
     
     int offset=0;
     int limit=200;
     int jArray=limit;

do {
         JSONObject jsonRes = fetchIssues(restTemplate, st_url, sId, wsId, cookie,offset,limit);
         JSONArray jsonArray = jsonRes.getJSONArray("load");
         numberOfStoriesFetched =jsonArray.length();
         List<JSONObject> list = IntStream.range(0, jsonArray.length())
                 .mapToObj(new IntFunction<JSONObject>() {
                     @Override
                     public JSONObject apply(int index) {
                         JSONObject j = jsonArray.getJSONObject(index);
                         j.put("i_t_s_xyz", "issue");
                         return j;
                     }
                 }).collect(Collectors.toList());
         String updateIssueLoad = prepareUpdateIssueLoad(list.subList(0,limit));      
         response = updateIssues(restTemplate, s_url, updateIssueLoad, sId, wId, cookie);
         if (response != null && response.getStatusCode().is2xxSuccessful()) {
             createSuccessfullRow(response, sId, sName, wId, wName, listOfCustomStory);
         }
         offset=limit;
     } while(numberOfStoriesFetched <= limit );

I have code like above to fetch and then update the issues.

If I have 200 records it is fetching and updating fine.

If I have 390 records 190 records at the end not getting updated.
I am setting offset to limit (200) at end of loop

New offset increases from 0 to 200
New limit again pushed 200 more.

If the edge case of 190 end record in case of 390 does not work

If the record 640 up to 600 it is updating fine but last 40 records not updating.

If the record 2020 up to 2020 it is updating fine but last 20 edge case records not updating.


I am able to fetch exact count dynamic value as below

Object[] issueValues = map.values().toArray();
                                    
                                    int noOfIterations = 0;
                                    if (values.length >= 2) {                                   
                                 
                                     
                                        IssuesSize = values[2].toString();
                                        IssuesIntSize = Integer.parseInt(IssuesSize);
                                        int issueUpdateBatchSize = Integer.parseInt(props.getProperty("issueUpdateBatchLimitSize"));
                                        
                                        noOfIterations=IssuesIntSize/issueUpdateBatchSize;

How can I fix my edge cases based on above IssuesIntSize  and issueUpdateBatchSize  and IssuesIntSize

i am unable to understand how to modify below for edge case last iteration numbers like 190 ,40, 20 etc.
offset=limit;
Please advise

[Carey Brown]

String			updateIssueLoad = prepareUpdateIssueLoad(list.subList(0,limit));      
// above may not be 'limit' in length, seems like you should just use 'list'
String			updateIssueLoad = prepareUpdateIssueLoad(list);     

[sai rama krishna]

Thank you. After this change if I have 490 records it seems doing first 200 and last 90 but not 200 in between some reason.

If I have 660 it is updating 460 but leaving 200 records in middle. I have to run the application one more time to update these remaining 200 as well.



If I have 880 it is updating 680 but leaving 200 records in middle. I have to run the application one more time to update these remaining 200 as well.

I changed to for loop and changed condition from < to <= still same behavior.
Please advise

[Carey Brown]

Have you tried putting in print statements for 'offset' and  'limit' to see what the actual values are?

[Carey Brown]

offset += list.size();

[sai rama krishna]

Thank you very much.
Where i can find these type of moderate to high complex real time challenges to practice?
(It took 4 days for me to understand think through and modify existing implementation to enhance this type of logic which should Ideally be done in few minutes once I practice these type of challenges daily or more frequently)

[Carey Brown]

You might try HackerRank.com. Go to Java section. Exercises start off simple and increase in difficulty.

[sai rama krishna]

Thank you. I will work on those challenges in that same order. If some one gives me idea or code it makes sense to me. But I am taking long time to get ideas and  implementation plan which I am currently working on to improve.