Testing hierarchical method calls

[Vladas Razas]

Hello,

I implement code that takes XML document and copies required data into Java objects. I have groups that may contain other groups and entries. The calls looks like

buildModel()
calls parseHierarchy()
calls parseGroup()
calls parseEntry()
calls parseHierarchy() - yes yes , recursive call

I write JUnit tests for parseGroup, parseEntry.. but now to test parseHierarchy I would have to submit the data from parseGroup and parseEntry.. And to test buildModel I will have to submit data from all previous tests. The buildModel will fail if there is something wrong with parseHierarchy, parseGroup or parseEntry methods. Testing parseGroup and parseEntry requires lots of test data alone...

I understand that neither parseHierarchy nor buildModel are concerned how to test smaller methods called (since they have their own tests).

How to test code in this situation. According to "Pragmatic Programmer" book if the test code significantly larger than original code then it's probably due to bad code design. How could I improve this design and test everything propertly?

Thanks,
Vladas

[Jeanne Boyarsky]

Vladas,
You don't have to retest all the data from the parseGroup/parseEntry methods. Those tests could be more detailed. In the buildModel test, you could test the overall flow (and whatever it is that buildModel does.)

For example, the parse tests could check for a string index out of bounds case. Build model wouldn't necessarily need that test since it is contained by the smaller methods.

Alternatively, you could just test buildModel since it calls the other methods. (I like your approach better though.)

[Siva Jagadeesan]

I assume that ur buildModel() method just calls all these methods
parseHierarchy()
parseGroup()
parseEntry()
parseHierarchy() - yes yes , recursive call

The way I will follow is Unit Test small methods and write a Test for buildModel() using Mock and make sure buildModel() is calling these small methods as intended
[ September 27, 2004: Message edited by: Siva Jagadeesan ]