Dmitri Christo

Go back to india.

You can create a better future for you and your family if you are in your home land. Given the current economic situation this would be best for all.

Thanks David,

I changed that textfield to: <s:hidden name="person.id" value="#attr.id" label="Primary Key" />

Is my ognl syntax correct for the value parameter? The plan is to pre-populate the field with the id parameter taken from the URL, but keep it invisible to the user.

As you can see in my code in the above posts the Action class calls a save method which is delegated to the ServiceImpl class. Now during debugging, when the save method of the ServiceImpl class returns, the id is null (which causes a new insert) -- but when I query the person object at the Action class level, the id equals that new integer id defined automatically by the database.

I am not sure why the id is not retrieved from the URL successfully. It has to be grabbed there, or else a new record will be generated instead..

Yes, I'll do that thanks. But is there a way to use struts2 tags, within the existing <s:textfield> tag? Is there an example for that perhaps?

Yes, that field should be hidden actually, but, is there a way to retrieve that parameter from the URL at the jsp level? Using a struts 2 tag?

I am not sure if the following can help, but here are the related classes and struts.xml:
<?xml version="1.0" encoding="UTF-8" ?> <!DOCTYPE struts PUBLIC "-//Apache Software Foundation//DTD Struts Configuration 2.0//EN" "http://struts.apache.org/dtds/struts-2.0.dtd"> <struts> <constant name="struts.enable.DynamicMethodInvocation" value="false"/> <constant name="struts.devMode" value="false"/> <package name="default" namespace="/" extends="struts-default"> <action name="Menu"> <result>pages/firstpage.jsp</result> </action> <action name="user"> <result>pages/user/user_auth.jsp</result> </action> <action name="admin"> <result>pages/admin/admin_auth.jsp</result> </action> <action name="list" method="execute" class="org.user.PersonAction"> <result>/pages/list.jsp</result> <result name="input">pages/list.jsp</result> </action> <action name="remove" method="remove" class="org.user.PersonAction" > <result>/pages/list.jsp</result> <result name="input">pages/list.jsp</result> </action> <action name="adduser"> <result>pages/user/Registration.jsp</result> </action> <action name="save" method="save" class="org.user.PersonAction" > <result>/pages/list.jsp</result> <result name="SUCCESS">pages/list.jsp</result> </action> <action name="edit"> <result>pages/user/UpdateAccountForm.jsp</result> </action> </package> <include file="org/visitor/visitor.xml"/> </struts>

..And the action class:
package org.user; import java.util.List; import com.opensymphony.xwork2.Preparable; import com.opensymphony.xwork2.Action; public class PersonAction implements Preparable{ private PersonService service = new PersonServiceImpl(); private List<Person> persons; private Person person; private Integer id; public PersonAction(){} public PersonAction(PersonService service) { this.service = service; } public String execute() { this.persons = service.findAll(); return Action.SUCCESS; } public String save() { System.out.println("In PersonAction before service.save"); this.service.save(person); System.out.println("In PersonAction after service.save"); // this.person = new Person(); System.out.println("In PersonAction after new Person"); System.out.println("In PersionAction" + " " + person.getFirstName()+" "+person.getLastName()+" "+person.getId()); return execute(); } public String remove() { service.remove(id); return execute(); } public List<Person> getPersons() { return persons; } public Integer getId() { return id; } public void setId(Integer id) { this.id = id; } public void prepare() throws Exception { if (id != null) person = service.find(id); } public Person getPerson() { return person; } public void setPerson(Person person) { this.person = person; } }

..The Service implementation:
public class PersonServiceImpl implements PersonService { Session session; public PersonServiceImpl() { session = HibernateUtil.getSessionFactory().getCurrentSession(); } public void setSession(Session s){ this.session = s; } public Session getSession(){ if (session == null){ session = HibernateUtil.getSession(); } return session; } @Override public void clear() { getSession().clear(); } @Override public Person find(int id) { try { getSession().beginTransaction(); Query q = session.createQuery("from Person p where p.id=:id"); q.setInteger("id",id); return (Person)q.uniqueResult(); } finally { //getSession().close(); } } @SuppressWarnings("unchecked") @Override public List<Person> findAll() { try { Session session = HibernateUtil.getSession(); session.beginTransaction(); Query q = session.createQuery("select p FROM Person p"); return q.list(); } catch(Exception e){ System.out.print("Error while fetching "+e); return null; } finally { //session.close(); } } @Override public void flush() { getSession().flush(); } @Override public void remove(int id) { Person person = find(id); Session session = HibernateUtil.getSession(); Transaction tx = null; if (person != null){ try { tx = session.beginTransaction(); person =(Person)session.load(Person.class,id); session.delete(person); tx.commit(); }catch (RuntimeException e) { if(tx != null) tx.rollback(); throw e; } finally { session.close(); } } } @Override public void save(Person person) { Session session = HibernateUtil.getSession(); Transaction tx=null; if (person.getId() == null) { try { tx = session.beginTransaction(); session.persist(person); tx.commit(); } catch (RuntimeException e) { if(tx != null) tx.rollback(); throw e; } } else { try { tx = session.beginTransaction(); session.merge(person); tx.commit(); } catch (RuntimeException e) { if(tx != null) tx.rollback(); System.out.println("10"); throw e; } } /*try { tx = session.beginTransaction(); session.saveOrUpdate(person); tx.commit(); } catch (RuntimeException e) { if(tx != null) tx.rollback(); throw e; } finally { session.close(); }*/ } }

..And the two pages the user will navigate: list.jsp and edit.jsp :
<%@ taglib prefix="s" uri="/struts-tags"%> <p>Persons found on database</p> <a >Add new User</a> <s:if test="persons.size > 0"> <table> <s:iterator value="persons"> <tr id="row_<s:property value="id"/>"> <td> <s:property value="id" /> </td> <td> <s:property value="firstName" /> </td> <td> <s:property value="lastName" /> </td> <td> <s:url action="remove" var="remURL"> <s:param name="id" value="id" /> </s:url> <a remURL"/ rel="nofollow">">Remove</a> </td> <td> <s:url action="edit" var="editURL"> <s:param name="id" value="id" /> </s:url> <a editURL"/ rel="nofollow">">Edit</a> </td> <td> <a rel="nofollow">View account details</a> </td> </tr> </s:iterator> </table> </s:if> <a >Back to Administrator's homepage</a> ,

and:
<%@ page contentType="text/html; charset=UTF-8" %> <%@ taglib prefix="s" uri="/struts-tags" %> <html> <head> <title>Update User</title> <s:head/> </head> <body> <h4>Edit information for selected user</h4> <s:form action="save"> <s:textfield name="person.firstName" value="%{person.firstName}" label="First Name"/> <s:textfield name="person.lastName" label="Last Name"/> <s:hidden name="person.id" value="id" label="Primary Key" /> <s:submit/> </s:form> </body> </html>

I certainly hope this additional information might help shed some more light this issue.

Thanks again for your response.
Regards.

Hello,

I am building a Struts2 application using Hibernate and after the user navigates through the pages, they follow a link: http://localhost/MyApp/edit.action?id=38

Basically this brings up a form where the user will modify an existing record on a database. The record's primary key, (id) is provided as a parameter in the URL the user clicked on.

My problem is retrieving and storing this request parameter in the jsp page which contains the form. So far my form looks like this:
<%@ page contentType="text/html; charset=UTF-8" %> <%@ taglib prefix="s" uri="/struts-tags" %> <html> <head> <title>Update User</title> <s:head/> </head> <body> <h4>Edit information for selected user</h4> <s:form action="save"> <s:textfield name="person.firstName" label="First Name"/> <s:textfield name="person.lastName" label="Last Name"/> <s:textfield name="person.id" value="%{person.id}" label="Primary Key"/> <s:submit/> </s:form> </body> </html>
For a reason that I am not able to understand, the Primary Key field on the form, instead of being pre-populated, it is blank, waiting for the user to enter the value.

I know it must have something to do with how I use the struts tags, or the ognl expression, but so far, I was not able to solve this. The consequences is that instead of doing an update, the action ends up doing a new insert. The action code checks if the id is null and if it is then a new insert occurs, if the id is not null, then an update should take place:

public void save(Person person) { Session session = HibernateUtil.getSession(); Transaction tx=null; if (person.getId() == null) { try { tx = session.beginTransaction(); session.persist(person); tx.commit(); } catch (RuntimeException e) { if(tx != null) tx.rollback(); throw e; } } else { try { tx = session.beginTransaction(); session.merge(person); tx.commit(); } catch (RuntimeException e) { if(tx != null) tx.rollback(); throw e; } } }

So, how do I use a struts2 tag in a jsp to retrieve request parameters from the url? i believe that this is the root cause of my problem.

Thanks in advance for any help.

Thanks for the input. The case is that I have some education budget left and it has been recommended I use toward additional Sales training. Certainly it would be better if everyone in the team attended but...

Out of the 2 or 3 seminars you attended is there one you would say you got more out of? I know people attend these seminars for different reasons, but just wondering if you would share any specifics. Thanks

Not sure if this is the right place to post this, but, was wondering if anyone would suggest a Solution Selling training program / workshop in the US.

I am more interested in feedback from people who actually have attended such events before, and would recommend specific seminars delivered by specific organizations. Too many come up in a Google search and just would like some opinions first. Hope its ok to discuss this on JavaRanch.

Thank you

If there will be a new model, it will still come from the U.S. No other country has such a system to support business innovation, competitiveness and growth.

could be wrong, but seems like it was a family from India...

I am not sure what is wrong with my code. My question is, am I making one or two distinct requests/connections here? I can tell I am carrying the same cookie over to the second urlconnection, but I am still getting this response (when I retrieve and print the html response from the server):
<div class="body"><p>Your browser's cookie functionality is turned off. Please turn it on.

Here is my approach:
URL url1 = new URL("https://www.adomain.com/users/"); URLConnection uc = url1.openConnection(); String headerName=null; String myCookie=null; for (int i=1; (headerName = uc.getHeaderFieldKey(i))!=null; i++) { if (headerName.equals("Set-cookie")||headerName.equals("Set-Cookie")){ myCookie = uc.getHeaderField(i); //System.out.println(myCookie); } //System.out.println(headerName+" = "+uc.getHeaderField(i)); } //System.out.println(myCookie); URL url2 = new URL("https://www.adomain.com/users/"); URLConnection uc2 = url2.openConnection(); uc2.setRequestProperty("User-agent","Mozilla/4.0"); uc2.setRequestProperty("Cookie", myCookie); uc2.setDoOutput(true); uc2.connect(); //Write to the connection OutputStream raw = uc2.getOutputStream( ); OutputStream buffered = new BufferedOutputStream(raw); OutputStreamWriter out = new OutputStreamWriter(buffered, "UTF-8"); out.write(qs.getQuery()); //Here I am encoding the query string out.flush( ); out.close( ); try { InputStream in = uc2.getInputStream( ); // Read the response InputStreamReader r = new InputStreamReader(in); int c; while((c = r.read( )) != -1) { System.out.print((char) c); } System.out.println( ); in.close( ); }catch (IOException ex) { System.err.println(ex); }

--Am I making an obvious mistake I am not seeing, or could it be something with redirects, etc?

Thanks for any help
[ May 21, 2008: Message edited by: Dmitri Christo ]

Yes, HttpClient works smoother, but I have to user URLConnection in my case.

There is a lot of information about URLConnection and cookies out there, but couldn't find an answer to this one.

I am trying to understand the lifecycle of the session, so I can use the cookie in my response. So the connection is established with myUrl.openConnection(); - and it is opened with myUrl.connect(); right?

I have to set the cookie with myUrl.setRequestProperty("Cookie", myCookie); before calling connect(), but it is too soon because to find out the cookie value, I have to call getHeaderField(); after connect() -- Any ideas?

Hi, I am trying to understand how cookies should be handled over the same http session. I know how to query and store cookies and then send cookies back in a POST request but cannot do that in the same session.

Setting the cookie with setRequestProperty() must be done before calling connect(), but querying and storing the cookie with getHeaderField() is possible only after connect() is called. So, how can I send a cookie parameter before even knowing its value?

The trouble here is that with every connection the cookie value changes to reflect a new session id. If it was a cookie with a fixed/static value, I could do this in a two-step process. But this is not the case here..

Hope someone might have faced something similar..

Many thanks for any help.
[ May 20, 2008: Message edited by: Dmitri Christo ]

I can't tell for sure off the top of my head, I didn't keep count actually. Will take me some time to check that.

But, I did forget to mention in my previous post, that I had several inner classes mostly in the gui package (around 5 or 6 I think)

I wouldn't worry about the quantity of your packages, there is no right or wrong here. My main design principle was to keep everything minimal, almost basic, while fulfilling all requirements.

I'm sure you'll do fine

my choices.txt file was about 7KB (uncompressed). Sounds not too big, but you can put a lot of information in ascii format in there actually. My submission jar file was 365KB.

In the suncertify.code folder I had four packages:

db - 9 classes
direct - 1 class
remote - 6 classes
gui - 12 classes

Andrew's book gave me a lot of good ideas for the packaging structure and design in general. However, I didn't follow the value object approach (RMI works just fine with arrays of strings), and the use of concurrent package. I only used synchronized to take care of all locking.

Thanks Bob for your helpful advice so far, and best of luck with your assignment. I am sure you'll do just great.

Some more final notes:
1) I used RMI since it is straightforward to implement and there are plenty of good threads in this forum analyzing the topic.
2) I used minimal logging only during the remote connection phase, just as an indicator that the connection was successfully established.
3) My assignment required cookies, and I used System.currentTimeMillis(); to generate the cookie with notifyAll(); in the unlock method. The design was based in two different classes (FileManager and LockManager). This is discussed in a lot of detail in past conversations.
4) Used this to check my locking design
5) Minimal GUI, just two text case-sensitive fields, and only three buttons: search, book and unbook - (Well, I lost some points here, so perhaps they do expect a more elaborate user interface)

I know searching this forum requires some effort, but you will really find all you need in here. I found out later I didn't even need to ask several of my questions in the first place, since they were already answered.