Stephan van Hulst wrote:I really liked that one, because it's the first real example I've seen of a case where a LinkedList greatly outperforms an ArrayList.
Campbell Ritchie wrote:If you iterate the entry set, you may get a different order of iteration.
The map is ordered according to the natural ordering of its keys, or by a Comparator typically provided at sorted map creation time. This order is reflected when iterating over the sorted map's collection views (returned by the entrySet, keySet and values methods).
Stephan van Hulst wrote:Strongly agreed. Always perform division as late as possible, and then prefer BigDecimal over Double, unless performance is important and accuracy isn't.
Stephan van Hulst wrote:Don't use raw types. Declare your type variable as T extends Comparable<? super T>.
<br /> <br /> Why are there br symbols appearing here? Seems to be a bug in the forum software - I didn't put them in, but I can't seem to remove them. Anyway... <br /> <br /> Yeah, I'm less enthusiastic about this one as it makes method signatures even harder to read, but it can have benefits, so OK.
Stephan van Hulst wrote:Use wildcards in method parameters: Map<? extends T, ? extends Long>. I don't feel strongly about doing this with final types (like Long), but it is more consistent and clearly conveys intent.
Stephan van Hulst wrote:Why is the size parameter a double? If the only reason is to perform an implicit cast, then you're sacrificing the principle of least astonishment to make your code just a tiny little bit less verbose.
Stephan van Hulst wrote:Personally I would have your remap() method operate on the current map, rather than a new one. It saves a lot of copying, and if you actually need a copy then just make the copy before you pass it into the method.
Stephan van Hulst wrote:Don't use the return values of assignments in enclosing expressions in any but the most common idioms, such as incrementing an index while accessing an array.
Stephan van Hulst wrote:You use two collect() operations in your cdf() method. That's wasteful. Use a downstream collector to specify what should be done with the values of the map while the groupingBy() is doing its magic.
Stephan van Hulst wrote:Why is T a Number? The only thing that your methods require about T is that it has a natural order.
Piet Souris wrote:The map.forEach() allows the very convenient (k,v) -> construct, and for that I'm willing to skip functional code. As you see, it is just a very clear short one-liner.
Stephan van Hulst wrote:Why is your CDF keyed by probability? A CDF returns a probability given an observation, so it makes sense to keep T as the key.
Biniman Idugboe wrote:
should work. However, it does not work, unless the right hand side is cast to Object. But the statement that caused the error did not cast the right hand side to Object.
Biniman Idugboe wrote:At this moment, my understanding of ? super T is that it means any subclass of a class. That is, the class must have a superclass. The Object class, for example, does not have a super class. That should mean that Comparator<Object> is invalid, but that's not true.