So, again, this code is clearly copied (and subsequently modified) from the Google Guava open-source project. Based on the @Beta annotation, it looks like it was copied from a version no later than TreeBasedTable.java v19.0
. Beyond that, I'm not sure what specific version they were working from.
Anyway, a few notes from browsing Google's versions of the code:
Google does not seem to ever have a version of this code that includes the final modifier on method parameters. That seems to be something added by people at the original poster's company. Like others here, and like those at Google, I see no real point to having such a modifier on method parameters. Unfortunately it's pervasive in the codebase I see at work, but oh well.
Google's code also does not generally contain those overlong lines. Those seem to come from changes introduced at the OP's company.
Google was indeed developing Guava for pre-Java 8 code, at least originally, and since it's a widely used open source library they tend to retain as much backward compatibility as they can. Though at this point they don't officially maintain a pre-Java 8 version, just one for Java 8+ and one for Android. So you won't see them using newer language features than Java 8 in that branch.
Of course, at the company the OP is working for, they might have inserted other newer features. Or not. I haven't looked carefully to see what all they changed.
Glad to hear it's worked out now. I know it's a pain to deal with code of unknown provenance and quality, in an unfamiliar language. If you find you need to deal with this code more in the future, I might suggest, try removing all the files you see in the com/google/common directories, where "remove" assumes you have good version control to restore it if needed.
And instead fix any compilation errors by bringing in .jar files from Google for any libraries you need, starting with guava-19.0.jar
. You may try other versions instead. Ideally you get everything to compile under 31.0.1 or something similarly recent, and you'll probably have (a) less code in your codebase, and (b) better code overall. Or perhaps, by doing this, you'll discover why someone in your company felt the need to change the original Google code.