All about Mathew Mintalm

Sorting objects by type, is that okay?

Hello, I have android java game, where I have to deal with many different types of objects and their coordinates (player needs to place object in destination X/Y) But to make it less annoying for player I wanted to let him place object in any possible position (if there is more than one object of same type) I made this logic test code to sort objects by type, and than "send" all possible coordinates to each object:

public class Test
{
private HashMap<ObjectType, ObjektHolder> map = new HashMap<ObjectType, ObjektHolder>();
private ArrayList<GameObject> allObjects = new ArrayList<GameObject>();
public Test()
{
long a = System.currentTimeMillis();
addObjekt(new Box(1, 1));
addObjekt(new Box(2, 2));
addObjekt(new Box(3, 3));
addObjekt(new Container(4, 4));
addObjekt(new Container(5, 5));
addObjekt(new Container(6, 6));
addObjekt(new Container(7, 7));
addObjekt(new Container(8, 8));
for (Map.Entry<ObjectType, ObjektHolder> entry: map.entrySet())
{
entry.getValue().sendCoordsToObjects();
}
System.out.println("=======================================");
for (GameObject o: allObjects)
{
for (float[] f: o.getPossibleCoords())
{
System.out.println("x: " + f[0] + ", y: " + f[1]);
}
System.out.println("=======================================");
}
System.out.println("czas: " + (System.currentTimeMillis() - a));
}
public void addObjekt(GameObject objekt)
{
if (map.containsKey(objekt.getType()))
{
map.get(objekt.getType()).addObjekt(objekt);
}
else
{
ObjektHolder holder = new ObjektHolder();
holder.addObjekt(objekt);
map.put(objekt.getType(), holder);
}
allObjects.add(objekt);
}
public class ObjektHolder
{
private ArrayList<GameObject> objects;
private ArrayList<float[]> possibleCoords;
public ObjektHolder()
{
objects = new ArrayList<GameObject>();
possibleCoords = new ArrayList<float[]>();
}
public void addObjekt(GameObject objekt)
{
objects.add(objekt);
possibleCoords.add(objekt.getDest());
}
public void sendCoordsToObjects()
{
for (GameObject o: objects)
{
o.setPossibleCoords(possibleCoords);
}
}
}
public static void main(String[] args)
{
new Test();
}
private enum ObjectType
{
TYPE_BOX1,
TYPE_BOX2,
}
public class Box extends GameObject
{
public Box(float destX, float destY)
{
super(ObjectType.TYPE_BOX1, destX, destY);
}
}
public class Container extends GameObject
{
public Container(float destX, float destY)
{
super(ObjectType.TYPE_BOX2, destX, destY);
}
}
public class GameObject
{
private ObjectType Type;
private float[] dest;
public ArrayList<float[]> possibleCoords;
public GameObject(ObjectType type, float destX, float destY)
{
super();
Type = type;
dest = new float[] {destX, destY};
possibleCoords = new ArrayList<float[]>();
}
public ObjectType getType()
{
return Type;
}
public float[] getDest()
{
return dest;
}
public void setPossibleCoords(ArrayList<float[]> array)
{
this.possibleCoords = array;
}
public ArrayList<float[]> getPossibleCoords()
{
return possibleCoords;
}
}
}

My question is, I am not sure if its done right, and maybe there is anything I can do it better? Thank you.

Mathew Mintalm

Recent posts by Mathew Mintalm