vinay basavanal

HI All,

I am getting http server reponse code 400 when i am running below but however it runs fine when i have proxy configured in my server
URL url = new URL(reqUrl); HttpURLConnection con = (HttpURLConnection)url.openConnection(); con.setDoOutput(true); con.setRequestMethod(request.getMethod()); if(request.getContentType() != null) { con.setRequestProperty("Content-Type", request.getContentType()); } con.setRequestProperty("Referer", request.getHeader("Referer")); int clength = request.getContentLength(); if(clength > 0) { con.setDoInput(true); InputStream istream = request.getInputStream(); OutputStream os = con.getOutputStream(); final int length = 5000; byte[] bytes = new byte[length]; int bytesRead = 0; while ((bytesRead = istream.read(bytes, 0, length)) > 0) { os.write(bytes, 0, bytesRead); } } else { con.setRequestMethod("GET"); } out.clear(); out = pageContext.pushBody(); OutputStream ostream = response.getOutputStream(); System.out.println(" finished getOUTputsteram"); response.setContentType(con.getContentType()); InputStream in = con.getInputStream(); final int length = 5000; byte[] bytes = new byte[length]; int bytesRead = 0; while ((bytesRead = in.read(bytes, 0, length)) > 0) { ostream.write(bytes, 0, bytesRead); }

The below code does Read csv files and process it to do some sort of cacluations.This is more of small picture code , to introduce big picture. The csv file contains information of seeds of crop which have some information in number depending upon the numbers the calcuation have to be done.There are different types of calucations based on traits types. The csv file will contains hybrid numbers followed by the traits . I have recorded observations for 6 traits, now at first i will read traits used in the applicaitons some traits may have 2 ,3 or n enteries.This is stored in db so i will pull inforamtion from there , once i read traits then i will read each hybrid number and trait values once i read trait values of particular trait i will either avgerage or do some more processing for som e trait the value depends on other triats.

Please have a look at it and let me know if it has to be improveed from design/implementation point of view.

Hybrid PLTHT01 PLTHT02 Avg YLDTH01 YLDTH01 YLD TLSSG01 TLSSG02 TLSSG03 TLSSV HH01 24 42 23 33 42 34 22 HH02 26 40 27 37 42 34 22 HH03 28 38 31 41 42 34 22 HH04 30 36 35 45 42 34 22 HH05 32 34 39 49 42 34 22 HH06 34 32 43 53 42 34 22 HH07 36 30 47 57 42 34 22 HH08 38 28 51 61 42 34 22 HH09 40 26 55 65 42 34 22 HH10 42 24 59 69 42 34 22



I have even entered values for TLSSG01 TLSSG02 TLSSG03 but they are not visible ,

Below is the Code:

import java.io.BufferedReader; import java.io.FileReader; import java.io.IOException; import java.util.ArrayList; import java.util.HashMap; import java.util.List; import java.util.Map; public class HybridDataProcessor { public static void main(String[] args) { BufferedReader br = null; try { // holds currentline vlues String sCurrentLine; Map<String, HashMap<String,Float>> hybridTraitValues = new HashMap<String,HashMap<String, Float>>(); // a mapping to traitName and no of columns it will have HashMap<String, Integer> listDataPointMap = new HashMap<String, Integer>(); listDataPointMap.put("PLTHT",2); listDataPointMap.put("YLDTH",2); listDataPointMap.put("YLD",1); listDataPointMap.put("TLSSG",3); listDataPointMap.put("TLSSV",1); List<String> traitList = new ArrayList<String>(); // HashMap<String, Float> traitValues = new HashMap<String, Float>(); br = new BufferedReader(new FileReader("C:\\testing.csv")); int lineNumber = 0; while ((sCurrentLine = br.readLine()) != null) { lineNumber++; String[] itemValues = sCurrentLine.split(","); // if line number then we need to get all the tratis used in csv file if (lineNumber == 1) { for (int j = 1; j < itemValues.length; j++) { String traits = itemValues[j]; // if column name is avg do not consider it as trait if(traits.equalsIgnoreCase("avg")){ continue; } // since yld is special trait and it does not have 01 attached to it we will add it directly if(traits.equalsIgnoreCase("YLD")){ traitList.add(traits); continue; } // since TLSSV is special trait and it does not have 01 attached to it we will add it directly if(traits.equalsIgnoreCase("TLSSV")){ traitList.add(traits); continue; } traits=traits.substring(0,traits.length()-2); if(!traitList.contains(traits)) traitList.add(traits); } } else { String hybridName = itemValues[0]; int datPts=0; int currentPosition = 1; for (String traits : traitList) { // calcutes the vlalue of each trait with respective hybrid if(traits.equalsIgnoreCase("YLD")){ float avg =getYLD(hybridTraitValues.get(hybridName).get("YLDTH")); update(hybridTraitValues, hybridName, avg, traits); currentPosition=currentPosition+1; } else if(traits.equalsIgnoreCase("TLSSV")){ float avg =gettlssv(hybridTraitValues.get(hybridName).get("TLSSG")); update(hybridTraitValues, hybridName, avg, traits); currentPosition=currentPosition+1; } else { datPts=listDataPointMap.get(traits); float avg =getAvg(itemValues, datPts, currentPosition); update(hybridTraitValues, hybridName, avg, traits); if(traits.equalsIgnoreCase("PLTHT")){ currentPosition=currentPosition+datPts+1; }else{ currentPosition=currentPosition+datPts; } } } } } } catch (IOException e) { e.printStackTrace(); } finally { try { if (br != null) br.close(); } catch (IOException ex) { ex.printStackTrace(); } } } public static float getAvg(String[] itemValues,int dataPts,int currentPosition){ float avg=0; for (int j = currentPosition; j < (currentPosition + dataPts); j++) { avg+=Float.parseFloat(itemValues[j]); } return avg=avg/2; } public static float getYLD(float avg){ return avg=avg/10; } public static float gettlssv(float avg){ return avg=avg/10; } public static void update(Map<String, HashMap<String,Float>> hybridTraitValues,String hybridName,float avg,String traitName){ HashMap<String, Float> traitValues= hybridTraitValues.get(hybridName); if(traitValues==null){ traitValues = new HashMap<String, Float>(); } traitValues.put(traitName, avg); hybridTraitValues.put(hybridName, traitValues); } }


Does this look like OO code

fred rosenberger wrote:The first step in doing optimization is always to use a profiler to determine where it is slowing down.

Sure, you can look, and you can guess...but almost every time, you will guess wrong.

populateLinks is the method which approximately takes about 70% of time i.e about 16 sec .It has recursion and iteration how can i optimize this.

I have written some code which will fetch contents from a resource which is actually stored in a tree format. Since it is in a tree format, there will be a parent-child relation and hence recursion.

I am facing lot of performance issue as tree is growing in size this particular piece of code takes up-to 25 sec which is very bad. This piece of code will basically read data stored in file system (just for example) each content has certain set of property which it has to read.

import java.util.List; public class Links { private String nodeName; private List<Links> children; public List<Links> getChildren() { return children; } public void setChildren( List<Links> children ) { this.children = children; } public String getNodeName(){ return nodeName; } public void setNodeName( String nodeName ){ this.nodeName = nodeName; } } package menu; import java.util.ArrayList; import java.util.Iterator; import java.util.List; public class Utility { /* * IN this class NavModel,CModel,CNode are some dummy classes which help us read contents form some resources which * are stored in dummy format as Example of tree format stored data below is the example tree child1 child2 child3 * child3-1 child:q child:r child:a child3-2 child4 */ private static void populateLinks( NavModel navModel, ContentModel metaDataModel, Object objectNode, Links parent, boolean specialLinks ) throws IOException{ try{ List<Links> childLinks = new ArrayList<Links>(); // below code gets all the childrens of parent Iterator it = navModel.getChildren( objectNode ); while( it.hasNext() ){ NavNode node = (NavNode) it.next(); ContentNode contentNode = node.getContentNode(); Links links = new Links(); MetaData data = metaDataModel.getMetaData( contentNode ); Map<String, String> paramValues = new HashMap<String, String>(); // this particular piece of // code gets all the properties of content iterates and stores it in data structure Iterator metaDataIterator = data.getNames().iterator(); while( metaDataIterator.hasNext() ){ String pagePropertyKey = metaDataIterator.next().toString(); String pagePropertyValue = (String) data .getValue( pagePropertyKey ); if( pagePropertyKey.equalsIgnoreCase( "LINK_TYPE" ) ){ links.setLinkType( pagePropertyValue ); } else if( pagePropertyKey.equalsIgnoreCase( "TCDID" ) ){ links.setTcmIdMap( pagePropertyValue ); } else{ paramValues.put( pagePropertyKey, pagePropertyValue ); } } links.setParamValues( paramValues ); if( specialLinks ){ links.setNodeName( links.getParamValues().get( "APPLICATIONNAME" ) ); } else{ links.setNodeName( contentNode.getTitle( new Locale( "en_US" ) ) ); } links.setDisplayName( setAppDispName( links.getNodeName() ) ); childLinks.add( links ); if( navModel.hasChildren( node ) ){ // This is where recursion happens populateLinks( navModel, metaDataModel, node, links, specialLinks ); } } parent.setChildren( childLinks ); } catch( Exception e ){ } } // THis is the method which calls the recursion function public static Links setupLinks( String categoryLinkName, String name ){ Links categoryLinks = null; CModel contentModel = new CModel(); NavModel navModel = new NavModel(); categoryLinks = Utility.createCategoryLinks( categoryLinkName ); Object objectNode = contentModel.getLocator().findByUniqueName( name ); if( objectNode != null ){ if( navModel.hasChildren( objectNode ) ){ populateLinks( navModel, objectNode, categoryLinks ); } } } private static Object setAppDispName( String nodeName ){ // fetch value from db return null; } }

I know code is not complete and may be in appropriate to review but I can't paste the whole of my code hence I hope you understand and review there is recursion and iteration any way I can better write this piece of code.

Thank you now i have mentioned that i have two different projects , one is for service and other is backend layer , service layer interacts with backend what should be my aim actually should it be to test code or functionality, should i write test case for serviced layer alone without backend and how it must be.

Points Taken,

Now can you please explain me how can use stratergy pattern, each crops will have 100 of traits let say each crop has 10 different tratis where calculations differ how can i handle this so lets say traits like plantHeight, yeild ,qa_HU , tlssg need different calculations then how will i do it something like ?
public class Traits { int dataPoints; public void calcuate(){ } }


and in my main code where i do caluations should be like this

if(traitName=="plantHeight"){ Traits plantHeight = new Traits(); plantHeight.calucate(): } if(traitName=="yeild"){ Traits yeild= new Traits(); yeild .calucate(): }

HI All,

We want to use junit in our applications, the problem i am facing is , is junit used to test a piece of code or to test functionality.MY appliaction is a web applicaiton .I have get data from ui through servlet/jsf and pass the data to backedn throgh facade pattern i.e i have some service classes and then there is dao layer or a webservice layer which will persist or fetch data from backend services.We have classified our applications in to three projects one is core progject which is like api where we have helper classes like db connection and JDBC utiliity classses.THen there is serice project where basically has service and vo and the web project.NOw how can i use junit in this scenario should i use it to test end to end funcitonality or just do a piece of code testing please help

I am having trouble designing a module, can anybody help me?

Because it will be hard to maintain this kind of module, I also think that this can test my skill of design pattern usage.

Requirement

This is basically an agricultural project (web application). I need to design a module where some calculation takes place.

There are different crops involved like maize, tomato, okra etc. Each of these crops has different traits.

Each trait has a measurement scale which lies in integer like 200-1000. Now let's say I have planted the crop and done measurement noted down the traits. Now I want to do some sort of measurement. Some measurements are simple and some are complex.

Example

Lets take an example of crop maize. I have recorded observations for 15 traits. (We'll use trait1-trait15 as examples, the actual name can be like plt_ht, yld, etc.)

I recorded 5 observations for each trait:

trait1 trait2 trait3 trait5 trait6..... trait15
01,02,03,04 01,02,03,04 01,02,03,04
User logs into system and selects his crops and enters data for these observations. I have to calculate either average or sum of the data entered for each trait.

Complexity / centre of the problem

So far it's simple but complexity comes when I have some different formulas for some of the traits.

Example: trait YLD has a formula based on which I have to calculate its value, which may also depend on some other traits. Each different crop can have different traits.

All this I am able to do - whenever user selects crop I will check for those specific traits and do calculations (if it's not a special trait then I either average or sum it, based on db entry), but there is a lot of hard coding.
I would like to have suggestions on a better way of handling this.

My code needs to handle both simple and complex calculations.
Simple calculations are easy, I have take average of value entered for trait.
The problem comes when I have to do complex calculations, since each crop have different traits with their own formulas, so to calculate I have to check for crop and then for complex trait. So I have to hardcode the trait name of complex traits.
Can any tell me how I can design this using Java oops [?!?] so that I can make it generic?

I have about 10 different crops. Some calculations are specific to crops, so there will be lot of code like the if below:

hasZeroValue = (HashMap<String, ArrayList<String>>) dataValues[1]; } else if(cropId.equalsIgnoreCase("TO") && traitName.equalsIgnoreCase("TLSSG_70")) { traitAvg=calculateTLCV(traitName, traitAvg,dataPoint, dataTraits, hybrid, repl, traitValues, dataPvalues,50); } else if(cropId.equalsIgnoreCase("TO") && traitName.equalsIgnoreCase("TLSSG_100")) { traitAvg=calculateTLCV(traitName, traitAvg,dataPoint, dataTraits, hybrid, repl, traitValues, dataPvalues,50); } else if(cropId.equalsIgnoreCase("TO") && traitName.equalsIgnoreCase("YVMV_60")) { traitAvg=tomatoYVMVCalculation(traitName, traitAvg,dataPoint, dataTraits, hybrid, repl, traitValues, dataPvalues); } else if(cropId.equalsIgnoreCase("TO") && traitName.equalsIgnoreCase("YVMV_90")) { traitAvg=tomatoYVMVCalculation(traitName, traitAvg,dataPoint, dataTraits, hybrid, repl, traitValues, dataPvalues); } else if(cropId.equalsIgnoreCase("TO") && traitName.equalsIgnoreCase("YVMV_120")) { traitAvg=tomatoYVMVCalculation(traitName, traitAvg,dataPoint, dataTraits, hybrid, repl, traitValues, dataPvalues); } else if(cropId.equalsIgnoreCase("TO") && traitName.equalsIgnoreCase("ELCV_60")) { traitAvg=tomatoYVMVCalculation(traitName, traitAvg,dataPoint, dataTraits, hybrid, repl, traitValues, dataPvalues); } else if(cropId.equalsIgnoreCase("TO") && traitName.equalsIgnoreCase("ELCV_90")) { traitAvg=tomatoYVMVCalculation(traitName, traitAvg,dataPoint, dataTraits, hybrid, repl, traitValues, dataPvalues); } else if(cropId.equalsIgnoreCase("TO") && traitName.equalsIgnoreCase("ELCV_120")) { traitAvg=tomatoYVMVCalculation(traitName, traitAvg,dataPoint, dataTraits, hybrid, repl, traitValues, dataPvalues); } else if(cropId.equalsIgnoreCase("OK") && traitName.equalsIgnoreCase("YVMV_60")) { traitAvg=tomatoYVMVCalculation(traitName, traitAvg,dataPoint, dataTraits, hybrid, repl, traitValues, dataPvalues); } else if(cropId.equalsIgnoreCase("OK") && traitName.equalsIgnoreCase("YVMV_90")) { traitAvg=tomatoYVMVCalculation(traitName, traitAvg,dataPoint, dataTraits, hybrid, repl, traitValues, dataPvalues); } else if(cropId.equalsIgnoreCase("OK") && traitName.equalsIgnoreCase("YVMV_120")) { traitAvg=tomatoYVMVCalculation(traitName, traitAvg, dataPoint, dataTraits, hybrid, repl, traitValues, dataPvalues); } else if(cropId.equalsIgnoreCase("OK") && traitName.equalsIgnoreCase("ELCV_60")) {

From Desgin point and maintaininablility point which way should this be handled