irshad irshadoz

Hello,

i am running my unit test but for some reason i am getting a null pointer on this line

[code=java

mav.addObject(
"failLog",
messageSource.getMessage("login.user.fail", new String[] {
"a", "b" }, request.getLocale()));
][/code]

Please find below the method that my unit test will be based on:

@Controller public class LogInController { @Autowired UserManagerService userManagerService; @RequestMapping(method = RequestMethod.POST, value = "/login") public ModelAndView validateViewLogin(@ModelAttribute Person person, BindingResult result, HttpServletRequest request) { ModelAndView mav = new ModelAndView(); String userName = person.getFirstName(); String password = person.getPassword(); boolean isUserValid = false; if (userName != null && password != null) { isUserValid = userManagerService.validateUserLogin(userName, password); } if (!isUserValid) { mav.addObject( "failLog", messageSource.getMessage("login.user.fail", new String[] { "a", "b" }, request.getLocale())); mav.addObject("isUserValid", false); mav.setViewName("login"); return mav; }

Please find below my unit test:

@Test public void validateViewLogin_NotValidLogin_returnsLoginPage() { MockHttpServletRequest request = new MockHttpServletRequest(); Person person = new Person(); person.setFirstName("John"); person.setPassword("123"); isUserValid = false; LogInController controller = new LogInController(); // Inject mock user service into controller UserManagerService mockUserService = mock(UserManagerService.class); controller.setUserManagerService(mockUserService); // Configure mock user service to accept the person when(mockUserService.validateUserLogin("John", "123")).thenReturn( isUserValid); // Attempt the validation ModelAndView mav = controller .validateViewLogin(person, result, request); // Check the result assertEquals("login", mav.getViewName()); }

Please see stack trace below:

java.lang.NullPointerException at com.gemstone.presentation.LogInController.validateViewLogin(LogInController.java:100) at com.gemstone.presentation.LogInControllerTest.validateViewLogin_NotValidLogin_returnsLoginPage(LogInControllerTest.java:79) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

line 100 for my loginController is shown below:
messageSource.getMessage("login.user.fail", new String[] {

I am assuming that i need to mock message source. If this is the cause of my exception, how can i mock the messagesource in my unit test please?

However when i run my application it works fine no null pointer, its only when i run the unit test that i get the null pointer exception.

Thanks in advance.

thanks a lot for the clear explanation problem resolved

Hello Jeanne,

thanks a lot for your quick response..my apologies the example i gave above it was mainly to describe the scenario of my issue as i thought it was the return type issue. Please see the method which i want to carry out unit test for below:

@Controller public class LogInController { @Autowired private UserManagerService userManagerService; @RequestMapping(method = RequestMethod.POST, value = "/login") public ModelAndView validateViewLogin(@ModelAttribute Person person, BindingResult result, HttpServletRequest request) { ModelAndView mav = new ModelAndView(); String userName = person.getFirstName(); String password = person.getPassword(); boolean isUserValid = false; if (userName != null && password != null) { isUserValid = userManagerService.validateUserLogin(userName, password); } if (!isUserValid) { mav.addObject( "failLog", messageSource.getMessage("login.user.fail", new String[] { " ", "" }, request.getLocale())); mav.setViewName("home"); return mav; } mav.addObject("isUserValid", isUserValid); mav.setViewName("login"); return mav; }



My issue is that i don't know how to mock the boolean variable isUserValid? The variable isUserValid returns a boolean whereas my method validateViewLogin above returns a type ModelAndView. Basically i was trying to mock the isUserValid to return true so as to test the flow when the user is valid.

I was planning a unit test as shown below:

BindingResult result; @Test public void testValidateOk() { MockHttpServletRequest request = new MockHttpServletRequest(); MockHttpServletResponse response = new MockHttpServletResponse(); Person person = new Person(); ModelAndView mav = new ModelAndView(); mav.setViewName("login"); person.setFirstName("Andy"); person.setPassword("123"); request.addParameter("userName", "Andy"); request.addParameter("password", "123"); LogInController controller = new LogInController(); UserManagerServiceImpl mockpdao = mock(UserManagerServiceImpl.class); ReflectionTestUtils.setField(controller, "userManagerService", mockpdao); // given given(controller.validateViewLogin(person, result, request)).willReturn(mav); // when ModelAndView validateViewLogin= controller.validateViewLogin(person, result, request); // then assertEquals("home", validateViewLogin.getViewName()); }

My assert will be if user validation is successful page login will be displayed

When i run my unit test i get this error message:
org.mockito.exceptions.misusing.WrongTypeOfReturnValue: ModelAndView cannot be returned by validateUserLogin() validateUserLogin() should return boolean *** If you're unsure why you're getting above error read on. Due to the nature of the syntax above problem might occur because: 1. This exception *might* occur in wrongly written multi-threaded tests. Please refer to Mockito FAQ on limitations of concurrency testing. 2. A spy is stubbed using when(spy.foo()).then() syntax. It is safer to stub spies - - with doReturn|Throw() family of methods. More in javadocs for Mockito.spy() method. at com.gemstone.presentation.LogInControllerTest.testValidateOk(LogInControllerTest.java:48) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

I know i am getting this error because
isUserValid = userManagerService.validateUserLogin(userName,password); returns a boolean and my method expecting ModelAndView.How can i solve this to be able to carry out my unit test .




Any advice please?

This is my controller to validate a user when submitting a form with username, password and i am using spring framework.

thanks in advance

Hello all,

i am new to unit testing, and i am using mockito for my unit test. My question is i am writing unit test for methodB as it can be shown below but it is dependent on a variable from methodA in order to complete the test. how can i mock valueMethodA in methodB?



ClassA{ int methodeA(){ if(aCondition){ return 1; } return 2; } } ClassB{ boolean methodB(){ ClassA classA = new classA(); int valueMethodA = classA.methodeA(); if (valueMethodA==1){ return true; } return false; } }

i can mock the return value when the return type are the same but this case they are different, methodA returns an int type whereas methodB returns boolean. how to mock valueMethodA?

Any advice is most welcome.

Thnks in advacnce

my apologies its working fine i got the url wrong

Hello,

i am new to spring and i have created an application using SpringMvc 3.0 famework. My issue is that when i run my application in eclipse juno on Tomcat 7 i get the page not found error message.

I am assuming that my mapping is not done correctly.

Please see below my config:

Web.xml (path:market\src\main\webapp\WEB-INF\Web.xml) :

<!-- Creates the Spring Container shared by all Servlets and Filters --> <listener> <listener-class>org.springframework.web.context.ContextLoaderListener</listener-class> </listener> <!-- Processes application requests --> <servlet> <servlet-name>appServlet</servlet-name> <servlet-class>org.springframework.web.servlet.DispatcherServlet</servlet-class> <init-param> <param-name>contextConfigLocation</param-name> <param-value>classpath:spring/presentation.xml</param-value> </init-param> <load-on-startup>1</load-on-startup> </servlet> <servlet-mapping> <servlet-name>appServlet</servlet-name> <url-pattern>/spring/*</url-pattern> </servlet-mapping>

My file presentation.xml(path:market\src\main\resources\spring\presentation.xml)
<?xml version = "1.0" encoding = "UTF-8"?> <beans:beans xmlns="http://www.springframework.org/schema/mvc" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:beans="http://www.springframework.org/schema/beans" xmlns:context="http://www.springframework.org/schema/context" xmlns:tx="http://www.springframework.org/schema/tx" xmlns:mvc="http://www.springframework.org/schema/mvc" xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-3.0.xsd http://www.springframework.org/schema/mvc http://www.springframework.org/schema/mvc/spring-mvc-3.0.xsd http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context-3.0.xsd http://www.springframework.org/schema/tx http://www.springframework.org/schema/tx/spring-tx.xsd"> <!-- DispatcherServlet Context: defines this servlet's request-processing infrastructure --> <context:component-scan base-package="com.firstexample" /> <!-- Enables the Spring MVC @Controller programming model --> <mvc:annotation-driven /> <!-- Handles HTTP GET requests for /resources/** by efficiently serving up static resources in the ${webappRoot}/resources directory --> <resources mapping="/resources/**" location="/resources/" /> <!-- Resolves views selected for rendering by @Controllers to .jsp resources in the /WEB-INF/views directory --> <beans:bean class="org.springframework.web.servlet.view.InternalResourceViewResolver"> <beans:property name="prefix" value="/WEB-INF/views/" /> <beans:property name="suffix" value=".jsp" /> </beans:bean> <beans:bean id="validator" class="org.springframework.validation.beanvalidation.LocalValidatorFactoryBean" /> </beans:beans>

this is my controller:

package com.firstexample.presentation; import javax.servlet.http.HttpServletRequest; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.context.MessageSource; import org.springframework.context.support.ResourceBundleMessageSource; import org.springframework.stereotype.Controller; import org.springframework.validation.BindingResult; import org.springframework.web.bind.annotation.ModelAttribute; import org.springframework.web.bind.annotation.RequestMapping; import org.springframework.web.bind.annotation.RequestMethod; import org.springframework.web.servlet.ModelAndView; import com.domain.Person; import com.service.UserManagerService; @Controller public class LogInController { private static final Logger logger = LoggerFactory .getLogger(LogInController.class); @Autowired private UserManagerService userManagerService; @Autowired private MessageSource messageSource; //error message if the user cannot logIn // @Value("${login.user.fail}") // private String failLogInInfo; /** * This method display the login page * * @param BindingResult * * @param @ModelAttribute * * @return ModelAndView * * */ @RequestMapping(value = "/", method = RequestMethod.GET) public ModelAndView mString(@ModelAttribute Person person, BindingResult result) { ModelAndView mav = new ModelAndView(); mav.setViewName("login"); return mav; } /** * This method is called once the user has submitted the logIn form. * <p> It validates and directs the user to the relevant page once validation is completed. * * @param BindingResult * * @param @ModelAttribute * * @return ModelAndView * */ @RequestMapping(method = RequestMethod.POST, value = "/home") public ModelAndView validate(@ModelAttribute Person person, BindingResult result,HttpServletRequest request) { ModelAndView mav = new ModelAndView(); String userName = person.getFirstName(); String password = person.getPassword(); boolean isUserValid = false; if (userName != null && password != null) { isUserValid = userManagerService.validateUserLogin(userName, password); } if (!isUserValid) { mav.addObject("failLog",messageSource.getMessage("login.user.fail", new String[]{"john","john"}, request.getLocale()) ); } mav.addObject("isUserValid", isUserValid); mav.setViewName("login"); return mav; } }

My login.jsp is found in the following folder :

market\src\main\webapp\WEB-INF\views\

Any ideas why i get the page not found error?

i should get the page login.jsp instead

thanks in advance.