Jack Tauson

Norm Radder wrote:A comment on the code in the loop
The test: if (i > 0) {    on line 6
with   } else {  on line 18 is slightly confusing.
The else block is for the first time around the loop when i == 0
the if block is for the rest of the iterations.
This would make more sense to me:
  if(i == 0) {  // first time    ...   }else { '   // rest of the values      ...   }

Yeah, makes sense. Thanks for your suggestion.

Carey Brown wrote:You have several duplicate lines in the two blocks of code that could be moved after the blocks. This follows the "DRY" (Don't Repeat Yourself) principal.

Right. I guess I can leave testCases.setSelectedCellValue...  inside the loop and take out other things.

Turned out it was an Hibernate object creation issue because of the saveOrUpdate method used behind the scenes. Had to move object creation step inside the loop to get it fixed like this:

for (int i = 0; i < testItems.size(); i++) {  String testcase = testItems.get(i).getTestcase();  System.out.println("print testcase inside loop");  System.out.println(testcase);    TestMappedCases testCases = new TestMappedCases();    if (i > 0) {    Integer updatedCellValue = ((cellValue + i));    System.out.println("Inside i > 0 loop: Insert a record for testcase " + testcase + "celValue " +      updatedCellValue + " and selectedTestVal " + selectedTestVal);    System.out.println("Updated Cell Value");    System.out.println(updatedCellValue);    testCases.setTestedLineupID(selectedTestVal);    testCases.setSelectedCellValue(updatedCellValue);    testCases.setTestedCases(testcase);    testMgr.saveTestCases(testCases);  } else {    System.out.println("Inside else block: Insert a record for testcase " + testcase + "celValue " + cellValue +      " and selectedTestVal " + selectedTestVal);    System.out.println("Cell Value");    System.out.println(cellValue);    testCases.setTestedLineupID(selectedTestVal);    testCases.setSelectedCellValue(cellValue);    testCases.setTestedCases(testcase);    testMgr.saveTestCases(testCases);  }
[Don't repeat the preceding post if it's not adding new information.]

Ron McLeod wrote:Since you don't use the index for anything else, you could simplify the code a bit by using an enhanced for loop:for (TestItem testItem : testItems) {    String testcase = testItem.getTestcase();    System.out.println("print String testcase inside loop");    System.out.println(testcase); }

Thanks. I started using it but then I ended up using the index again as shown below and running into an issue related to the for loop I believe. Please find my code below. Haven't included other details as I'm suspecting it's a for loop issue.
TestMappedCasesManager testMgr = (TestMappedCasesManager) webctx  .getBean("testMappedCasesManager"); TestMappedCases testCases = new TestMappedCases(); List < TestItem > testItems =  TestFileUtils.getTestFileItemsByLaneNumberRange(    testFileId, startingNumber, endingNumber); System.out.println("testItems size is: " + testItems.size()); for (int i = 0; i < testItems.size(); i++) {  String testcase = testItems.get(i).getTestcase();  System.out.println("print testcase inside loop");  System.out.println(testcase);    if (i > 0) {    Integer updatedCellValue = ((cellValue + i));    System.out.println("Inside i > 0 loop: Insert a record for testcase " + testcase + "celValue " +      updatedCellValue + " and selectedTestVal " + selectedTestVal);    System.out.println("Updated Cell Value");    System.out.println(updatedCellValue);    testCases.setTestedLineupID(selectedTestVal);    testCases.setSelectedCellValue(updatedCellValue);    testCases.setTestedCases(testcase);    testMgr.saveTestCases(testCases);  } else {    System.out.println("Inside else block: Insert a record for testcase " + testcase + "celValue " + cellValue +      " and selectedTestVal " + selectedTestVal);    System.out.println("Cell Value");    System.out.println(cellValue);    testCases.setTestedLineupID(selectedTestVal);    testCases.setSelectedCellValue(cellValue);    testCases.setTestedCases(testcase);    testMgr.saveTestCases(testCases);  } }

The print statements for above code are coming out like this:
[INFO] testItems size is: 4 [INFO] print testcase inside loop [INFO] ABC1234 [INFO] Inside else block: Insert a record for testcase ABC1234    celValue 27 and selectedTestVal 45555 [INFO] Cell Value [INFO] 27 [INFO] print testcase inside loop [INFO] DEF1 [INFO] Inside i > 0 loop: Insert a record for testcase DEF1      celValue 28 and selectedTestVal 45555 [INFO] Updated Cell Value [INFO] 28 [INFO] print testcase inside loop [INFO] HIJ12345 [INFO] Inside i > 0 loop: Insert a record for testcase HIJ12345    celValue 29 and selectedTestVal 45555 [INFO] Updated Cell Value [INFO] 29 [INFO] print testcase inside loop [INFO] KLM45677 [INFO] Inside i > 0 loop: Insert a record for testcase KLM45677    celValue 30 and selectedTestVal 45555 [INFO] Updated Cell Value [INFO] 30


I have a table with three columns  - selectedTestVal, cellValue and testcase

With above code, I'm trying to save the values - which should put 4 records in the table. However, I'm only seeing the last value getting inserted in the table which is :

testCase = KLM45677  , cellValue = 30 and selectedTestVal = 45555

Do you see anything wrong in my for loop above?

In addition to above last record, I was also expecting following records in my database table:

testCase | cellValue | selectedTestVal ABC1234      27               45555 DEF1             28               45555 HIJ12345     29   45555

Ron McLeod wrote:You didn't provide a lot of details, but assuming that TestFileUtils#getTestFileItemsByLaneNumberRange returns a collection of Java objects, I don't understand why you would want to transform them to a JSON representation, and then try to figure out how to reduce it.

If you had a class like this which held the test results:record TestItem(    boolean readOnly,    String testFileItemId,    boolean testFileItemId_mod,    int testFileId,    boolean testFileId_mod,    String testcase) { }
and TestFileUtils#getTestFileItemsByLaneNumberRange returned a collection of that type, then you could get a list of testcases doing something like this:List<TestItem> testItems =    TestFileUtils.getTestFileItemsByLaneNumberRange(        testFileId, startingNumber, endingNumber); List<String> testCases = testItems.stream()    .map(TestItem::testcase)    .map(String::trim)    .collect(Collectors.toList());

Thanks. Yes, you are right. I don't need it to convert to JSON here. What I ended up doing is the following:

List<TestItem> testItems =    TestFileUtils.getTestFileItemsByLaneNumberRange(        testFileId, startingNumber, endingNumber); for (int i = 0 ; i <  testItems.size() ; i++){  String testcase = testItems.get(i).getTestcase(); System.out.println("print String testcase inside loop"); System.out.println(testcase); }

I'm using jackson ObjectMapper (import com.fasterxml.jackson.databind.ObjectMapper;) like this in my class:


ObjectMapper objectMapper = new ObjectMapper(); String testCases = ""; try { testCases = objectMapper.writeValueAsString(TestFileUtils .getTestFileItemsByLaneNumberRange(testFileId, startingNumber, endingNumber)); } catch (JsonProcessingException e) { e.printStackTrace(); } System.out.println("Test Cases"); System.out.println(testCases);
And above print statement is giving me the following JSON result back:

[  {    "readOnly": false,    "testFileItemId": 4600376,    "testFileItemId_mod": false,    "testFileId": 1001,    "testFileId_mod": false,    "testcase": "ABC1234    "    },  {    "readOnly": false,    "testFileItemId": 4600377,    "testFileItemId_mod": false,    "testFileId": 1001,    "testFileId_mod": false,    "testcase": "DEF234     "  },  {    "readOnly": false,    "testFileItemId": 4600378,    "testFileItemId_mod": false,    "testFileId": 1001,    "testFileId_mod": false,    "testcase": "GHIJ4567    "    } ]


I just want to retrieve the values of testCase (ABC1234,DEF234 and GHIJ4567) one by one and wondering how should I be able to get these value from the JSON? Should I
use something different than objectMapper.writeValueAsString to not generate JSON and hande it in different way?

Piet Souris wrote:Maybe you can use a Textblock.format? See for instance baeldung textblock. That is a great help when it comes to using Json.

Thanks. I'm not concerned about building JSON or HTML(or maybe I should?), it's just that how can I use all the four values of the arrays in one string. I am sure that there are only 4 values and I can make the string as shared before - like this:

result = "<div class=\"parent\"> <div class=\"heading\">"+arr[0]+"</div> <div class=\"heading\">"+arr[1]+"</div></div><div class=\"parent\"> <div class=\"resultname\">"+arr[2]+"</div> <div class=\"resultname\">"+arr[3]+"</div></div>";

But I am not sure if above approach is the best approach to use since I'm hardcoding array values.

Carey Brown wrote:String[] arr = str.substring(1).split("\\|") ;        for (String s1 : arr) {            System.out.println("Value "+s1);        }

Question:

What would be an efficient way to build a result string like the following:

result = "<div class=\"parent\"> <div class=\"heading\">"+arr[0]+"</div> <div class=\"heading\">"+arr[1]+"</div></div><div class=\"parent\"> <div class=\"resultname\">"+arr[2]+"</div> <div class=\"resultname\">"+arr[3]+"</div></div>";

Since I know there are 4 values, using above approach works but I think that's not the best way to do it?

If I put it like this - it's not gonna work:

for (int i = 0 ; i < arr.length ; i++) { result = "<div class=\"parent\"> <div class=\"heading\">"+arr[i]+"</div> <div class=\"heading\">"+arr[i]+"</div></div><div class=\"parent\"> <div class=\"resultname\">"+arr[i]+"</div> <div class=\"resultname\">"+arr[i]+"</div></div>"; }

Carey Brown wrote:String[] arr = str.substring(1).split("\\|") ;        for (String s1 : arr) {            System.out.println("Value "+s1);        }

Thanks or I could use the following inside the for loop:

for (String s1 : arr) { if(s1.length() > 0) { System.out.println("Value "+s1+" and its length is "+s1.length()); } }

Jack Tauson wrote:

Carey Brown wrote:Split() is the typical way to do this so if an array is not what you're looking for then what did you have in mind?

If I'm using the split like this:

String[] arr = str.split("|") ; for (String s1 : arr) { System.out.println(s1); }

It's giving me the following output:

| 5 5 5 | 7 7 7 | A B | C D

I'm mainly looking for values 555,777 ,AB and CD together and not as separate values. Also, I'm not looking for "|" in the output as shown above. Am I doing anything wrong here?

Edit:
Why "|" is showing in the output. Just to clarify more, I'm mainly interested in the values 555, 777, AB and CD only.

I needed to do this:

String[] arr = str.split("\\|") ; for (String s1 : arr) { System.out.println("Value "+s1); }

However, it's still printing a blank value in the output:
Value Value 555 Value 777 Value AB Value CD

Carey Brown wrote:Split() is the typical way to do this so if an array is not what you're looking for then what did you have in mind?

If I'm using the split like this:

String[] arr = str.split("|") ; for (String s1 : arr) { System.out.println(s1); }

It's giving me the following output:

| 5 5 5 | 7 7 7 | A B | C D

I'm mainly looking for values 555,777 ,AB and CD together and not as separate values. Also, I'm not looking for "|" in the output as shown above. Am I doing anything wrong here?

Edit:
Why "|" is showing in the output. Just to clarify more, I'm mainly interested in the values 555, 777, AB and CD only.

I have a string like this:

String str = "|555|777|AB|CD";

I want to extract the contents -  555,777,AB and CD.


I tried using String[] arr = str.split("|") ; but that splits everything into an array. Is there a regex way I should consider and what would it be as the online regex things I've found are very confusing.

I noticed a spring controller defined like this in my code:

import org.springframework.stereotype.Controller; import org.springframework.web.bind.annotation.RequestMapping; /** * Add or edit a car foreign type manual form */ @Controller @RequestMapping("/carfortypemanual") public class CarForeignTypeManualOrderController extends ManualTypeOrderControllerBase { public CarForeignTypeManualOrderController() { formJspName = "carfortypemanual"; } }

so carfortypemanual is a jsp page which exists with a form defined inside it but I'm trying to understand what does "formJspName" here do here? I don't see any GET or POST method defined here.

Vasanth Selvamani wrote:Prefix v?

Sorry, I didn't understand what you were trying to say.

Trying to get rid of struts related spring modules /validator stuff from my code as we are no longer using struts. I'm seeing the following defined in my JSP

I have spring-validator.jsp which contains the following:

<%@ taglib uri="http://www.springmodules.org/tags/commons-validator" prefix="v"%> <v:javascript dynamicJavascript="false" staticJavascript="true" />

And then in one of my JSP page, I see it being called like this:

<v:javascript formName="orderForm" dynamicJavascript="true" staticJavascript="false" cdata="true" /> <script type="text/javascript" src="<c:url value='/scripts/spring-validator.jsp'/>"></script>


1. What does defining the prefix "v" and "javascript" mean in the above code?

2. What does dynamicJavascript = "true" means?


So far whenever I've seen the usage of springframework tags, which are defined like this:
<%@ taglib uri="http://www.springframework.org/tags/form" prefix="form"%>

I've used that it's being used in the form using prefix "form" prefix, which was easy to understand. But the spring-validator stuff is something I'm trying to understand such that I can get rid of it and what I need to do to get it replaced.