Kelvin Okornoe

Attached is a snippet of the Json data and how the data is formatted in the textview.

I need help on how to do it correctly

data class NewsData (    val author: String, val title: String,    val url: String, val publishedAt: String )

[ private val moshi = Moshi.Builder()    .add(KotlinJsonAdapterFactory())    .build() private val retrofit = Retrofit.Builder()    .addConverterFactory(MoshiConverterFactory.create())    .baseUrl(BASE_URL)    .build() interface NewsApiService {    @GET("top-headlines?country=us&apiKey=${API_KEY}")    fun getProperties():            Call<NewsData> } object NewsApi {    val retrofitService : NewsApiService by lazy {        retrofit.create(NewsApiService::class.java) } }

/** * The [ViewModel] that is attached to the [NewsHomeFragment]. */ class NewsViewModel : ViewModel() {    // The internal MutableLiveData String that stores the most recent response    private val _response = MutableLiveData<String>()    // The external immutable LiveData for the response String    val response: LiveData<String>        get() = _response    /**     * Call getNewsData() on init so we can display status immediately.     */    init {        getNewsData()    }    /**     * Sets the value of the status LiveData to the Mars API status.     */    private fun getNewsData() {        _response.value = NewsApi.retrofitService.getProperties().enqueue(            object: Callback<NewsData> {                override fun onFailure(call: Call<NewsData>, t: Throwable) {                    _response.value = "Failure: " + t.message                }                override fun onResponse(call: Call<NewsData>, response: Response<NewsData>) {                    _response.value = response.body().toString()                }            }).toString()    } }

Thank you for the suggestion so far, I have noted them.
Am still working on the program and I will be posting it here for more reviews.
Thank you.

Am currently working on a project from JetBrains Academy which requires me to read a file containing a matrix and reduce it into reduced row echelon form.
The project requirement can be found here https://hyperskill.org/projects/40/stages/211/implement

This is my current implementation, it only reads the file into two dimensional integer array.

Any recommendations to make the current implementation robust will be appreciated.

package solver; import java.io.BufferedReader; import java.io.File; import java.io.FileReader; import java.io.IOException; public class Matrix {    File file = new File("../Linear Equations Solver/Linear Equations Solver/task/src/solver/in.txt");    //reads the content of a file and converts it into a matrix.    public int[][] convertFileToMatrix() throws IOException {        int[][] matrix;        try (BufferedReader br = new BufferedReader(new FileReader(file))) {            int size = Integer.parseInt(br.readLine());            matrix = new int[size][];            for (int z = 0; z < size; z++) {                String[] line = br.readLine().split("\\s");                int[] arr = new int[line.length];                for (int i = 0; i < line.length; i++) {                    arr[i] = Integer.parseInt(line[i]);                }                matrix[z] = arr;            }        }        return matrix;    } }

This how the content of the file looks like
The first line determines the row length of the matrix
3
1 1 2 9
2 4 -3 1
3 6 -5 0

Thank you.

I am adding a method to count the number of syllables in a word.
This is my implementation so far.

//calculates number of syllables in a file    /**     * 1. Count the number of vowels in the word.     * 2. Do not count double-vowels.     *    (e.g "rain" had 2 vowels but is only 1 syllable)     * 3. If the last letter in the word is 'e' do not count it as a vowel     *    (e.g "side" is 1 syllable)     * 4. If at the end it turns out that the word contains 0 vowels,     *    then consider this word as 1-syllable.     */    private static void numberOfSyllables () throws IOException {        String vowels = "aeiouy";        BufferedWriter fileWriter = new BufferedWriter(new FileWriter("/moocs/jetbrains/Readability Score/debug_word_vowel_count.txt"));        String[] words = str.split("\\s+");        for (String word : words) {            StringBuilder stringBuilder = new StringBuilder();            String s = "";            for (int i = 0; i < word.length(); i++) {                int val = vowels.indexOf(word.charAt(i));                if (val != -1) {                    String cha = String.valueOf(word.charAt(i));                    s =  stringBuilder.append(cha).toString();                }            }            long count = s.chars().distinct().count();            if (word.charAt(word.length() -1) == 'e') {               count =  count -1;            }            fileWriter.write(word + "     " + count + "   " + s);            fileWriter.newLine();        }        fileWriter.close();    }

I need a review to make it better and more rigorous.
Thank you

Liutauras Vilda wrote:For the moment let's assume your calculations are correct.

Do you think would be better if you'd create a class similar reading to TextStatistics, to which you could pass potentially a text or file and be able to:

TextStatistics myFavouriteBook = new TextStatistics(text);
or
TextStatistics myFavouriteBook = TextStatistics.parse(text); // or similar System.out.println("Words: " + myFavouriteBook.getNumOfWords()); System.out.println("Sentences: " + myFavouriteBook.getNumOfSentences());

Yes! I will do that.
Thank you

Current state of the code.

package readability; import java.io.IOException; import java.nio.file.Files; import java.nio.file.Paths; public class Main {    static String str = "";    static String path = "/moocs/jetbrains/Readability Score/test1.txt";    public static void main(String[] args) throws IOException {        //str = readFile(args[0]); // read file name from console;        str = readFile(path); // read file from a directory.        printAll();    }    private static void printAll() {        System.out.println("Words: " + numberOfWords());        System.out.println("Sentences: " + numberOfSentences());        System.out.println("Characters: " + numberOfCharacters());        System.out.print("The score is: ");        System.out.format("%.2f", calculateReadableScore());        System.out.println();        System.out.println("This text should be understood by " + readableAge((int) Math.ceil(calculateReadableScore())) + " year olds.");    }    //reads the file    private static String readFile(String fileName) throws IOException {        return new String(Files.readAllBytes(Paths.get(fileName)));    }    //calculates the number of sentences in the file    private static int numberOfSentences()  {        String[] s = str.trim().split("[!?.]+");        return s.length;    }    //calculates the number of words in the file    private static int numberOfWords(){        String[] words = str.split("\\s+");        return words.length;    }    //calculates the number characters in the file    private static int numberOfCharacters()  {        String words = str.replaceAll("\\s+", "");        return words.length();    }    //calculates the score of the text.    private static float calculateReadableScore() {        final float constVal4_71 = 4.71f;        final float constVal0_5 = 0.5f;        final float constVal321_43 = 21.43f;        float numCharDivideNumWords;        float numWordsDivideNumSentence;        numCharDivideNumWords = (float) numberOfCharacters() / numberOfWords();        numWordsDivideNumSentence = (float) numberOfWords() / numberOfSentences();        return (constVal4_71 * numCharDivideNumWords) + ((constVal0_5 * numWordsDivideNumSentence) - constVal321_43);    }    //This method determines which age range will be able to read the text.    private static String readableAge(int score) {        switch (score) {            case 1:                return "5-6";            case 2:                return "6-7";            case 3:                return "7-9";            case 4:                return "9-10";            case 5:                return "10-11";            case 6:                return "11-12";            case 7:                return "12-13";            case 8:                return "13-14";            case 9:                return "14-15";            case 10:                return "15-16";            case 11:                return "16-17";            case 12:                return "17-18";            case 13:                return "18-24";            case 14:                return "24+";            default:                return "Unknown";        }    } }

Liutauras Vilda wrote:

Kelvin Okornoe wrote:Am I allowed to reference the code from github? So I don't keep re-posting the code here.

You are, just not all people will be interested to click on the link and go "somewhere". And to keep discussion and the tangible asset on the forum might be useful for future readers, while your Git repository technically can get demolished at any given point in time.

I understand. Thank you,

Liutauras Vilda wrote:1. coderanch is a forum! Cozy one.
2. coderanchisaforum!Cozyone.

When you split by ! you get array with elements:
1. [coderanch is a forum] [Cozy one.]
2. [coderanchisaforum] [Cozyone.]

So what do you achieve by removing all the spaces?

Only the first and last spaces might affect the result, so really trim() (removes leading and trailing spaces) might be the wise thing to do right after reading the file.

Okay, I think I get the idea.

Thank you

Am I allowed to reference the code from github? So I don't keep re-posting the code here.

Liutauras Vilda wrote:

Kelvin Okornoe wrote:Current Implementation

As Campbell asked, what do you achieve by removing all the spaces before counting sentences? Perhaps trim() would be enough?

I am not getting the understanding. Please throw more light

Liutauras Vilda wrote:

private static int numberOfCharacters()  {    String words = str.replaceAll("\\s+", "");    return words.toCharArray().length; }

This bit. String has length() method. So perhaps you don't need to convert to char array too.

Yes!, That will be more efficient.
Thank you

Current Implementation. Bug fixed!

package readability; import java.io.IOException; import java.nio.file.Files; import java.nio.file.Paths; public class Main {    static String str = "";    static String path = "/moocs/jetbrains/Readability Score/test2.txt";    public static void main(String[] args) throws IOException {        //str = readFile(args[0]); // read file name from console;        str = readFile(path); // read file from a directory.        printAll();    }    private static void printAll() {        System.out.println("Words: " + numberOfWords());        System.out.println("Sentences: " + numberOfSentences());        System.out.println("Characters: " + numberOfCharacters());        System.out.print("The score is: ");        System.out.format("%.2f", calculateReadableScore());        System.out.println();        System.out.println("This text should be understood by " + readableAge((int) Math.ceil(calculateReadableScore())) + " year olds.");    }    //reads the file    private static String readFile(String fileName) throws IOException {        return new String(Files.readAllBytes(Paths.get(fileName)));    }    //calculates the number of sentences in the file    private static int numberOfSentences()  {        String[] s = str.replaceAll("\\s+", "").split("[!?.]+");        return s.length;    }    //calculates the number of words in the file    private static int numberOfWords(){        String[] words = str.split("\\s+");        return words.length;    }    //calculates the number characters in the file    private static int numberOfCharacters()  {        String words = str.replaceAll("\\s+", "");        return words.toCharArray().length;    }    //calculates the score of the text.    private static float calculateReadableScore() {        final float constVal4_71 = 4.71f;        final float constVal0_5 = 0.5f;        final float constVal321_43 = 21.43f;        float numCharDivideNumWords;        float numWordsDivideNumSentence;        numCharDivideNumWords = (float) numberOfCharacters() / numberOfWords();        numWordsDivideNumSentence = (float) numberOfWords() / numberOfSentences();        return (constVal4_71 * numCharDivideNumWords) + ((constVal0_5 * numWordsDivideNumSentence) - constVal321_43);    }    //This method determines which age range will be able to read the text.    private static String readableAge(int score) {        switch (score) {            case 1:                return "5-6";            case 2:                return "6-7";            case 3:                return "7-9";            case 4:                return "9-10";            case 5:                return "10-11";            case 6:                return "11-12";            case 7:                return "12-13";            case 8:                return "13-14";            case 9:                return "14-15";            case 10:                return "15-16";            case 11:                return "16-17";            case 12:                return "17-18";            case 13:                return "18-24";            case 14:                return "24+";            default:                return "Unknown";        }    } }

Liutauras Vilda wrote:@OP

Run through your sentences counting this nonsensical: "Done! A boy with toy. Really? Yes... Oh boy!"

I counted 5 sentences. How many you got?

haha!, I got 7 from my code...It should be five.

The bug is probably coming from the regexp.

Thank you soo much, I will fix it.

Campbell Ritchie wrote:Afraid I don't like the technique of getting rid of all the spaces. There must be a simpler way to count sentences than that. Much simpler.
Similarly I don't like that way of counting printing characters. The definition of line end characters given in your first post is incorrect, and won't work on a Windows® machine.

Any ideas on how to count the sentences? Please.