Steven Greenbaum

I would like to write a class that replaces google sheets as a calculation engine.
Presently formulas and data sre passed to google sheets via API and the result returned also via API.
I would like to do all the calculations in java code in an attempt to speed up execution.

Is there a way to avoid calculating every cell sequentially which would probable be too slow.

I am working with a foreign group of java programmers. I am new to java projects

Their IDE is Eclipse and they seem to be using BitBucket as a source code repository. in Bitbucket I see that there are recent commits.
These commits Im guessing are going to gitHub

What is the relationship among these tools

Thanks

I will try a hash map. Haver never done that before.

Modules have a unique id

Adding and deleting is most important.
These will be small groups so speed is not an issue.
Sorting not important

I have two classes
Module & Modules.
Modules is a group of 'module'

It is very confusing how to structure Modules after googling collections, lists, and array lists and such.

There will never be a different type of object in Modules

Should I structure Modules as an array list or some sort of collection?

Thank you all your excellent and detailed responses. I am glad I have found the Moose community.

I am working with a group of programmers in a foreign country. I sent them my project before adding the error checking. They have implemented it themselves and I have asked them to send it back when done because there will be may more use cases to add.
I will ruminate on the many comments you and others have provided and proceed from there.

Not sure if I should start a new thread.

This is my most complicated class. I can't think of anything that obvious that would cause an error.
In my test program I set the input periods to -1. This caused a NegativeArraySizeException so I could catch that.

How would I catch a general error where i don't know the exception type in advance?

Also I would like to throw an exception if periods < 3 or greater than 120.

How would I do that?
Tx


package onplanpersonnelmodule; import java.time.LocalDate; public class  OnPlanPersonnelModule  {        // 19 September 2017        private int periods;        private final LocalDate timeSeriesDateStart;        private long totalSalaryThisPeriod;        private int totalHeadCountThisPeriod;        private final int  employeeSize;        private final Employees employees;        private final int[][] headCount;        private final int [] totalHeadCount;        private final long[][] processedSalary;        private final Salary salary;        private final long [] totalSalary;        public OnPlanPersonnelModule(int p, LocalDate d, Employees e, Salary s) {            periods=p;            timeSeriesDateStart=d;            employees=e;            salary=s;            employeeSize=employees.getSize();            totalSalary = new long [periods];            headCount =new int [periods][employeeSize];            totalHeadCount = new int [periods];            processedSalary=new long [periods][employeeSize];        }        public int getHeadCountElement(int periodIndex,int employeeIndex) {            return this.headCount[periodIndex][employeeIndex];        }        public int getTotalHeadCountElement(int periodIndex) {            return this.totalHeadCount[periodIndex];        }        public long getProcessedSalaryElement(int periodIndex,int employeeIndex) {            return this.processedSalary[periodIndex][employeeIndex];        }        public long getTotalSalaryElement(int periodIndex) {            return this.totalSalary[periodIndex];        }        public  void ProcessEmployees(Employees employees){                        TimeSeries timeSeries = new TimeSeries(periods, timeSeriesDateStart);                        for ( int t=0; t < periods; t++ ) {                                 totalSalaryThisPeriod=0;                 totalHeadCountThisPeriod=0;                                for ( int j=0; j < employeeSize; j++ ) {                    boolean isbefore = employees.getEmployee(j).getDateStart().isBefore( timeSeries.getTimeSeriesElement(t,periods,timeSeriesDateStart));                    boolean isafter= employees.getEmployee(j).getDateEnd().isAfter( timeSeries.getTimeSeriesElement(t,periods,timeSeriesDateStart));                                      long thisEmployeeSalary=salary.getSalaryElement(t,j);                    if( isbefore &&  isafter){                        this.headCount[t][j]=1;                        this.processedSalary[t][j]=thisEmployeeSalary;                        totalSalaryThisPeriod = totalSalaryThisPeriod + thisEmployeeSalary;                        this.totalHeadCountThisPeriod = totalHeadCountThisPeriod + 1;}                        else {                        this.headCount[t][j]=0;                        this.processedSalary[t][j]=0;                        }                }                this.totalSalary[t]=totalSalaryThisPeriod;                this.totalHeadCount[t]=totalHeadCountThisPeriod;                            }              }         }  

Aha - so it's nipped in the bud

In response to Stephan
Wouldn’t an integer be of the wrong type?

In the set method The only things I could see that could go wrong would be null input or incorrect type

Do I catch just these exceptions or something more general.

I am not sure how or whether to write a try/catch for get. What is recommended?

Thank you


public void setDepartment ( String department ) {        this.department = department;    }    public String getDepartment() {        return this.department;    }

Knute thank you very much for your help. There were a bunch  more errors in the code but with  your push in the right direction I was able to get them sorted out.

Below is my final code

package onplanusermodule; import java.time.LocalDate; public class  OnPlanUserModule  {        private int periods;        private LocalDate timeSeriesDateStart;        private long totalSalaryThisPeriod;        private int totalHeadCountThisPeriod;        private int employeeSize;        private final Employees employees;        private final int[][] headCount;        private final int [] totalHeadCount;        private final long[][] processedSalary;        private final Salary salary;        private final long [] totalSalary;        public OnPlanUserModule(int p, LocalDate d, Employees e, Salary s) {            periods=p;            timeSeriesDateStart=d;            employees=e;            salary=s;            employeeSize=e.getSize();            totalSalary = new long [p];            headCount =new int [p][employeeSize];            totalHeadCount = new int [p];            processedSalary=new long [p][employeeSize];        }        public void setPeriods ( int periods ) {            this.periods =periods;        }        public int getPeriods (  ) {            return this.periods;        }        public int getHeadCountElement(int periodIndex,int employeeIndex) {            return this.headCount[periodIndex][employeeIndex];        }        public int getTotalHeadCountElement(int periodIndex) {            return this.totalHeadCount[periodIndex];        }        public long getProcessedSalaryElement(int periodIndex,int employeeIndex) {            return this.processedSalary[periodIndex][employeeIndex];        }        public long getTotalSalaryElement(int periodIndex) {            return this.totalSalary[periodIndex];        }        public  void ProcessEmployees(Employees employees){                        TimeSeries timeSeries = new TimeSeries(periods, timeSeriesDateStart);                        //Salary salary=new Salary(periods, employeeSize);                        for ( int t=0; t < periods; t++ ) {                                 totalSalaryThisPeriod=0;                 totalHeadCountThisPeriod=0;                                for ( int j=0; j < employeeSize; j++ ) {                    boolean isbefore = employees.getEmployee(j).getDateStart().isBefore(  timeSeries.getTimeSeriesElement(t,periods,timeSeriesDateStart));                    boolean isafter= employees.getEmployee(j).getDateEnd().isAfter(timeSeries.getTimeSeriesElement(t,periods,timeSeriesDateStart));                                      long thisEmployeeSalary=salary.getSalaryElement(t,j);                    if( isbefore &&  isafter){                        this.headCount[t][j]=1;                        this.processedSalary[t][j]=thisEmployeeSalary;                        totalSalaryThisPeriod = totalSalaryThisPeriod + thisEmployeeSalary;                        this.totalHeadCountThisPeriod = totalHeadCountThisPeriod + 1;                        }                        else                        {                        this.headCount[t][j]=0;                        this.processedSalary[t][j]=0;                    }                }                this.totalSalary[t]=totalSalaryThisPeriod;                this.totalHeadCount[t]=totalHeadCountThisPeriod;                            }              }         }                                        

and revised test code

/* * To change this license header, choose License Headers in Project Properties. * To change this template file, choose Tools | Templates * and open the template in the editor. */ package onplanusermodule; import java.time.LocalDate; import org.junit.After; import org.junit.AfterClass; import org.junit.Before; import org.junit.BeforeClass; import org.junit.Test; import static org.junit.Assert.*; /** * * @author User */ public class OnPlanUserModuleTest {        public OnPlanUserModuleTest() {    }        @BeforeClass    public static void setUpClass() {    }        @AfterClass    public static void tearDownClass() {    }        @Before    public void setUp() {    }        @After    public void tearDown() {    }        @Test    public void testProcessEmployees() {        int periods = 5;        int employeeSize;                LocalDate timeSeriesDateStart = LocalDate.parse("2018-01-01");        Employee employee1 = new Employee();        employee1.setId(1);        employee1.setFirstName("Robert");        employee1.setLastName("Lee");        employee1.setDateStart(LocalDate.parse("2018-01-15"));        employee1.setDateEnd(LocalDate.parse("2018-03-15"));                Employee employee2 = new Employee();        employee2.setId(2);        employee2.setFirstName("Sarah");        employee2.setLastName("Frost");        employee2.setDateStart(LocalDate.parse("2018-02-15"));        employee2.setDateEnd(LocalDate.parse("2018-04-15"));                      Employee employee3 = new Employee();        employee3.setId(3);        employee3.setFirstName("Alice");        employee3.setLastName("Brown");        employee3.setDateStart(LocalDate.parse("2018-03-15"));        employee3.setDateEnd(LocalDate.parse("2018-05-15"));                        Employees employees;        employees = new Employees();        employees.add(employee1);        employees.add(employee2);        employees.add(employee3);                employeeSize=employees.getSize();        Salary salary = new Salary(periods,employeeSize);        salary.setSalaryElement(0,0, 1000);        salary.setSalaryElement(1,0, 1000);        salary.setSalaryElement(2,0, 1000);        salary.setSalaryElement(3,0, 1000);        salary.setSalaryElement(4,0, 1000);                salary.setSalaryElement(0,1, 1500);        salary.setSalaryElement(1,1, 1500);        salary.setSalaryElement(2,1, 1500);        salary.setSalaryElement(3,1, 1500);        salary.setSalaryElement(4,1, 1500);                salary.setSalaryElement(0,2, 1250);        salary.setSalaryElement(1,2, 1250);        salary.setSalaryElement(2,2, 1250);        salary.setSalaryElement(3,2, 1250);        salary.setSalaryElement(4,2, 1250);                OnPlanUserModule instance = new OnPlanUserModule(periods,timeSeriesDateStart,employees,salary);        instance.ProcessEmployees(employees);                assertEquals(0,instance.getHeadCountElement(0,0));        assertEquals(1,instance.getHeadCountElement(1,0));        assertEquals(1,instance.getHeadCountElement(2,0));        assertEquals(0,instance.getHeadCountElement(3,0));        assertEquals(0,instance.getHeadCountElement(4,0));                assertEquals(2,employees.getEmployee(1).getId());                assertEquals(0,instance.getHeadCountElement(0,1));        assertEquals(0,instance.getHeadCountElement(1,1));        assertEquals(1,instance.getHeadCountElement(2,1));        assertEquals(1,instance.getHeadCountElement(3,1));        assertEquals(0,instance.getHeadCountElement(4,1));                assertEquals(3,employees.getEmployee(2).getId());                assertEquals(0,instance.getHeadCountElement(0,2));        assertEquals(0,instance.getHeadCountElement(1,2));        assertEquals(0,instance.getHeadCountElement(2,2));        assertEquals(1,instance.getHeadCountElement(3,2));        assertEquals(1,instance.getHeadCountElement(4,2));                        assertEquals(0,instance.getProcessedSalaryElement(0,0));        assertEquals(1000,instance.getProcessedSalaryElement(1,0));        assertEquals(1000,instance.getProcessedSalaryElement(2,0));        assertEquals(0,instance.getProcessedSalaryElement(3,0));        assertEquals(0,instance.getProcessedSalaryElement(4,0));                assertEquals(0,instance.getProcessedSalaryElement(0,1));        assertEquals(0,instance.getProcessedSalaryElement(1,1));        assertEquals(1500,instance.getProcessedSalaryElement(2,1));        assertEquals(1500,instance.getProcessedSalaryElement(3,1));        assertEquals(0,instance.getProcessedSalaryElement(4,1));                assertEquals(0,instance.getProcessedSalaryElement(0,2));        assertEquals(0,instance.getProcessedSalaryElement(1,2));        assertEquals(0,instance.getProcessedSalaryElement(2,2));        assertEquals(1250,instance.getProcessedSalaryElement(3,2));        assertEquals(1250,instance.getProcessedSalaryElement(4,2));                assertEquals(0,instance.getTotalHeadCountElement(0));        assertEquals(1,instance.getTotalHeadCountElement(1));        assertEquals(2,instance.getTotalHeadCountElement(2));        assertEquals(2,instance.getTotalHeadCountElement(3));        assertEquals(1,instance.getTotalHeadCountElement(4));                assertEquals(0,instance.getTotalSalaryElement(0));        assertEquals(1000,instance.getTotalSalaryElement(1));        assertEquals(2500,instance.getTotalSalaryElement(2));        assertEquals(2750,instance.getTotalSalaryElement(3));        assertEquals(1250,instance.getTotalSalaryElement(4));    }   }

added 'this' on lines 74 and 81 but stu=ill same failure
package onplanusermodule; import java.time.LocalDate; public class  OnPlanUserModule  {        private int periods;        private LocalDate timeSeriesDateStart;        private long totalSalaryThisPeriod;        private int totalHeadCountThisPeriod;        private int employeeSize;        private Employees employees;        private final int[][] headCount;        private final int [] totalHeadCount;        private final long[][] salary;        private final long [] totalSalary;        public OnPlanUserModule(int p, LocalDate d, Employees e) {            periods=p;            timeSeriesDateStart=d;            employees=e;            salary =new long [p][e.getSize()];            totalSalary = new long [p];            headCount =new int [p][e.getSize()];            totalHeadCount = new int [p];        }        public void setPeriods ( int periods ) {            this.periods =periods;        }        public int getPeriods (  ) {            return this.periods;        }        /*        public void setTimeSeriesDateStart ( LocalDate timeSeriesDateStart ) {            this.timeSeriesDateStart =timeSeriesDateStart;        }        public LocalDate getTimeSeriesDateStart ( ) {            return this.timeSeriesDateStart;        }        public void setEmployees ( Employees employees ) {            this.employees =employees;        }        */        public int getHeadCountElement(int periodIndex,int employeeIndex) {            return headCount[periodIndex][employeeIndex];        }        public int getTotalHeadCountElement(int periodIndex) {            return totalHeadCount[periodIndex];        }                public  void ProcessEmployees(Employees employees){            // generate time series                          employeeSize=employees.getSize();                        TimeSeries timeSeries = new TimeSeries(periods,timeSeriesDateStart);                        Salary salary=new Salary(periods, employeeSize);                        for ( int t=0; t < periods; t++ ) {                                 totalSalaryThisPeriod=0;                 totalHeadCountThisPeriod=0;                                for ( int j=0; j < employees.getSize(); j++ ) {                    boolean isbefore = employees.getEmployee(j).getDateStart().isBefore(  timeSeries.getTimeSeriesElement(t,periods,timeSeriesDateStart));                    boolean isafter= employees.getEmployee(j).getDateEnd().isAfter(timeSeries.getTimeSeriesElement(t,periods,timeSeriesDateStart));                                      long thisEmployeeSalary=salary.getSalaryElement(t,j);                                        if( isbefore &&  isafter){                        this.headCount[t][j]=1; // set to 1 because employee present before and after                        salary.setSalaryElement(t,j, thisEmployeeSalary);                        // will not be set if correponding headcount = 0                        // a feature could be implemented to set headcount to 0 if salary was 0                        // this would cater to unpaid leave                        totalSalaryThisPeriod = totalSalaryThisPeriod + thisEmployeeSalary;                        this.totalHeadCountThisPeriod = totalHeadCountThisPeriod + 1;                    }else {                        this.headCount[t][j]=0;                        salary.setSalaryElement(t,j,0);                    }                }                                salary.setTotalSalaryElement(t,totalSalaryThisPeriod);                this.totalHeadCount[t]=totalHeadCountThisPeriod;                            }              }         }                                        

Knute Snortum wrote:In your OnPlanUserModule class, in the ProcessEmployees() method, line 45, you are creating a local variable headcount.  Since it's local, it cannot be accessed outside of the method.  To do that you need to either return the value (which means you couldn't return the employees reference) or you need to make headcount a field of OnPlanUserModule and write a getter for this field.

Knute-thank you for responding

Revised code per your comments but still getting same error. So Im still missing something.

package onplanusermodule; import java.time.LocalDate; public class  OnPlanUserModule  {        private int periods;        private LocalDate timeSeriesDateStart;        private long totalSalaryThisPeriod;        private int totalHeadCountThisPeriod;        private int employeeSize;        private Employees employees;        private final int[][] headCount;        private final int [] totalHeadCount;        private final long[][] salary;        private final long [] totalSalary;        public OnPlanUserModule(int p, LocalDate d, Employees e) {            periods=p;            timeSeriesDateStart=d;            employees=e;            salary =new long [p][e.getSize()];            totalSalary = new long [p];            headCount =new int [p][e.getSize()];            totalHeadCount = new int [p];        }        public void setPeriods ( int periods ) {            this.periods =periods;        }        public int getPeriods (  ) {            return this.periods;        }        /*        public void setTimeSeriesDateStart ( LocalDate timeSeriesDateStart ) {            this.timeSeriesDateStart =timeSeriesDateStart;        }        public LocalDate getTimeSeriesDateStart ( ) {            return this.timeSeriesDateStart;        }        public void setEmployees ( Employees employees ) {            this.employees =employees;        }        */        public int getHeadCountElement(int periodIndex,int employeeIndex) {            return headCount[periodIndex][employeeIndex];        }        public int getTotalHeadCountElement(int periodIndex) {            return totalHeadCount[periodIndex];        }                public  void ProcessEmployees(Employees employees){            // generate time series                          employeeSize=employees.getSize();                        TimeSeries timeSeries = new TimeSeries(periods,timeSeriesDateStart);                        Salary salary=new Salary(periods, employeeSize);                        for ( int t=0; t < periods; t++ ) {                                 totalSalaryThisPeriod=0;                 totalHeadCountThisPeriod=0;                                for ( int j=0; j < employees.getSize(); j++ ) {                    boolean isbefore = employees.getEmployee(j).getDateStart().isBefore(  timeSeries.getTimeSeriesElement(t,periods,timeSeriesDateStart));                    boolean isafter= employees.getEmployee(j).getDateEnd().isAfter(timeSeries.getTimeSeriesElement(t,periods,timeSeriesDateStart));                                      long thisEmployeeSalary=salary.getSalaryElement(t,j);                                        if( isbefore &&  isafter){                        headCount[t][j]=1; // set to 1 because employee present before and after                        salary.setSalaryElement(t,j, thisEmployeeSalary);                        // will not be set if correponding headcount = 0                        // a feature could be implemented to set headcount to 0 if salary was 0                        // this would cater to unpaid leave                        totalSalaryThisPeriod = totalSalaryThisPeriod + thisEmployeeSalary;                        totalHeadCountThisPeriod = totalHeadCountThisPeriod + 1;                    }else {                        headCount[t][j]=0;                        salary.setSalaryElement(t,j,0);                    }                }                                salary.setTotalSalaryElement(t,totalSalaryThisPeriod);                totalHeadCount[t]=totalHeadCountThisPeriod;                            }              }         }                                        

I think I see the issue. My OnPlanUserModule class returns emplyees which I am not interested in.

I assumed that the code in lines 60-74 would output values that could be retrieved by my test program. This doesn't seem to be working.

So how do I gain access to the headcount and salary values that are being computed.