Abdallah Taha

Thank you

Campbell Ritchie wrote:

Abdallah Taha wrote:. . . By using my code, if I use the file containing your data I got a average 51.

How did you manage that? The correct average is 60¼. If you use integer arithmetic, that will come to 60

Thanks for all, I found the correct average 60.25 with this :
try (Scanner s= new Scanner(file)) {            while (s.hasNext()){                String data = s.next();                String[] grade = data.split(" ");                for(int i = 0; i < grade.length; i++) {                sum += Integer.parseInt(grade[i]);                numTestScores++;            }        }        System.out.println("the average is = " + ( sum / numTestScores));

I did like this :
try (Scanner s= new Scanner(file)) {            while (s.hasNext()){                String data=s.nextLine();                String grade [] = data.split(",");                sum += s.nextInt();                numTestScores++;            }            average = sum / numTestScores;            System.out.println(average);

Piet Souris wrote:But I would expect a file with content like:
88 74 23 56 ...
How else can I calculate an average?

By using my code, if I use the file containing your data I got a average 51.

Maybe I didn't understand the assignment but I created my file from this sentence "after processing the entire file compute the average grade and return the equivalent letter grade as a char value (A = 90-100, B=80-89, C=70-79, D=60-69, F=0-59)", I think the file will be like this :
A = 90-100
B = 80-89
C = 70-79
D = 60-69
F = 0-59

There is not students name just because I understand from the question "reads a file containing students’ numerical grades–one grade per line." So I don't think that I have to create a student name. Also the sample out show "The average grade is B."

My file looks like this :

A 90-100
B 80-89
C 70-79
D 60-69
F 0-59

Refered to the question which ask to create a file and then one grade per line. Is my file correct?

I'm working on a project that reads a file containing students’ numerical grades–one grade per line. I did create the file.
I'm fine with opening the file but I'm struggling with how to get it to read the average of the first line then continue to all the other ones as well returning the value in the println. I know the result which is the average grade is B.
My program should not assume that I know how many lines of data are in the file.
The letter grade as a char value (A = 90-100,B=80-89,C=70-79,D=60-69,F=0-59). Any suggestion, Thanks.



public static void main(String[] args) throws FileNotFoundException {        String fileName = "StudentsGrade.txt";        File file = new File(fileName);        int numTestScores = 0;        int sum = 0;        int average = 0;        try (Scanner s= new Scanner(file)) {            while (s.hasNext()){                String data=s.nextLine();                String grade [] = data.split(" ");                sum += s.nextInt();                numTestScores++;            }            average = sum / numTestScores;            System.out.println(average);        }        System.out.println("Average is " + sum / numTestScores);    }         }

I'mlooking to do Fred values  42,492.34 minus Sally values 18,230.12.
42,492.34 - 18,230.12
Do I need to do an array two-dimension to do this calculation.

Thank you,
I want to add Fred number to Sally?

Knute Snortum wrote:Well, you're not reading the entire file into an array, just one line at a time.

Are any of the fields in the data quoted?  Like..

10, "Snortum, Knute", 13.32

In the line above, there are only three fields and the second field is "Snortum, Knute".  If you have data like that, I'd suggests using Apache's Commons-CSV.

Yes, it like that.  

Fred Jones 42,492.34 1 A 2,218.23
Sally  O'Brien     48,721.66 2 i       18,230.12

I'm looking at how to process each line of data, print the results for that person, then read the next line. Without reading the entire file into an array before processing the data I need suggestions.
   public static void main(String[] args) throws FileNotFoundException, IOException {        String fileName = "MyFile.csv";        File file = new File(fileName);                try (Scanner s= new Scanner(file)) {            while (s.hasNext()){                String  data = s.next();                String board[] = data.split(",");                 System.out.println(board[0]);            s.close();      }        }      } }

[quoted text deleted]

Thanks I created this method and it works : public static int checkColor(char computerColor[], char userColor[]){                int colorCorrect = 0;                for(int i = 0; i < 4; i++){            if(userColor[i] == computerColor[i] && compPick[i] == userArray [i]){                colorCorrect++;            }                      }return colorCorrect;

Piet Souris wrote:Oke. Then drop the line with continue and do this:
if (guess != -1) {    ... }
The idea is that if the guess element == -1, then we have processed it before (it had an exact match and so we must not gonna count it again)
Do you know about the break statement?
The rason for that is, say:
if guess[] = [3, 1, 2] and solution[] = [1, 5, 1] and if we check the 1 from guess[], then we find immediately a matching 1 at location 0. Now, if we do not break the loop here, we would also find a match at location 2, so that we find 2 matches instead of just 1.

Thank you, I update my program but I'm just little confused on the logic for the exact matches and color count.
public class Master1 {        static char [] compPick = new char [4];                  static char [] userArray = new char [4];    /**     * @param args the command line arguments     */    public static void main(String[] args) {        Scanner s = new Scanner(System.in);        int p =compPick();        System.out.println(Arrays.toString(compPick));                int exactMatches = 0;        do{            System.out.println("Enter guess");             String userGuess = s.next();             for (int a = 0; a<userArray.length; a++)                userArray[a] = userGuess.charAt(a);            exactMatches = checkMatches(userArray);            int colourCorrect = checkColor(compPick, userArray);            System.out.println(exactMatches+" Pegs macthes excatly");                      System.out.println(colourCorrect+" pegs correct color");            if (exactMatches == 4){            System.out.println("Guesses. Lucky! Did you cheat?");                              }        } while(exactMatches != 4);           /**     * Get compPick     * Switch     *     * @return compPick     */        }public static int compPick(){        int computerGuess = 0;        Random r = new Random();        for (int i = 0; i < 4; i++) { computerGuess = r.nextInt(6);        switch(computerGuess) {            case 0: compPick[i] ='B'; break;            case 1: compPick[i] ='R'; break;            case 2: compPick[i] ='G'; break;            case 3: compPick[i] ='Y'; break;            case 4: compPick[i] ='W'; break;            case 5: compPick[i] ='X'; break;        }        }            return computerGuess;    }   /**     * Get to checkColor     * Declare a 2 arrays     * @param compColor     * @param userColor     * @return colorCorrect     */        public static int checkColor(char[] compColor, char[] userColor){        int colorcorrect=0;        for(int i=0; i==4;i++){            if(userColor[0]== compColor[i]){                colorcorrect++;            }        } for(int i =0; i==4;i++){            if(userColor[1]==compColor[i]){                colorcorrect++;            }        } for(int i = 0; i ==4; i++){            if(userColor[2]==compColor[i]){                colorcorrect++;            }        } for(int i = 0; i==4;i++){            if(userColor[3]==compColor[i]){                colorcorrect++;            }            } for(int i =0; i==4;i++){            if(userColor[4]==compColor[i]){                colorcorrect++;            }        } for(int i = 0; i ==4; i++){            if(userColor[5]==compColor[i]){                colorcorrect++;            }        }return colorcorrect;                       /**     * Check matches     * @param userGuess     * @return correct     */          }private static int checkMatches(char[] userGuess ) {        int resultCount=0;              for (int i = 0; i < userArray.length; i++)            if (userGuess[i]==compPick[i])                resultCount++; return resultCount;                   } }

Thank you for your advice. We didn't yet learn about the continue statement in java.