Ramaram Shankar

Thanks for pointing it out. Updated original post.

Thank you Carey.

But, the suggested revised code doesn't print the non-matching lines, which is a requirement.

Below is a simple method which compares contents of two excel files ignoring the line order. Also needs to print the mismatched lines in a logger.
This method is working as expected.
But, one of my peers in their code review mentioned that initializing and using 4 sets for this might not be the best way performance/memory-consumption wise and that the code can be optimized by using lesser number of sets.
I can't figure out how to reduce the number of sets though, to achieve the same functionality.

Any clue/suggestions? Thank you.

Code:

/** Compares contents of two excel files. Ignores line order of the contents.     * @param logger            Logger instance     * @param actualFilePath    Actual xlsx file     * @param baselineFilePath   Baseline xlsx file     * @return                  true if the files match, false otherwise     * @throws Exception     */    public boolean compareTwoXlsxFilesIgnoreLineOrder(Logger logger, String actualFilePath, String baselineFilePath) throws Exception {        File baselineFile = new File(baselineFilePath);        File actualFile = new File(actualFilePath);        FileInputStream baselineFileStream = null;        FileInputStream actualFileStream = null;        XSSFWorkbook baselineWorkbook = null;        XSSFWorkbook actualWorkbook = null;        XSSFExcelExtractor baselineExtractor = null;        XSSFExcelExtractor actualExtractor = null;        try {            if (!baselineFile.exists()) {                logger.severe("FAIL: Could not access the baseline file: " + baselineFile.getPath());                return false;            }            logger.info("baseline file: " + baselineFilePath);            if (!actualFile.exists()) {                logger.severe("FAIL: Could not access the actual file: " + actualFile.getPath());                return false;            }            logger.info("Actual file: " + actualFilePath);            baselineFileStream = new FileInputStream(baselineFile);            actualFileStream = new FileInputStream(actualFile);            baselineWorkbook = new XSSFWorkbook(baselineFileStream);            actualWorkbook = new XSSFWorkbook(actualFileStream);            baselineExtractor = new XSSFExcelExtractor(baselineWorkbook);            actualExtractor = new XSSFExcelExtractor(actualWorkbook);            String baselineFileText = baselineExtractor.getText();            String actualFileText = actualExtractor.getText();            //Split by line break, trim whitespaces and remove empty lines.            Set<String> baselineLinesSet = Arrays.stream(baselineFileText.split("\\r?\\n")).map(String::trim).filter(line -> !line.isEmpty()).collect(Collectors.toSet());            Set<String> actualLinesSet = Arrays.stream(actualFileText.split("\\r?\\n")).map(String::trim).filter(line -> !line.isEmpty()).collect(Collectors.toSet());            Set<String> actualMinusbaseline = new HashSet<>(actualLinesSet);            actualMinusbaseline.removeAll(baselineLinesSet);            logger.fine("Size of actualMinusbaseline: " + actualMinusbaseline.size());            Set<String> baselineMinusActual = new HashSet<>(baselineLinesSet);            baselineMinusActual.removeAll(actualLinesSet);            logger.fine("Size of baselineMinusActual: " + baselineMinusActual.size());            if (!actualMinusbaseline.isEmpty() || !baselineMinusActual.isEmpty()) {                logger.info("FAIL: Lines present in actual file but not in baseline file: " + actualMinusbaseline);                logger.info("FAIL: Lines present in baseline file but not in actual file: " + baselineMinusActual);                logger.info("**************** Mismatch info End *******************");                return false;            } else {                logger.info("VERIFIED: Actual file contents match with the baseline file contents.");                return true;            }        } catch (IOException e) {            logger.severe("Error while comparing files: " + e.getMessage());            throw e;        } finally {            if (baselineExtractor != null) {                baselineExtractor.close();            }            if (actualExtractor != null) {                actualExtractor.close();            }            if (baselineWorkbook != null) {                baselineWorkbook.close();            }            if (actualWorkbook != null) {                actualWorkbook.close();            }            if (baselineFileStream != null) {                baselineFileStream.close();            }            if (actualFileStream != null) {                actualFileStream.close();            }        }    }

Can you tear my code apart with code review comments? Below is a simple method which reads an XLSX file and does some stuff with it. I use FileInputStream and XSSFWorkbook to do the processing. The code block which I am concerned about is the exception handling (I have been told that it's buggy/not ideal).

Note: I am not allowed to use try-with-resources for some reasons.

Code:
/**Process XLSX file. * @param filePath Path of file to process * @throws Exception */ private void processXlsxFile (String filePath) throws IOException {    String xlsxFileContent = "";    FileInputStream fis = null;    XSSFWorkbook workbook = null;    try {        File file = new File(filePath);        fis = new FileInputStream(file);        workbook = new XSSFWorkbook(fis);        XSSFSheet sheet = workbook.getSheetAt(0);        //Do stuff and build 'xlsxFileContent'.    } catch (FileNotFoundException fe) {        logger.error(fe.getMessage());    } catch (IOException ie) {        logger.error(ie.getMessage());    } finally {        try {            if (workbook != null) {                workbook.close();            }        } catch (IOException ex) {            logger.error("Exception while closing XSSFWorkbook: " + ex.getMessage());        }        try {            if (fis != null) {                fis.close();            }        } catch (IOException ex) {            logger.error("Exception while closing FileInputStream: " + ex.getMessage());        }    } }