Martin Thorpe

Ok for anyone who might be interested it appears that I have fixed the problem, although I will have to monitor it over the next couple of days.

What I did in the end was to alter the connector in the Tomcat server.xml file:

so in tomcatRoot\conf\server.xml

I changed this line, which was the default Tomcat shipped with:
<!-- Define an AJP 1.3 Connector on port 8009 --> <Connector port="8009" enableLookups="false" redirectPort="8443" protocol="AJP/1.3"/>

To be this
<!-- Define an AJP 1.3 Connector on port 8009 --> <Connector port="8009" enableLookups="false" redirectPort="8443" protocol="AJP/1.3" maxThreads="50" minSpareThreads="5" maxSpareThreads="20" acceptCount="100" connectionTimeout="2000"/>

So specifying amount of threads and a connectionTimeout seems to sort it. Now it runs up to 16 - 25% when processing but drops straight back to 00 once finished as opposed to be constantly at 25%.

Hope it helps, I'll update if the problem re-occurs.

Thanks for reading
cheers
Martin

Hello I have a problem with Tomcat running at 25% CPU useage. I have identified from the web that this is probably a problem with the ISAPI connector, but have found no information on how to fix this.

I am running Tomcat 5.5.20 on IIS 5, on Windows 2000 server.

I am using the binary connector for windows I have tried 2 versions 1.2.14.0 and the latest 1.2.19.0 but I still have the problem.
Below is my workers file, I wonder if there is anything in here that might help
worker.ajp13w.type=ajp13 worker.ajp13w.host=localhost worker.ajp13w.port=8009 worker.connection_pool_size=10 worker.connection_pool_timeout=600 worker.socket_keepalive=1 worker.socket_timeout=60

Any hints or tips that I might bring this under control would be gratefully appreciated. By the way on my development version, of the same application, there is no problem but this is running through port number direct to Tomcat and not over IIS.

cheers
Martin

Wahey Stefan, thats the doozy (don't know if I spelt that right probably as bad as my spelling of amendment ;-).

The thing is working as expected. Thank you very much for your in-depth help it is much appreciated. Is it always this difficult when you try to do something with Maps and EL?

Is there another way to deal with results of data in the JSP page, such as some kid of resultset output or something as opposed to a map?


Anyhoo, this is the implementation in the end.

The code in the servlet stayed the same as before casting the int of the frameworkID into a string to put into the map
List frameworkList = frameworkManager.getFrameworks(); Map ammendments = new HashMap(); for(int i = 0; i< frameworkList.size(); i++){ Framework framework = (Framework) frameworkList.get(i); String strFrameID = Integer.toString(framework.getFrameworkID()); List myAmends = ammendmentManager.getAmmendByFrame(framework.getFrameworkID()); ammendments.put(strFrameID.trim(), myAmends); } request.setAttribute("frameworks", frameworkList); request.setAttribute("ammendments", ammendments);

And then in my JSP I am creating the string by using the c:set tag as you suggested
<c:forEach var="framework" items="${requestScope.frameworks}"> <p> <c:out value="${framework.frameworkDESC}"/> - <c:out value="${framework.frameworkID}"/><br> <c:set var="frameId"><c:out value="${framework.frameworkID}"/></c:set> <c:forEach var="amendment" items='${requestScope.ammendments[frameId]}'> <strong>the ammend desc</strong><c:out value="${amendment.ammendDESC}"/><br> </c:forEach> </p> </c:forEach>

Stefan again thankyou very much I have certainly learnt a lot in this few day adventure outputting a grouped result. Thank you for sharing your time and your knowledge it really is much appreciated.

cheers
Martin
[ August 11, 2006: Message edited by: Martin Thorpe ]

OK well I got it working using plain old JSP but this kind of defeats the purpose of what I am trying to achieve. I just need to do the same thing as below with JSTL and not referencing the objects and their methods.

<% java.util.Map ammend = (java.util.Map)request.getAttribute("ammendments"); java.util.List frame = (java.util.List)request.getAttribute("frameworks"); for(int i = 0; i< frame.size(); i++){ Framework myFrame = (Framework) frame.get(i); %> <%= myFrame.getFrameworkDESC() %> <% java.util.List myAmmend = (java.util.List)ammend.get(Integer.toString(myFrame.getFrameworkID())); for(int a = 0; a < myAmmend.size(); a++){ Ammendment currAmmend = (Ammendment) myAmmend.get(a); %> <p>---row = <%= a %> desc= <%= currAmmend.getAmmendDESC() %> ++++</p> <% } } %>

Ok I think I am getting close there are just a couple of things that I cannot crack, this should be so simple I can't believe it is now 2.5 days to get this working.

Anyway in my class I now have the following to create the map
List frameworkList = frameworkManager.getFrameworks(); Map ammendments = new HashMap(); for(int i = 0; i< frameworkList.size(); i++){ Framework framework = (Framework) frameworkList.get(i); String strFrameID = Integer.toString(framework.getFrameworkID()); List myAmends = ammendmentManager.getAmmendByFrame(framework.getFrameworkID()); ammendments.put(strFrameID.trim(), myAmends); } request.setAttribute("frameworks", frameworkList); request.setAttribute("ammendments", ammendments);

In my JSP page I can access it like this:
<c:forEach var="am" items="${requestScope.ammendments}"> <c:out value='${am.value["1"].ammendDESC}'/><%-- this gives me a correct value --%> <p><c:out value="${am.class}"/><br> <c:out value="${am.value}"/><br> </p> </c:forEach>

This is all good and gets the value correctly but only proves that the data is actually in the map. What I now need to do is loop over the frameworks and get the ammendments relative to the frameworks. I can get values like this:
<c:forEach var="fa" items="${requestScope.frameworks}"> <p>---<c:out value="${fa.frameworkDESC}"/> == <c:out value="${fa.frameworkID}"/>---<br> <c:forEach var="am" items="${requestScope.ammendments}"> <c:out value='${am.value[fa.frameworkID].ammendDESC}'/><br> <c:out value='${am.value[fa.frameworkID].ammendID}'/><br> <c:out value='${am.value[fa.frameworkID].ammendNUMB}'/><br> <c:out value='${am.value[fa.frameworkID].frameworkID}'/><br> </c:forEach> </p> </c:forEach>

But that is incorrect as I am not looping over the specific ammendments related to the frameworks which produces holes in the data. So in theory I would need to do this (below) but this gives me no results at all from the ammendment loop, just blank.
<c:forEach var="fa" items="${requestScope.frameworks}"> <p>---<c:out value="${fa.frameworkDESC}"/> == <c:out value="${fa.frameworkID}"/>---<br> <c:forEach var="am" items="${requestScope.ammendments.value[fa.frameworkID]}"> <c:out value='${am.ammendDESC}'/><br> <c:out value='${am.ammendID}'/><br> <c:out value='${am.ammendNUMB}'/><br> <c:out value='${am.frameworkID}'/><br> </c:forEach> </p> </c:forEach>

I have run a test against the class itself and the map is populated correctly. What I think I am missing is the correct way to loop, or interrogate a Map. What could possibly make it work? Or what could be wrong?

Thanks for reading, have a nice day.

cheers
Martin

Excellent. Thank you both for your replies.

Stefan Evans thank you very much for your assistance I see what you mean and it makes sense to me thank you for explaining something so clearly. I will give that code a go.

cheers
Martin

Hello Bear.

Thanks for the reply.

What you describe is kind of my problem exactly. I have been requested to use Spring and Hibernate and am learning both through development of this project. I know what I need to acheive and whilst I am still at these early stages with learning I have decided upon a simple representation of the data from the database as a nested map which logically represents a grouped result to me.

So I have a map of frameworks and within the framework map I have an ammendment map, there is framework data in the framework map and ammendment data, related to the parent framework, in the ammendment map. This is now what I need to output.

So my question is how can I forEach over nested HashMaps?

You can see how I am placing the data into the hashmaps in my original post. I may well change the way that I get the data from the database in the future but for now I just need to get this up and running and HashMaps are the way for me.

P.S. is there anything in JSP || JSTL that will just dump the contents of a hashmap?

Thanks for reading.

cheers
Martin

Hello, just looking for a bit of advice on how I might approach this problem, which is a simple one but I just can't get it to work using Spring Hibernate and JSTL.

What I am trying to acheive is a group result output from 2 tables. Table Frameworks has a one to many with Ammendments.

Now what I want, on the same page, is this
Framework 1 ammend 1 for frame 1 ammend 2 for frame 1 Framework 2 ammend 1 for frame 2 ammend 2 for frame 2 ammend 3 for frame 2 Framework 3 .....


I have tried to put all the frameworks and all the ammendments into 2 seperate hash maps in my controllers referenceData method and then use forEach in the JSTL to access them, with no success, like this (and in a variety of ways) with no success:
${(param["ammendments"].ammendID[f.frameworkID]).ammendDESC}

I also tried to nest the ammendment hashmap into the framework hashmap in my referenceData method like this: (but I don't know how to access this in the JSP page???)
HashMap frames = new HashMap(); List frameworkListNew = frameworkManager.getFrameworks(); for (int i = 0; i < frameworkListNew.size(); i++) { framework = (Framework) frameworkListNew.get(i); frames.put("frameworks", framework); HashMap ammends = new HashMap(); ammends.put("ammendments", ammendmentManager.getAmmendByFrame(framework.getFrameworkID())); frames.putAll(ammends); List ammendList = ammendmentManager.getAmmendByFrame(framework.getFrameworkID()); for(int a = 0; a < ammendList.size(); a++){ ammend = (Ammendment) ammendList.get(a); ammends.put("ammendments", ammend); frames.putAll(ammends); } }

This second way makes more sense to me as I am just using all my spring objects and methods. But how to get the result on the otherside???

Or maybe there is a simpler way with Hibernate?

Thanks for reading.

cheers
Martin

I

Excellent Mike thank you for posting your solution. I have the same setup and the exact same problem, the isELIgnored tags works a treat. Nice one.

cheers
Martin

Originally posted by Mike London:
The problem with my code was I needed a:

<%@ page isELIgnored="true" %>

at the top of the page.

The issues are these:

1) You are not allowed to use JSP scripting elements for "test". Ie the following is illegal:
<c:if test="<%= Math.random() < 0.5 %>">

2) You are using Tomcat 5 and a servlet 2.4 declaration in your web.xml, so the JSP 2.0 expression language is enabled.

3) The ${...} is interpreted by JSP 2 before JSTL gets a chance to get a crack at it.

No problem I am glad it works.

cheers
Martin

Well that error is saying that you do not have the class to run a basic datasource.
Do you have this JAR in your WEB-INF/lib directory:

commons-dbcp-versionNumber.jar

obviously versionNumber in the above would be a number.

You can get it from here:
http://jakarta.apache.org/commons/dbcp/

cheers
Martin

That all looks fine to me, obviously I don't know if you host is correct, I found using the actual IP address to be more effective.

Do you have your Oracle on the standard 1521 port?

Other than that what is the problem do you get an error or?

Can you connect to the database from the machine you are setting up the web app on.

cheers
Martin

Hello no I did not configure the oracle-ds.xml file where is this file found? All the connection information is in the string in the struts datasource.

What is happening that it is not working, any error? And what have you got set up in these properties in your struts-config:
<set-property property="driverClassName" value="oracle.jdbc.driver.OracleDriver" /> <set-property property="url" value="jdbc :o racle:thin:@(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=hereGoesTheHostNameOrIPAddressOfHost)(PORT=1521))(CONNECT_DATA=(SID=yourSidGoesHere)))" />

cheers
Martin


Gerardo Casazza
greenhorn
Member # 129962 posted July 26, 2006 02:09 AM
--------------------------------------------------------------------------------
thank you martin, sorry if i bother you once again but my connection is not working yet, did you configure the oracle-ds.xml?

thank you

Gerardo Casazza
greenhorn
Member # 129962 posted July 25, 2006 11:11 AM
--------------------------------------------------------------------------------
Hi I read your post about oracle connection, i tried to do the same
i included classes12.jar where can i get the other jars
(commons-pool-1.3.jar, commons-collections-3.2.jar, jdbc2_0-stdext.jar) ?

thank you
--------------------------------------------------------------------------------
Posts: 0 | Registered: Jul 2006

Martin Thorpe
ranch hand
Member # 73745 posted July 26, 2006 01:30 AM
--------------------------------------------------------------------------------
Hello you will find them all in this list:

http://jakarta.apache.org/commons/components.html

cheers
Martin
[ July 26, 2006: Message edited by: Martin Thorpe ]

I am a total idiot, it was just a typo but has taken me all morning to realise this :-(

<aciton path="/loginProcess" name="loginForm" type="coreservlets.action.LoginAction"

should read action NOT ACITON

cheers anyway.
Martin

Hello, I am getting these errors reported by my server in the server.log file when I start the server:

Parse Error at line 55 column 25: Element type "aciton" must be declared. org.xml.sax.SAXParseException: Element type "aciton" must be declared. at org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown Source)....

2006-06-28 11:39:48,275 INFO [STDOUT] 11:39:48,275 ERROR [Digester] Parse Fatal Error at line 58 column 5: The element type "aciton" must be terminated by the matching end-tag "</aciton>". org.xml.sax.SAXParseException: The element type "aciton" must be terminated by the matching end-tag "</aciton>". at org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown Source)...

Any idea what this might be, I do have the struts-config file correct with all actions closed:
<form-beans> <form-bean name="employeeForm" type="coreservlets.form.EmployeeForm"/> <form-bean name="loginForm" type="coreservlets.form.LoginForm"/> </form-beans> <action-mappings> <action path="/employeeSetUp" name="employeeForm" type="coreservlets.action.EmployeeAction" scope="request" parameter="dispatch"> <forward name="success" path="/forms/employeeForm.jsp"/> </action> <aciton path="/loginProcess" name="loginForm" type="coreservlets.action.LoginAction" scope="request" parameter="dispatch"> <forward name="failure" path="/forms/loginForm.jsp"/> <forward name="success" path="/display/activeProfiles.jsp"/> </action> <action path="/employeeProcess" name="employeeForm" type="coreservlets.action.EmployeeAction" scope="request" parameter="dispatch"> <forward name="failure" path="/forms/employeeForm.jsp"/> <forward name="success" path="/display/employees.jsp"/> </action> <action path="/activeProfiles" type="coreservlets.action.ProfileAction" parameter="dispatch"> <forward name="success" path="/display/activeProfiles.jsp"/> </action> </action-mappings>

The only thing I can think is in my action class I am not overriding the execute method just using my own:

public ActionForward checkLogin(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) throws Exception{ dsn = (DataSource)servlet.getServletContext().getAttribute("security"); logger.debug("checkLogin"); LoginForm loginForm = (LoginForm)form; if (validateLogin(request, loginForm)) { Login login = new Login(); BeanUtils.copyProperties(login, loginForm); //now run a query checkLogDbase(request, loginForm); return mapping.findForward(Constants.SUCCESS); } else { return mapping.findForward(Constants.FAILURE); } }


Any help, advice or hints would be appreciated.

Thanks for reading.

cheers
Martin